From: tj@kernel.org (Tejun Heo)
To: linux-arm-kernel@lists.infradead.org
Subject: try_to_freeze() called with IRQs disabled on ARM
Date: Tue, 23 Aug 2011 23:53:42 +0200 [thread overview]
Message-ID: <CAOS58YNUSn2eVLDLzqKmrtL7M5tSetkhZ1ODecLK54NSDnZVAA@mail.gmail.com> (raw)
In-Reply-To: <201108232351.55432.rjw@sisk.pl>
Hello,
On Tue, Aug 23, 2011 at 11:51 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>> and the boot runs very slowly. ?Reverting the series merged in 56f0be
>> appears to resolve the issue,
>
> In fact, the patch from:
>
> https://patchwork.kernel.org/patch/1083602/
>
> is sufficient to make the calltrace go away.
Yes, that's true but the added might_sleep() discovered an actual bug
here, so I still think it's better to keep it there.
If proper fix is difficult, I think doing something like if
(!in_atomic()) try_to_freeze() with big fat warning explaining what's
broken and how it should be fixed should do it for now if the proper
fix is gonna take some time. That way, we document what's broken where
it's broken and get to keep the useful debugging annotation.
Thank you.
--
tejun
next prev parent reply other threads:[~2011-08-23 21:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 15:19 try_to_freeze() called with IRQs disabled on ARM Mark Brown
2011-08-23 15:43 ` Russell King - ARM Linux
2011-08-23 22:08 ` Rafael J. Wysocki
2011-08-23 21:51 ` Rafael J. Wysocki
2011-08-23 21:53 ` Tejun Heo [this message]
2011-08-23 22:00 ` Russell King - ARM Linux
2011-08-23 22:08 ` Tejun Heo
2011-08-23 22:13 ` Russell King - ARM Linux
2011-08-23 22:17 ` Tejun Heo
2011-08-23 22:35 ` Tejun Heo
2011-08-24 23:15 ` Rafael J. Wysocki
2011-08-25 12:14 ` Russell King - ARM Linux
2011-08-25 12:17 ` Tejun Heo
2011-08-25 12:25 ` Russell King - ARM Linux
2011-08-25 12:35 ` Tejun Heo
2011-08-25 13:04 ` Russell King - ARM Linux
2011-08-25 13:09 ` Tejun Heo
2011-08-25 14:55 ` Russell King - ARM Linux
2011-08-26 14:44 ` Arnd Bergmann
2011-09-01 13:41 ` Ulrich Weigand
2011-09-01 14:00 ` Russell King - ARM Linux
2011-09-02 14:47 ` Ulrich Weigand
2011-09-02 17:22 ` Russell King - ARM Linux
2011-09-02 17:40 ` Ulrich Weigand
2011-09-02 17:48 ` Russell King - ARM Linux
2011-09-16 10:31 ` Martin Schwidefsky
2011-09-27 17:45 ` Ulrich Weigand
2011-08-30 20:58 ` Mark Brown
2011-08-30 21:10 ` Russell King - ARM Linux
2012-06-26 16:39 ` Mandeep Singh Baines
2012-06-26 17:16 ` Russell King - ARM Linux
2011-08-23 22:13 ` Rafael J. Wysocki
2011-08-25 11:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOS58YNUSn2eVLDLzqKmrtL7M5tSetkhZ1ODecLK54NSDnZVAA@mail.gmail.com \
--to=tj@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).