From: steve@sakoman.com (Steve Sakoman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP3: OPP: Test for IVA subsystem before attempting to add IVA OPP
Date: Fri, 16 Mar 2012 09:04:28 -0700 [thread overview]
Message-ID: <CAOSpxdaTcMnp5tvNFO1AcvZJPXZ+X0GkVv6NBt59LmzuFGVdUA@mail.gmail.com> (raw)
In-Reply-To: <20120316142034.GA22234@senorita.am.dhcp.ti.com>
On Fri, Mar 16, 2012 at 7:20 AM, Nishanth Menon <nm@ti.com> wrote:
> From 5275d09c9f1a16c8f0814745e1c313c6cca049f6 Mon Sep 17 00:00:00 2001
> From: Nishanth Menon <nm@ti.com>
> Date: Fri, 16 Mar 2012 09:13:24 -0500
> Subject: [PATCH] OMAP2+: OPP: allow OPP enumeration to continue if device is not present
>
> On platforms such as OMAP3, certain variants may not have IVA, SGX
> or some specific component. We currently have a check to aid fixing
> wrong population of OPP entries for issues such as typos. This however
> causes a conflict with valid requirement where the SoC variant does
> not actually have the module present.
>
> So, reduce the severity of the print to a debug statement and skip
> registering that specific OPP, but continue down the list.
>
> Reported-by: Steve Sakoman <steve@sakoman.com>
> Reported-by: Maximilian Schwerin <mvs@tigris.de>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> ?arch/arm/mach-omap2/opp.c | ? ?4 ++--
> ?1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/opp.c b/arch/arm/mach-omap2/opp.c
> index 9262a6b..de6d464 100644
> --- a/arch/arm/mach-omap2/opp.c
> +++ b/arch/arm/mach-omap2/opp.c
> @@ -64,10 +64,10 @@ int __init omap_init_opp_table(struct omap_opp_def *opp_def,
> ? ? ? ? ? ? ? ?}
> ? ? ? ? ? ? ? ?oh = omap_hwmod_lookup(opp_def->hwmod_name);
> ? ? ? ? ? ? ? ?if (!oh || !oh->od) {
> - ? ? ? ? ? ? ? ? ? ? ? pr_warn("%s: no hwmod or odev for %s, [%d] "
> + ? ? ? ? ? ? ? ? ? ? ? pr_debug("%s: no hwmod or odev for %s, [%d] "
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?"cannot add OPPs.\n", __func__,
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?opp_def->hwmod_name, i);
> - ? ? ? ? ? ? ? ? ? ? ? return -EINVAL;
> + ? ? ? ? ? ? ? ? ? ? ? continue;
> ? ? ? ? ? ? ? ?}
> ? ? ? ? ? ? ? ?dev = &oh->od->pdev->dev;
>
> --
> 1.7.0.4
Acked-by: Steve Sakoman <steve@sakoman.com>
next prev parent reply other threads:[~2012-03-16 16:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 17:38 [PATCH] OMAP3: OPP: Test for IVA subsystem before attempting to add IVA OPP Maximilian Schwerin
2012-03-14 21:15 ` Kevin Hilman
2012-03-14 21:35 ` Menon, Nishanth
2012-03-14 22:06 ` Kevin Hilman
2012-03-16 9:26 ` AW: " Maximilian Schwerin
2012-03-16 14:20 ` Nishanth Menon
2012-03-16 15:47 ` AW: " Maximilian Schwerin
2012-03-16 15:57 ` Menon, Nishanth
2012-03-16 16:04 ` Steve Sakoman [this message]
2012-03-19 21:27 ` Kevin Hilman
2012-03-19 21:29 ` Menon, Nishanth
2012-03-20 0:15 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOSpxdaTcMnp5tvNFO1AcvZJPXZ+X0GkVv6NBt59LmzuFGVdUA@mail.gmail.com \
--to=steve@sakoman.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).