From: seanpaul@google.com (Sean Paul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -next] drm/rockchip: analogix_dp: add missing clk_disable_unprepare() on error
Date: Tue, 19 Jul 2016 16:38:15 -0400 [thread overview]
Message-ID: <CAOw6vbKT--+A=wFdx2=PT7FCYga-ArDSrw4ypFDmqqaiitHyPQ@mail.gmail.com> (raw)
In-Reply-To: <1468927963-2947-1-git-send-email-weiyj_lk@163.com>
On Tue, Jul 19, 2016 at 7:32 AM, Wei Yongjun <weiyj_lk@163.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Add the missing clk_disable_unprepare() before return in the
> error handling case.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied to drm-misc
> ---
> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> index e81e19a..89aadbf 100644
> --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> @@ -96,6 +96,7 @@ static int rockchip_dp_poweron(struct analogix_dp_plat_data *plat_data)
> ret = rockchip_dp_pre_init(dp);
> if (ret < 0) {
> dev_err(dp->dev, "failed to dp pre init %d\n", ret);
> + clk_disable_unprepare(dp->pclk);
> return ret;
> }
>
> @@ -272,6 +273,7 @@ static int rockchip_dp_init(struct rockchip_dp_device *dp)
> ret = rockchip_dp_pre_init(dp);
> if (ret < 0) {
> dev_err(dp->dev, "failed to pre init %d\n", ret);
> + clk_disable_unprepare(dp->pclk);
> return ret;
> }
>
>
prev parent reply other threads:[~2016-07-19 20:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 11:32 [PATCH -next] drm/rockchip: analogix_dp: add missing clk_disable_unprepare() on error Wei Yongjun
2016-07-19 20:38 ` Sean Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOw6vbKT--+A=wFdx2=PT7FCYga-ArDSrw4ypFDmqqaiitHyPQ@mail.gmail.com' \
--to=seanpaul@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).