From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D52FC636CC for ; Sat, 4 Feb 2023 21:26:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/FKVAugzgiOKn7XCiIk9cGEFCpqIcnbBo6KqomcvFr8=; b=NhGKwZsadZsq2Y 7wRYZikjqIBmbOoZbSRxPAHFBlQx+JaL+FIYFNJmIC32NVjl5ioO8rshhSbYZxvXfKXutcEeB1MVA l2mXud3/nryMpAyV4oLy1D+9xth7VqUnWF09Jq3ZQ6K3qXtlv9jqNl5wodqzMEoC4j3dJejp8k8S9 BD8GwluO/nG1ao3ImOVq9GK/DsDXBIcLVMsHl5tamdNh5ou9HoIfK6PuaYtzGpn9/ygY8L0k6T7Uj t0tqerg5926cK/F8g68Mqw/09ZLOll3+wnwyUZNKMb3gQR3D7xkJs+zNIIgf/tLUXKegh1j9KB5oK rX44qdpeXN8imbI4JiHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pOQ2g-005aUk-5q; Sat, 04 Feb 2023 21:25:50 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pOQ2d-005aTk-4C for linux-arm-kernel@lists.infradead.org; Sat, 04 Feb 2023 21:25:48 +0000 Received: by mail-wr1-x435.google.com with SMTP id a2so7109834wrd.6 for ; Sat, 04 Feb 2023 13:25:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5QucXsCUGkAYvMM/m5+lQnUtugoTYxql3JyDPSNTCSc=; b=gMgnnl4uis9wwGEAHmp91wWTN6meZgAsGLuzViwo3jWh+ke27ZTYyh0hM2AFm3dmsl fpU/2t2R9T0+r+de/yRta7sMJaNAA+z/JUNyJp/3VGmj5nHedUDLMncJKnP7q/xSg7D3 GmiVdUZ+I1Li+cl2Ky6bItiKKioQ6Zi9bu/ULaVFhvBTTZOdD5LmKGQ+OQ+Goec93wIG 5npijm0lwYSo+Tf4foSxd4Y1YFt24OnkmqMk8pelStoDWhCh6h1kUecYwA1ZMPGcFm1S Bb6hdQcRQhh0pG2mNwUP4CFgsl8BDCnMNBuDJsTRBZHVVZZ1y5WnUqs8OyK7p0jyU4Fz 8CEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5QucXsCUGkAYvMM/m5+lQnUtugoTYxql3JyDPSNTCSc=; b=ENfJM9E2w8JpxI7zOj8VDVfRIuM8R8vB2WaK7pHh+2hj5GKVMpHKTpnxvDrle8zNGr qxX1fNH70m6zz1waKLvKHdzZaPcX8nmkVvP1+1I9DWU/0MqHmB+XkhmSQmrgxNh0B5qd 6XMtV0ezizGFIZjzgOmfl44nt4yVASxaXi7j9olUaz+CjcnIb0FPCqBJvihocR06nEf6 ERF0ZrsOR/4lovfhfJRi22FqtqlI5jFPLrD3UOZlE+F+ctIHL+yBRRg7E8Gw/RVtHUI4 YbhCkfHNTPsPBAZRLGeupgegXoNF/tCxCHpX7EyY6+0CeUiiU6rBZitM/bCKTjd9v3v+ SALg== X-Gm-Message-State: AO0yUKULq0H+blbFXRd6OzDT5UDQT505U0mBpBknSO6Nv8fBJ0jul5OI afdsjlnM6v+HnYmX+rg/IlhmptOrVhtCZG11rp7QMA== X-Google-Smtp-Source: AK7set9CbvgLfEJ2jn5/zRiDcIDRmDUMIjRHSnXWFoR7u6wNniF5tZuwENqZy7NCTcl7ArQhLKCbViMrWUHcVJ3zCEg= X-Received: by 2002:a05:6000:16c4:b0:2c3:7ee6:e3ad with SMTP id h4-20020a05600016c400b002c37ee6e3admr632269wrf.289.1675545944934; Sat, 04 Feb 2023 13:25:44 -0800 (PST) MIME-Version: 1.0 References: <20230126233645.200509-1-irogers@google.com> <20230126233645.200509-16-irogers@google.com> In-Reply-To: From: Ian Rogers Date: Sat, 4 Feb 2023 13:25:31 -0800 Message-ID: Subject: Re: [PATCH v5 15/15] perf jevents: Run metric_test.py at compile-time To: Arnaldo Carvalho de Melo Cc: John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kan Liang , Kim Phillips , Florian Fischer , Ravi Bangoria , Xing Zhengjun , Rob Herring , Kang Minchul , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Sandipan Das , Jing Zhang , linuxppc-dev@lists.ozlabs.org, Kajol Jain , Stephane Eranian , Perry Taylor , Caleb Biggers X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230204_132547_185167_A7FC86BD X-CRM114-Status: GOOD ( 14.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 3, 2023 at 12:15 PM Arnaldo Carvalho de Melo wrote: > > Em Thu, Jan 26, 2023 at 03:36:45PM -0800, Ian Rogers escreveu: > > Add a target that generates a log file for running metric_test.py and > > make this a dependency on generating pmu-events.c. The log output is > > displayed if the test fails like (the test was modified to make it > > fail): > > > > ``` > > TEST /tmp/perf/pmu-events/metric_test.log > > F...... > > ====================================================================== > > FAIL: test_Brackets (__main__.TestMetricExpressions) > > ---------------------------------------------------------------------- > > Traceback (most recent call last): > > File "tools/perf/pmu-events/metric_test.py", line 33, in test_Brackets > > self.assertEqual((a * b + c).ToPerfJson(), 'a * b + d') > > AssertionError: 'a * b + c' != 'a * b + d' > > - a * b + c > > ? ^ > > + a * b + d > > Added this: > > diff --git a/tools/perf/.gitignore b/tools/perf/.gitignore > index 05806ecfc33c12a1..f533e76fb48002b7 100644 > --- a/tools/perf/.gitignore > +++ b/tools/perf/.gitignore > @@ -38,6 +38,7 @@ arch/*/include/generated/ > trace/beauty/generated/ > pmu-events/pmu-events.c > pmu-events/jevents > +pmu-events/metric_test.log > feature/ > libapi/ > libbpf/ > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > index b7d9c42062300d04..bac9272682b759e9 100644 > --- a/tools/perf/Makefile.perf > +++ b/tools/perf/Makefile.perf > @@ -1103,6 +1103,7 @@ clean:: $(LIBAPI)-clean $(LIBBPF)-clean $(LIBSUBCMD)-clean $(LIBSYMBOL)-clean $( > $(OUTPUT)util/intel-pt-decoder/inat-tables.c \ > $(OUTPUT)tests/llvm-src-{base,kbuild,prologue,relocation}.c \ > $(OUTPUT)pmu-events/pmu-events.c \ > + $(OUTPUT)pmu-events/metric_test.log \ > $(OUTPUT)$(fadvise_advice_array) \ > $(OUTPUT)$(fsconfig_arrays) \ > $(OUTPUT)$(fsmount_arrays) \ Acked, thanks! Ian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel