From: xerofoify@gmail.com (Nick Krause)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mach-s3c64xx: Remove all defintions not related to regs-clocks
Date: Wed, 16 Jul 2014 21:13:19 -0400 [thread overview]
Message-ID: <CAPDOMVgOfaf7qHXGSdwpyT4edo_ZjbbnkP7UYNbzkRzudW_f-A@mail.gmail.com> (raw)
In-Reply-To: <36350.1405374230@turing-police.cc.vt.edu>
On Mon, Jul 14, 2014 at 5:43 PM, <Valdis.Kletnieks@vt.edu> wrote:
> On Mon, 14 Jul 2014 14:14:24 -0400, Nicholas Krause said:
>> This patch addresses the fix me message in this file that states to
>> remove all definitions not related to reg-clocks in this header
>> file.
>>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>> ---
>> arch/arm/mach-s3c64xx/include/mach/regs-clock.h | 22 +---------------------
>> 1 file changed, 1 insertion(+), 21 deletions(-)
>
>> -#endif /* _PLAT_REGS_CLOCK_H */
>> +/#endif /* _PLAT_REGS_CLOCK_H */
>
> You're kidding us, right? Given that this was obviously *not* compile
> tested at all, why should we believe that in fact all those #defines
> are in fact no longer used?
>
> Hint: There's a very high chance that somebody stuck that FIXME in there rather
> than just cleaning it up themselves precisely *because* it was still in use in
> an inconvenient to fix place in the tree..
>
I build the arch/arm directory I seem to me hitting a error.
arch/arm/xen/enlighten.c:17:29: fatal error: asm/system_misc.h: No
such file or directory
#include <asm/system_misc.h>
I am also looking into fixing this issue.
Cheers Nick
prev parent reply other threads:[~2014-07-17 1:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 18:14 [PATCH] mach-s3c64xx: Remove all defintions not related to regs-clocks Nicholas Krause
2014-07-14 18:23 ` Randy Dunlap
2014-07-14 18:40 ` Paul Bolle
2014-07-14 18:45 ` Randy Dunlap
2014-07-14 18:56 ` Nick Krause
2014-07-14 18:34 ` Randy Dunlap
2014-07-14 18:51 ` Arnd Bergmann
2014-07-14 21:43 ` Valdis.Kletnieks at vt.edu
2014-07-17 1:13 ` Nick Krause [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDOMVgOfaf7qHXGSdwpyT4edo_ZjbbnkP7UYNbzkRzudW_f-A@mail.gmail.com \
--to=xerofoify@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).