* [PATCH] imx8m-blk-ctrl: set ISI panic write hurry level
@ 2025-05-09 9:26 Krzysztof Hałasa
2025-06-18 12:56 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Hałasa @ 2025-05-09 9:26 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer
Cc: Ulf Hansson, Pengutronix Kernel Team, Fabio Estevam, Peng Fan,
linux-pm, imx, linux-arm-kernel, linux-kernel
Apparently, ISI needs cache settings similar to LCDIF.
Otherwise we get artefacts in the image.
Tested on i.MX8MP.
Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>
diff --git a/drivers/pmdomain/imx/imx8m-blk-ctrl.c b/drivers/pmdomain/imx/imx8m-blk-ctrl.c
index 912802b5215b..5c83e5599f1e 100644
--- a/drivers/pmdomain/imx/imx8m-blk-ctrl.c
+++ b/drivers/pmdomain/imx/imx8m-blk-ctrl.c
@@ -665,6 +665,11 @@ static const struct imx8m_blk_ctrl_data imx8mn_disp_blk_ctl_dev_data = {
#define LCDIF_1_RD_HURRY GENMASK(15, 13)
#define LCDIF_0_RD_HURRY GENMASK(12, 10)
+#define ISI_CACHE_CTRL 0x50
+#define ISI_V_WR_HURRY GENMASK(28, 26)
+#define ISI_U_WR_HURRY GENMASK(25, 23)
+#define ISI_Y_WR_HURRY GENMASK(22, 20)
+
static int imx8mp_media_power_notifier(struct notifier_block *nb,
unsigned long action, void *data)
{
@@ -694,6 +699,11 @@ static int imx8mp_media_power_notifier(struct notifier_block *nb,
regmap_set_bits(bc->regmap, LCDIF_ARCACHE_CTRL,
FIELD_PREP(LCDIF_1_RD_HURRY, 7) |
FIELD_PREP(LCDIF_0_RD_HURRY, 7));
+ /* Same here for ISI */
+ regmap_set_bits(bc->regmap, ISI_CACHE_CTRL,
+ FIELD_PREP(ISI_V_WR_HURRY, 7) |
+ FIELD_PREP(ISI_U_WR_HURRY, 7) |
+ FIELD_PREP(ISI_Y_WR_HURRY, 7));
}
return NOTIFY_OK;
--
Krzysztof "Chris" Hałasa
Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] imx8m-blk-ctrl: set ISI panic write hurry level
2025-05-09 9:26 [PATCH] imx8m-blk-ctrl: set ISI panic write hurry level Krzysztof Hałasa
@ 2025-06-18 12:56 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2025-06-18 12:56 UTC (permalink / raw)
To: Krzysztof Hałasa
Cc: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Peng Fan, linux-pm, imx, linux-arm-kernel, linux-kernel
On Fri, 9 May 2025 at 11:26, Krzysztof Hałasa <khalasa@piap.pl> wrote:
>
> Apparently, ISI needs cache settings similar to LCDIF.
> Otherwise we get artefacts in the image.
> Tested on i.MX8MP.
>
> Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>
Applied for next, thanks!
Kind regards
Uffe
>
> diff --git a/drivers/pmdomain/imx/imx8m-blk-ctrl.c b/drivers/pmdomain/imx/imx8m-blk-ctrl.c
> index 912802b5215b..5c83e5599f1e 100644
> --- a/drivers/pmdomain/imx/imx8m-blk-ctrl.c
> +++ b/drivers/pmdomain/imx/imx8m-blk-ctrl.c
> @@ -665,6 +665,11 @@ static const struct imx8m_blk_ctrl_data imx8mn_disp_blk_ctl_dev_data = {
> #define LCDIF_1_RD_HURRY GENMASK(15, 13)
> #define LCDIF_0_RD_HURRY GENMASK(12, 10)
>
> +#define ISI_CACHE_CTRL 0x50
> +#define ISI_V_WR_HURRY GENMASK(28, 26)
> +#define ISI_U_WR_HURRY GENMASK(25, 23)
> +#define ISI_Y_WR_HURRY GENMASK(22, 20)
> +
> static int imx8mp_media_power_notifier(struct notifier_block *nb,
> unsigned long action, void *data)
> {
> @@ -694,6 +699,11 @@ static int imx8mp_media_power_notifier(struct notifier_block *nb,
> regmap_set_bits(bc->regmap, LCDIF_ARCACHE_CTRL,
> FIELD_PREP(LCDIF_1_RD_HURRY, 7) |
> FIELD_PREP(LCDIF_0_RD_HURRY, 7));
> + /* Same here for ISI */
> + regmap_set_bits(bc->regmap, ISI_CACHE_CTRL,
> + FIELD_PREP(ISI_V_WR_HURRY, 7) |
> + FIELD_PREP(ISI_U_WR_HURRY, 7) |
> + FIELD_PREP(ISI_Y_WR_HURRY, 7));
> }
>
> return NOTIFY_OK;
>
> --
> Krzysztof "Chris" Hałasa
>
> Sieć Badawcza Łukasiewicz
> Przemysłowy Instytut Automatyki i Pomiarów PIAP
> Al. Jerozolimskie 202, 02-486 Warszawa
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-18 14:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-09 9:26 [PATCH] imx8m-blk-ctrl: set ISI panic write hurry level Krzysztof Hałasa
2025-06-18 12:56 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).