From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65971C64E7A for ; Mon, 23 Nov 2020 12:30:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0288B2076E for ; Mon, 23 Nov 2020 12:30:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="T9Rnf9Kg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Drj+eK7h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0288B2076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=d9tIrtVwYppXNay/9in4DzeWvnmm5+wJX6zzWqNY3bI=; b=T9Rnf9KghSTdrI+M985W3/MkX CUdgEYe1yOgpJnmcKeJsBZGmW2hf32mSpfO4xiUaqYYdlovAunFnf6uTh9BIaiFRLT7SRygubW0Us 6fAEyr485Rji4RzNSS8QjrXOC6rTR9WU/YCdOrkdoFAwWB8Vgw1R8sH5un0c0DZG7q+vOdIqQ/zwR Iei7Q2wFwqZMzTV6M4dpsca+Q/taSrlfo0sNGuZ+uvn3EwPXaZHi1nSd/N4CfElQNoE++BQsnbcB9 Km3k07cS62NtJBfQBvHb6TsfyE/EHSq/YfH4Y4yGh7EqefjWR2IvpVaqkg/i8yr8y9Ax8SnsrzAKM 4s2ZGnAFA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khAxo-0007Iq-Gs; Mon, 23 Nov 2020 12:29:00 +0000 Received: from mail-ua1-x943.google.com ([2607:f8b0:4864:20::943]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khAxk-0007HA-8C for linux-arm-kernel@lists.infradead.org; Mon, 23 Nov 2020 12:28:57 +0000 Received: by mail-ua1-x943.google.com with SMTP id r23so5603098uak.0 for ; Mon, 23 Nov 2020 04:28:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IMrDSBRZ+BrQ7IeHtOwZdwbcJ4Pv+oUEuoNbzrU6uKc=; b=Drj+eK7hkAME0UZZLujX/V8zmRw/3UY95f5P2X9PZV/s8n/74Mch82IWyPSn0ruL1j DFdQwzjxW+nBZFpvdc4eOkzxaa+Xfed/oAcYHGrQVUOGpjPfVASJtyQibLYPWCoNAocE lS+SvY5rkcTNDvQWJk0ui6mJ+3oYBBbLXhlDt8h7tuma6YNk8v0YZzOSfdv0DSVh1fHx KAKxUiFDqnPOoajBuMMoP3IBufZeBLIzG7Hz7nvqWP/5KsB03L82Rjzn/qQoB2a1iNGn h+NRt3ee3VO8Iumb/PsHka48vTgMWC0nkqIxEOrLluq/x6wW8dQ56Rt/VnVUnq2HK+2N aF/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IMrDSBRZ+BrQ7IeHtOwZdwbcJ4Pv+oUEuoNbzrU6uKc=; b=CDKxvQPzermj0AdVjCX8tU+EKWfAaQ/olLeFLCC3t0YetoM4/7AYTT1de1y9Mwrv8T P7cxWoNQvmpBE2L3N/+3XoKqc1K1fayeMbqe+3VaZyD42tQ+wRLmKjoId5J7LdATjeUU f6RVSlLGg6qGdIaM9Gi7nioXQsOGXvTSH/YRQgTQ/6Jl+IUyRxKE4QK0XXyUBWGiTFvI hqk9fX9i9MR4LXNgyer9sy8V0H99wWl9UpRc8wgtAy8R9zBzZjs7nDSW4uj9dOTJmXRr fUtvn/gtj4xrz84uSqQI1HfwnIHBgKTOkjrGHWK4eIA/JqK8B3RLEuCyLW7LbizWTh3+ SEeQ== X-Gm-Message-State: AOAM53072EI4sUSET26W7PoxukXw/m9tNuJS1jlSAPqIiaDfZX6RlViK MIApfwiF2idbqjhvKGbbnJyVE8Q/UpZFn+79XwhqFA== X-Google-Smtp-Source: ABdhPJz7vYzOTV67myWhhRTgaBDXcXPu8RnLR6NqSvVbMutDb0CzrqOVlsiqjvhYCXdDOuMLfOtYC7kyyknGi09T8x0= X-Received: by 2002:ab0:c12:: with SMTP id a18mr17291520uak.19.1606134532749; Mon, 23 Nov 2020 04:28:52 -0800 (PST) MIME-Version: 1.0 References: <20201119125304.1279-1-aisheng.dong@nxp.com> <20201119131720.GA348129@kozik-lap> <20201119152535.GA386850@kozik-lap> In-Reply-To: <20201119152535.GA386850@kozik-lap> From: Ulf Hansson Date: Mon, 23 Nov 2020 13:28:15 +0100 Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string To: Krzysztof Kozlowski , Aisheng Dong X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_072856_584848_203BC4AC X-CRM114-Status: GOOD ( 19.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Bough Chen , "linux-mmc@vger.kernel.org" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 19 Nov 2020 at 16:25, Krzysztof Kozlowski wrote: > > On Thu, Nov 19, 2020 at 03:21:59PM +0000, Aisheng Dong wrote: > > > From: Krzysztof Kozlowski > > > Sent: Thursday, November 19, 2020 9:17 PM > > > > > > On Thu, Nov 19, 2020 at 08:53:02PM +0800, Dong Aisheng wrote: > > > > The compatible string "fsl,imx8qm-usdhc" was wrongly dropped in patch: > > > > 80fd350b9590 ("dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible > > > > matching") Add it back. > > > > > > Although the compatible was dropped, by why wrongly? Please describe it. > > > The compatible is nowhere to be found, it is not used. > > > > The DT patch using it is still under review. So we need it. Where? Is there a corresponding update to the mmc driver? > > It looks like other patches here follow similar process of sending > and applying dt-bindings separately from patches with users of these > bindings. Please don't do it like this. Send the bindings as the first > patch in the series implementing the users (so usually the series with > driver and DTS changes). The new bindings then are applied by the > driver subsystem maintainer. Yep, I fully agree, that's the preferred approach. Perhaps it's simply better if the series is reposted to linux-mmc (including the DT doc). Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel