From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09AE5C35247 for ; Wed, 5 Feb 2020 15:56:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDF5D20702 for ; Wed, 5 Feb 2020 15:56:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Eskugq1X"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Nbq5QFkL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDF5D20702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YyRag+lUqgSJyvNelgLB3RbPWYjgOwXUx1jYDct5nAk=; b=Eskugq1XlP39VD uuYg+8N00//AjfBP36izDgHAL/lzsH74OcUArevkNBpEO1vPprnBJXRS8tzSQfxoBY5Io15Z8AKhp 4AcIoa3ACaDZGQyuSUIHhnaT7HnomGrpfN7EU5jTHzDXinnlpPG9WUcAra3X1EvFoI3rtj+uCEqdg 44w7LCWENwIjdOUmyJWp1p/tBBpDQrqhxTjdbKVFpzu5YcxuYm/Yp+CmparWYUnZ/bydTIdfBlqAV cYkw28othGtM9Nh7S6sKJTeYSJcT0hQjC7cRx7pn1jxd/FkrxuOjwLzYK1NluUMnAG954ODfr1Yff s7cOK8PKK8QWbW6RCQ5w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1izN1z-0007tj-M3; Wed, 05 Feb 2020 15:55:59 +0000 Received: from mail-vs1-xe41.google.com ([2607:f8b0:4864:20::e41]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1izN1v-0007sj-GM for linux-arm-kernel@lists.infradead.org; Wed, 05 Feb 2020 15:55:56 +0000 Received: by mail-vs1-xe41.google.com with SMTP id p6so1613285vsj.11 for ; Wed, 05 Feb 2020 07:55:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ei9H45SV2oMs69C7hL0SyaAz256oxS6zCX5MjvjcWsU=; b=Nbq5QFkLGVrepL0kiN0uMOeJSiQzYs0SIsaGXzuFw02d55rgJXVER2UguTreuVRGJO Od4xBaxLrJDFSjE6bsj/+aUv9g+rYikRSWZyUQledbdk/qhAy29jK+vcs1DSM5HzxPuO c5BOqGKN/1CIxVjv2yrQJRe4hCvPMRT57oeV36R1VPLE01xb9GAo9MxqQEOTMXvDJNZk zkaFAQgOgMOYJxNPMgclviF2hmrn2Yfp6AO3+sQxJIajd3Ok/x+B0cgXXgWrzRXYHfKd fpR95zPsC6lrCVdelVsr4LatgdvMAc1Y+1iJx5DWEh/KAgqOL/zuXYPqb5PRsywUb1/s Ze9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ei9H45SV2oMs69C7hL0SyaAz256oxS6zCX5MjvjcWsU=; b=FI4xA6txEZHC9SPOI8TFd80dhyIhdvG4yJmAXhvHaVCcOY5k2pml/7X54lkfJ4z1PQ SYKhRh1BSsxhBOac94kPvRM4Crlzvc88twnprjssIKJB1NK4dU5FAk+27PW1jxT2r2wA NA+iZu4xJGrPthpLOqWTfKUzuRD+NuUPMxkuHEHsStEdjS4z5snL5BEAFpJiYskckm7r 2loUOaZEeP5Acz+JfYByz+yiiSaNC71u+l4B+twRjZR9aE8Y+W9gC2O6Vc1g2EjiRMK9 RSxDQqGa1FgyHaxeGKlUA1sBtGjQNh1MORY3TyWM1ArH9ypYp/nPUE/qvRj6VgmTMeFB oIlw== X-Gm-Message-State: APjAAAXx6LVaSVI3F25QZOnk+uvE6YzZqD7irIJUHL5HqfY4DzkA1DL/ kz3bhCvXWfQoxH+CLbpYQYWCJHDHTgVfzsO39Imq7w== X-Google-Smtp-Source: APXvYqwSSPQAZY6rLGXHvigKNLyKPELRR7aaS7nR0axlfGQtU2mVxCkKTFTO+6ddkXy//tB9BMu4/9jHYzXyjFWuYuM= X-Received: by 2002:a05:6102:757:: with SMTP id v23mr22937800vsg.35.1580918153583; Wed, 05 Feb 2020 07:55:53 -0800 (PST) MIME-Version: 1.0 References: <1580736940-6985-1-git-send-email-mkshah@codeaurora.org> <1580736940-6985-6-git-send-email-mkshah@codeaurora.org> <20200203170832.GA38466@bogus> <0d7f7ade-3a1e-5428-d851-f1a886f58712@codeaurora.org> <20200204152132.GA44858@bogus> <6ff7c82d-4204-a339-4070-0154ab4515f1@codeaurora.org> <20200205140603.GB38466@bogus> In-Reply-To: <20200205140603.GB38466@bogus> From: Ulf Hansson Date: Wed, 5 Feb 2020 16:55:17 +0100 Message-ID: Subject: Re: [PATCH v3 5/7] drivers: firmware: psci: Add hierarchical domain idle states converter To: Sudeep Holla X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200205_075555_556271_DB1A77DD X-CRM114-Status: GOOD ( 21.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maulik Shah , lsrao@codeaurora.org, Lorenzo Pieralisi , Rajendra Nayak , Linux PM , linux-arm-msm , "Rafael J. Wysocki" , Linux Kernel Mailing List , Evan Green , Stephen Boyd , David Brown , Andy Gross , Lina Iyer , Doug Anderson , Bjorn Andersson , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 5 Feb 2020 at 15:06, Sudeep Holla wrote: > > On Wed, Feb 05, 2020 at 05:53:00PM +0530, Maulik Shah wrote: > > > > On 2/4/2020 8:51 PM, Sudeep Holla wrote: > > > On Tue, Feb 04, 2020 at 10:22:42AM +0530, Maulik Shah wrote: > > > > On 2/3/2020 10:38 PM, Sudeep Holla wrote: > > > > > On Mon, Feb 03, 2020 at 07:05:38PM +0530, Maulik Shah wrote: > > > > > > From: Ulf Hansson > > > > > > > > > > > > If the hierarchical CPU topology is used, but the OS initiated mode isn't > > > > > > supported, we need to rely solely on the regular cpuidle framework to > > > > > > manage the idle state selection, rather than using genpd and its > > > > > > governor. > > > > > > > > > > > > For this reason, introduce a new PSCI DT helper function, > > > > > > psci_dt_pm_domains_parse_states(), which parses and converts the > > > > > > hierarchically described domain idle states from DT, into regular flattened > > > > > > cpuidle states. The converted states are added to the existing cpuidle > > > > > > driver's array of idle states, which make them available for cpuidle. > > > > > > > > > > > And what's the main motivation for this if OSI is not supported in the > > > > > firmware ? > > > > Hi Sudeep, > > > > > > > > Main motivation is to do last-man activities before the CPU cluster can > > > > enter a deep idle state. > > > > > > > Details on those last-man activities will help the discussion. Basically > > > I am wondering what they are and why they need to done in OSPM ? > > > > Hi Sudeep, > > > > there are cases like, > > > > Last cpu going to deepest idle mode need to lower various resoruce > > requirements (for eg DDR freq). > > > > In PC mode, only PSCI implementation knows the last man and there shouldn't > be any notion of it in OS. If you need it, you may need OSI. You are still > mixing up the things. NACK for any such approach, sorry. Sudeep, I don't quite agree with your NACK to this. At least not yet. :-) I do agree that the best suited solution seems to be OSI, as to support this kind of SoC requirements. However, if for some reason the PC mode is being used, we could still allow Linux to control "last-man activities" as it knows what each CPU has voted for when going idle. Yes, the PSCI FW decides in the end, but that doesn't really matter. Or is there another technical reason to why you object? As a matter of fact, if we allow support for PC mode with "last-man-activities", it would allow us to make a fair performance/energy comparison between the two PSCI CPU suspend modes, for the same SoC. I would be thrilled about looking into doing such tests, I bet you are as well!? Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel