From: Ulf Hansson <ulf.hansson@linaro.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH] mmc: meson-gx: constify member data of struct meson_host
Date: Fri, 17 Feb 2023 11:56:12 +0100 [thread overview]
Message-ID: <CAPDyKFp=FWZ99Zq6us6Opym+9qkv6LO7HXOU0aMA3D7eFSq=Pg@mail.gmail.com> (raw)
In-Reply-To: <70e5520f-e327-111d-9ea4-824460e41561@gmail.com>
On Wed, 15 Feb 2023 at 21:01, Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> Constify member data of struct meson_host. This also allows to remove
> the cast as of_device_get_match_data() returns a const void *.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/meson-gx-mmc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 6ed95c555..641ea4292 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -150,7 +150,7 @@ struct sd_emmc_desc {
>
> struct meson_host {
> struct device *dev;
> - struct meson_mmc_data *data;
> + const struct meson_mmc_data *data;
> struct mmc_host *mmc;
> struct mmc_command *cmd;
>
> @@ -1195,8 +1195,7 @@ static int meson_mmc_probe(struct platform_device *pdev)
> if (mmc->caps & MMC_CAP_SDIO_IRQ)
> mmc->caps2 |= MMC_CAP2_SDIO_IRQ_NOTHREAD;
>
> - host->data = (struct meson_mmc_data *)
> - of_device_get_match_data(&pdev->dev);
> + host->data = of_device_get_match_data(&pdev->dev);
> if (!host->data)
> return -EINVAL;
>
> --
> 2.39.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-02-17 10:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 20:01 [PATCH] mmc: meson-gx: constify member data of struct meson_host Heiner Kallweit
2023-02-17 10:56 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFp=FWZ99Zq6us6Opym+9qkv6LO7HXOU0aMA3D7eFSq=Pg@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).