* [PATCH] mmc: meson-gx: constify member data of struct meson_host
@ 2023-02-15 20:01 Heiner Kallweit
2023-02-17 10:56 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2023-02-15 20:01 UTC (permalink / raw)
To: Ulf Hansson, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl
Cc: linux-arm-kernel@lists.infradead.org,
open list:ARM/Amlogic Meson..., linux-mmc@vger.kernel.org
Constify member data of struct meson_host. This also allows to remove
the cast as of_device_get_match_data() returns a const void *.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/mmc/host/meson-gx-mmc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 6ed95c555..641ea4292 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -150,7 +150,7 @@ struct sd_emmc_desc {
struct meson_host {
struct device *dev;
- struct meson_mmc_data *data;
+ const struct meson_mmc_data *data;
struct mmc_host *mmc;
struct mmc_command *cmd;
@@ -1195,8 +1195,7 @@ static int meson_mmc_probe(struct platform_device *pdev)
if (mmc->caps & MMC_CAP_SDIO_IRQ)
mmc->caps2 |= MMC_CAP2_SDIO_IRQ_NOTHREAD;
- host->data = (struct meson_mmc_data *)
- of_device_get_match_data(&pdev->dev);
+ host->data = of_device_get_match_data(&pdev->dev);
if (!host->data)
return -EINVAL;
--
2.39.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mmc: meson-gx: constify member data of struct meson_host
2023-02-15 20:01 [PATCH] mmc: meson-gx: constify member data of struct meson_host Heiner Kallweit
@ 2023-02-17 10:56 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2023-02-17 10:56 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
linux-arm-kernel@lists.infradead.org,
open list:ARM/Amlogic Meson..., linux-mmc@vger.kernel.org
On Wed, 15 Feb 2023 at 21:01, Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> Constify member data of struct meson_host. This also allows to remove
> the cast as of_device_get_match_data() returns a const void *.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/meson-gx-mmc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 6ed95c555..641ea4292 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -150,7 +150,7 @@ struct sd_emmc_desc {
>
> struct meson_host {
> struct device *dev;
> - struct meson_mmc_data *data;
> + const struct meson_mmc_data *data;
> struct mmc_host *mmc;
> struct mmc_command *cmd;
>
> @@ -1195,8 +1195,7 @@ static int meson_mmc_probe(struct platform_device *pdev)
> if (mmc->caps & MMC_CAP_SDIO_IRQ)
> mmc->caps2 |= MMC_CAP2_SDIO_IRQ_NOTHREAD;
>
> - host->data = (struct meson_mmc_data *)
> - of_device_get_match_data(&pdev->dev);
> + host->data = of_device_get_match_data(&pdev->dev);
> if (!host->data)
> return -EINVAL;
>
> --
> 2.39.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-17 10:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-15 20:01 [PATCH] mmc: meson-gx: constify member data of struct meson_host Heiner Kallweit
2023-02-17 10:56 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).