* [PATCH v3 0/1] mmc: core: Add HS400 tuning in HS400es initialization
@ 2023-12-25 9:38 Mengqi Zhang
2023-12-25 9:38 ` [PATCH v3 1/1] " Mengqi Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Mengqi Zhang @ 2023-12-25 9:38 UTC (permalink / raw)
To: ulf.hansson, chaotian.jing, matthias.bgg, mengqi.zhang,
wenbin.mei
Cc: yangyingliang, adrian.hunter, avri.altman, vincent.whitchurch,
linux-mmc, linux-arm-kernel, linux-mediatek, linux-kernel
change v3
1. remove mmc_retune_disable() and mmc_retune_enable() from
hs400es initialization.
change v2
1. remove hs400 tuning from mmc_retune.
2. remove mmc_retune_enable() from hs400es initialization.
Mengqi Zhang (1):
mmc: core: Add HS400 tuning in HS400es initialization
drivers/mmc/core/mmc.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3 1/1] mmc: core: Add HS400 tuning in HS400es initialization
2023-12-25 9:38 [PATCH v3 0/1] mmc: core: Add HS400 tuning in HS400es initialization Mengqi Zhang
@ 2023-12-25 9:38 ` Mengqi Zhang
2024-01-02 16:57 ` Ulf Hansson
0 siblings, 1 reply; 3+ messages in thread
From: Mengqi Zhang @ 2023-12-25 9:38 UTC (permalink / raw)
To: ulf.hansson, chaotian.jing, matthias.bgg, mengqi.zhang,
wenbin.mei
Cc: yangyingliang, adrian.hunter, avri.altman, vincent.whitchurch,
linux-mmc, linux-arm-kernel, linux-mediatek, linux-kernel
During the initialization to HS400es stage, add hs400 tuning flow as an
optional process. For Mediatek IP, HS00es mode requires a specific
tuning to ensure the correct HS400 timing setting.
Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com>
---
v1 https://patchwork.kernel.org/project/linux-mediatek/patch/20231201030547.11553-1-mengqi.zhang@mediatek.com/
v2 https://patchwork.kernel.org/project/linux-mediatek/patch/20231222062236.26370-1-mengqi.zhang@mediatek.com/
---
drivers/mmc/core/mmc.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 705942edacc6..d5173a9bb4b0 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -1822,8 +1822,13 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
if (err)
goto free_card;
-
- } else if (!mmc_card_hs400es(card)) {
+ } else if (mmc_card_hs400es(card)) {
+ if (host->ops->execute_hs400_tuning) {
+ err = host->ops->execute_hs400_tuning(host, card);
+ if (err)
+ goto free_card;
+ }
+ } else {
/* Select the desired bus width optionally */
err = mmc_select_bus_width(card);
if (err > 0 && mmc_card_hs(card)) {
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v3 1/1] mmc: core: Add HS400 tuning in HS400es initialization
2023-12-25 9:38 ` [PATCH v3 1/1] " Mengqi Zhang
@ 2024-01-02 16:57 ` Ulf Hansson
0 siblings, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2024-01-02 16:57 UTC (permalink / raw)
To: Mengqi Zhang
Cc: chaotian.jing, matthias.bgg, wenbin.mei, yangyingliang,
adrian.hunter, avri.altman, vincent.whitchurch, linux-mmc,
linux-arm-kernel, linux-mediatek, linux-kernel
On Mon, 25 Dec 2023 at 10:39, Mengqi Zhang <mengqi.zhang@mediatek.com> wrote:
>
> During the initialization to HS400es stage, add hs400 tuning flow as an
> optional process. For Mediatek IP, HS00es mode requires a specific
> tuning to ensure the correct HS400 timing setting.
>
> Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> v1 https://patchwork.kernel.org/project/linux-mediatek/patch/20231201030547.11553-1-mengqi.zhang@mediatek.com/
> v2 https://patchwork.kernel.org/project/linux-mediatek/patch/20231222062236.26370-1-mengqi.zhang@mediatek.com/
> ---
> drivers/mmc/core/mmc.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 705942edacc6..d5173a9bb4b0 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1822,8 +1822,13 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
>
> if (err)
> goto free_card;
> -
> - } else if (!mmc_card_hs400es(card)) {
> + } else if (mmc_card_hs400es(card)) {
> + if (host->ops->execute_hs400_tuning) {
> + err = host->ops->execute_hs400_tuning(host, card);
> + if (err)
> + goto free_card;
> + }
> + } else {
> /* Select the desired bus width optionally */
> err = mmc_select_bus_width(card);
> if (err > 0 && mmc_card_hs(card)) {
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-02 16:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-25 9:38 [PATCH v3 0/1] mmc: core: Add HS400 tuning in HS400es initialization Mengqi Zhang
2023-12-25 9:38 ` [PATCH v3 1/1] " Mengqi Zhang
2024-01-02 16:57 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).