linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Eric Curtin <ecurtin@redhat.com>, Neal Gompa <neal@gompa.dev>
Cc: Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	linux-pm@vger.kernel.org,  linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,  Hector Martin <marcan@marcan.st>,
	Sven Peter <sven@svenpeter.dev>,
	 Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	asahi@lists.linux.dev
Subject: Re: [PATCH v2 04/17] pmdomain: apple: Move Kconfig option to the pmdomain subsystem
Date: Fri, 15 Sep 2023 13:46:44 +0200	[thread overview]
Message-ID: <CAPDyKFpYRwDGbYajVK8MMDjf=0ab-ZpMH2QXKUsVAFy0kh-iYA@mail.gmail.com> (raw)
In-Reply-To: <CAOgh=FzNordx=_YMiQs2Uj6JQ7Ctqqi=XZbbRAY9cS-F8v68RA@mail.gmail.com>

+ Neal

On Fri, 15 Sept 2023 at 11:45, Eric Curtin <ecurtin@redhat.com> wrote:
>
> On Fri, 15 Sept 2023 at 10:29, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> >
> > The Kconfig option belongs closer to the corresponding implementation,
> > hence let's move it from the soc subsystem to the pmdomain subsystem.
> >
> > Cc: Hector Martin <marcan@marcan.st>
> > Cc: Sven Peter <sven@svenpeter.dev>
> > Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io>
> > Cc: <asahi@lists.linux.dev>
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> This patch in the patchset looks the same as yesterday, so...
>
> Reviewed-by: Eric Curtin <ecurtin@redhat.com>

Yes my bad, again. I forgot to add yours and Neal's tags, sorry.

Thanks!

Kind regards
Uffe

>
> Is mise le meas/Regards,
>
> Eric Curtin
>
> > ---
> >  drivers/pmdomain/Kconfig       |  1 +
> >  drivers/pmdomain/apple/Kconfig | 18 ++++++++++++++++++
> >  drivers/soc/apple/Kconfig      | 13 -------------
> >  3 files changed, 19 insertions(+), 13 deletions(-)
> >  create mode 100644 drivers/pmdomain/apple/Kconfig
> >
> > diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig
> > index 03c8991ad0fd..482d9e970e14 100644
> > --- a/drivers/pmdomain/Kconfig
> > +++ b/drivers/pmdomain/Kconfig
> > @@ -3,5 +3,6 @@ menu "PM Domains"
> >
> >  source "drivers/pmdomain/actions/Kconfig"
> >  source "drivers/pmdomain/amlogic/Kconfig"
> > +source "drivers/pmdomain/apple/Kconfig"
> >
> >  endmenu
> > diff --git a/drivers/pmdomain/apple/Kconfig b/drivers/pmdomain/apple/Kconfig
> > new file mode 100644
> > index 000000000000..12237cbcfaa9
> > --- /dev/null
> > +++ b/drivers/pmdomain/apple/Kconfig
> > @@ -0,0 +1,18 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +
> > +if ARCH_APPLE || COMPILE_TEST
> > +
> > +config APPLE_PMGR_PWRSTATE
> > +       bool "Apple SoC PMGR power state control"
> > +       depends on PM
> > +       select REGMAP
> > +       select MFD_SYSCON
> > +       select PM_GENERIC_DOMAINS
> > +       select RESET_CONTROLLER
> > +       default ARCH_APPLE
> > +       help
> > +         The PMGR block in Apple SoCs provides high-level power state
> > +         controls for SoC devices. This driver manages them through the
> > +         generic power domain framework, and also provides reset support.
> > +
> > +endif
> > diff --git a/drivers/soc/apple/Kconfig b/drivers/soc/apple/Kconfig
> > index a1596fefacff..eff486a77337 100644
> > --- a/drivers/soc/apple/Kconfig
> > +++ b/drivers/soc/apple/Kconfig
> > @@ -4,19 +4,6 @@ if ARCH_APPLE || COMPILE_TEST
> >
> >  menu "Apple SoC drivers"
> >
> > -config APPLE_PMGR_PWRSTATE
> > -       bool "Apple SoC PMGR power state control"
> > -       depends on PM
> > -       select REGMAP
> > -       select MFD_SYSCON
> > -       select PM_GENERIC_DOMAINS
> > -       select RESET_CONTROLLER
> > -       default ARCH_APPLE
> > -       help
> > -         The PMGR block in Apple SoCs provides high-level power state
> > -         controls for SoC devices. This driver manages them through the
> > -         generic power domain framework, and also provides reset support.
> > -
> >  config APPLE_RTKIT
> >         tristate "Apple RTKit co-processor IPC protocol"
> >         depends on MAILBOX
> > --
> > 2.34.1
> >
> >
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-09-15 11:47 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-15  9:19 [PATCH v2 00/17] pmdomain: Move Kconfig options/files to the pmdomain subsystem Ulf Hansson
2023-09-15  9:19 ` [PATCH v2 01/17] pmdomain: Prepare to move Kconfig files into " Ulf Hansson
2023-09-15 10:07   ` Geert Uytterhoeven
2023-09-15  9:19 ` [PATCH v2 02/17] pmdomain: actions: Move Kconfig file to " Ulf Hansson
2023-09-15  9:19 ` [PATCH v2 03/17] pmdomain: amlogic: Move Kconfig options " Ulf Hansson
2023-09-15  9:19 ` [PATCH v2 04/17] pmdomain: apple: Move Kconfig option " Ulf Hansson
2023-09-15  9:45   ` Eric Curtin
2023-09-15 11:46     ` Ulf Hansson [this message]
2023-09-15 10:21   ` Neal Gompa
2023-09-15  9:19 ` [PATCH v2 05/17] pmdomain: bcm: Move Kconfig options " Ulf Hansson
2023-09-15 13:15   ` Philippe Mathieu-Daudé
2023-09-15 16:30   ` Florian Fainelli
2023-09-15  9:19 ` [PATCH v2 06/17] pmdomain: imx: " Ulf Hansson
2023-09-17 23:07   ` Peng Fan
2023-09-15  9:19 ` [PATCH v2 07/17] pmdomain: mediatek: " Ulf Hansson
2023-09-15  9:19 ` [PATCH v2 08/17] pmdomain: qcom: " Ulf Hansson
2023-09-15  9:19 ` [PATCH v2 09/17] pmdomain: renesas: " Ulf Hansson
2023-09-15  9:19 ` [PATCH v2 10/17] pmdomain: rockchip: Move Kconfig option " Ulf Hansson
2023-09-15  9:19 ` [PATCH v2 11/17] pmdomain: samsung: " Ulf Hansson
2023-09-15  9:19 ` [PATCH v2 12/17] pmdomain: st: Add a Kconfig option for the ux500 power domain Ulf Hansson
2023-09-15  9:19 ` [PATCH v2 13/17] pmdomain: starfive: Move Kconfig file to the pmdomain subsystem Ulf Hansson
2023-09-15  9:29   ` Conor Dooley
2023-09-15 11:42     ` Ulf Hansson
2023-09-15  9:20 ` [PATCH v2 14/17] pmdomain: sunxi: Move Kconfig option " Ulf Hansson
2023-09-15  9:20 ` [PATCH v2 15/17] pmdomain: tegra: " Ulf Hansson
2023-09-15  9:20 ` [PATCH v2 16/17] pmdomain: ti: Move and add Kconfig options " Ulf Hansson
2023-09-19  9:09   ` Dhruva Gole
2023-09-15  9:20 ` [PATCH v2 17/17] pmdomain: xilinx: Move Kconfig option " Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPDyKFpYRwDGbYajVK8MMDjf=0ab-ZpMH2QXKUsVAFy0kh-iYA@mail.gmail.com' \
    --to=ulf.hansson@linaro.org \
    --cc=alyssa@rosenzweig.io \
    --cc=arnd@arndb.de \
    --cc=asahi@lists.linux.dev \
    --cc=ecurtin@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=neal@gompa.dev \
    --cc=olof@lixom.net \
    --cc=sven@svenpeter.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).