From: Ulf Hansson <ulf.hansson@linaro.org>
To: Charan Pedumuru <charan.pedumuru@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Taichi Sugaya <sugaya.taichi@socionext.com>,
Takao Orito <orito.takao@socionext.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: mmc: socionext,milbeaut-m10v-sdhci-3.0: convert to DT schema
Date: Tue, 11 Nov 2025 18:36:07 +0100 [thread overview]
Message-ID: <CAPDyKFpdeBgZKnK3KgNTQPWNw5R2rnSgB=uRjDUs8sBvbEDwJQ@mail.gmail.com> (raw)
In-Reply-To: <20251027-milbeaut-v2-1-9e1954ff7708@gmail.com>
On Mon, 27 Oct 2025 at 17:49, Charan Pedumuru <charan.pedumuru@gmail.com> wrote:
>
> Convert SOCIONEXT Milbeaut SDHCI controller binding to YAML format.
> Add a new property "voltage-ranges" to resolve dt_check errors.
>
> Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Changes in v2:
> - Change the description for the property "voltage-ranges".
> - Link to v1: https://lore.kernel.org/r/20251023-milbeaut-v1-1-3e4ff67110ad@gmail.com
> ---
> .../devicetree/bindings/mmc/sdhci-milbeaut.txt | 30 --------
> .../mmc/socionext,milbeaut-m10v-sdhci-3.0.yaml | 79 ++++++++++++++++++++++
> 2 files changed, 79 insertions(+), 30 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt b/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
> deleted file mode 100644
> index 627ee89c125b..000000000000
> --- a/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -* SOCIONEXT Milbeaut SDHCI controller
> -
> -This file documents differences between the core properties in mmc.txt
> -and the properties used by the sdhci_milbeaut driver.
> -
> -Required properties:
> -- compatible: "socionext,milbeaut-m10v-sdhci-3.0"
> -- clocks: Must contain an entry for each entry in clock-names. It is a
> - list of phandles and clock-specifier pairs.
> - See ../clocks/clock-bindings.txt for details.
> -- clock-names: Should contain the following two entries:
> - "iface" - clock used for sdhci interface
> - "core" - core clock for sdhci controller
> -
> -Optional properties:
> -- fujitsu,cmd-dat-delay-select: boolean property indicating that this host
> - requires the CMD_DAT_DELAY control to be enabled.
> -
> -Example:
> - sdhci3: mmc@1b010000 {
> - compatible = "socionext,milbeaut-m10v-sdhci-3.0";
> - reg = <0x1b010000 0x10000>;
> - interrupts = <0 265 0x4>;
> - voltage-ranges = <3300 3300>;
> - bus-width = <4>;
> - clocks = <&clk 7>, <&ahb_clk>;
> - clock-names = "core", "iface";
> - cap-sdio-irq;
> - fujitsu,cmd-dat-delay-select;
> - };
> diff --git a/Documentation/devicetree/bindings/mmc/socionext,milbeaut-m10v-sdhci-3.0.yaml b/Documentation/devicetree/bindings/mmc/socionext,milbeaut-m10v-sdhci-3.0.yaml
> new file mode 100644
> index 000000000000..2ba53626a959
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/socionext,milbeaut-m10v-sdhci-3.0.yaml
> @@ -0,0 +1,79 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/socionext,milbeaut-m10v-sdhci-3.0.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: SOCIONEXT Milbeaut SDHCI controller
> +
> +maintainers:
> + - Taichi Sugaya <sugaya.taichi@socionext.com>
> + - Takao Orito <orito.takao@socionext.com>
> +
> +description:
> + The SOCIONEXT Milbeaut SDHCI controller is a specialized SD Host
> + Controller found in some of Socionext's Milbeaut image processing SoCs.
> + It features a dedicated "bridge controller." This bridge controller
> + implements special functions like reset control, clock management for
> + various SDR modes (SDR12, SDR25, SDR50) and physical pin property settings.
> +
> +allOf:
> + - $ref: sdhci-common.yaml#
> +
> +properties:
> + compatible:
> + const: socionext,milbeaut-m10v-sdhci-3.0
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 2
> +
> + clock-names:
> + items:
> + - const: core
> + - const: iface
> +
> + fujitsu,cmd-dat-delay-select:
> + description:
> + Its presence indicates that the controller requires a specific command
> + and data line delay selection mechanism for proper operation, particularly
> + when dealing with high-speed SD/eMMC modes.
> + type: boolean
> +
> + voltage-ranges:
> + $ref: /schemas/types.yaml#/definitions/uint32-matrix
> + items:
> + items:
> + - description: minimum slot voltage (mV).
> + - description: maximum slot voltage (mV).
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + mmc@1b010000 {
> + compatible = "socionext,milbeaut-m10v-sdhci-3.0";
> + reg = <0x1b010000 0x10000>;
> + interrupts = <GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH>;
> + voltage-ranges = <3300 3300>;
> + bus-width = <4>;
> + clocks = <&clk 7>, <&ahb_clk>;
> + clock-names = "core", "iface";
> + cap-sdio-irq;
> + fujitsu,cmd-dat-delay-select;
> + };
> +...
>
> ---
> base-commit: 7bac2c97af4078d7a627500c9bcdd5b033f97718
> change-id: 20250524-milbeaut-5c0267202e2c
>
> Best regards,
> --
> Charan Pedumuru <charan.pedumuru@gmail.com>
>
prev parent reply other threads:[~2025-11-11 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 16:46 [PATCH v2] dt-bindings: mmc: socionext,milbeaut-m10v-sdhci-3.0: convert to DT schema Charan Pedumuru
2025-10-30 16:49 ` Rob Herring (Arm)
2025-11-11 17:36 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFpdeBgZKnK3KgNTQPWNw5R2rnSgB=uRjDUs8sBvbEDwJQ@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=charan.pedumuru@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=orito.takao@socionext.com \
--cc=robh@kernel.org \
--cc=sugaya.taichi@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).