From: ulf.hansson@linaro.org (Ulf Hansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/4] mmc: sdhci-msm: Corrections to implementation of power irq
Date: Wed, 4 Oct 2017 10:59:24 +0200 [thread overview]
Message-ID: <CAPDyKFqZkOfSq416tuujOJx-aSw9Aio2DHQZGJmMOf69+nm_fg@mail.gmail.com> (raw)
In-Reply-To: <1506490483-46871-1-git-send-email-vviswana@codeaurora.org>
On 27 September 2017 at 07:34, Vijay Viswanath <vviswana@codeaurora.org> wrote:
> Register writes which change voltage of IO lines or turn the IO bus on/off
> require sdhc controller to be ready before progressing further. Once a
> register write which affects IO lines is done, the driver should wait for
> power irq from controller. Once the irq comes, the driver should acknowledge
> the irq by writing to power control register. If the acknowledgement is not
> given to controller, the controller may not complete the corresponding
> register write action and this can mess up the controller if drivers proceeds
> without power irq completing.
>
> Changes since v1:
> Patch enabling MMC_IO_ACCESSORS in Kconfig moved up the patch list.
> Also corrected a mistake in the patch.
> Removed all ifdef CONFIG_MMC_IO_ACCESSORS since the patches using it
> will come after MMC_IO_ACCESSORS are enabled.
> Merged the patches 3 & 4 of earlier series into 1 patch (patch 4 in
> current series).
> Corrected a mistake in a comment text in patch 3 of previous series.
>
> Changes since RFC:
> wait_for_completion_timeout replaced with wait_event_timeout when
> waiting for power irq.
> Removed the spinlock within power irq handler and API which waits
> for power irq.
> Added comments to sdhci msm register write functions, warning that they
> can sleep.
> Sdhci msm register write functions will do a memory barrier before
> writing to the register if the particular register can trigger
> power irq.
> Instead of enabling SDHCI IO ACCESSORS config in arm64/defconfig, it
> will be selected in mmc/host/Kconfig if the platform is MMC_SDHCI_MSM.
>
> Sahitya Tummala (1):
> mmc: sdhci-msm: Fix HW issue with power IRQ handling during reset
>
> Subhash Jadavani (1):
> mmc: sdhci-msm: fix issue with power irq
>
> Vijay Viswanath (2):
> mmc: Kconfig: Enable CONFIG_MMC_SDHCI_IO_ACCESSORS
> mmc: sdhci-msm: Add sdhci msm register write APIs which wait for pwr
> irq
>
> drivers/mmc/host/Kconfig | 1 +
> drivers/mmc/host/sdhci-msm.c | 235 ++++++++++++++++++++++++++++++++++++++++++-
> 2 files changed, 231 insertions(+), 5 deletions(-)
>
Thanks, applied for next!
Kind regards
Uffe
prev parent reply other threads:[~2017-10-04 8:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 5:34 [PATCH v2 0/4] mmc: sdhci-msm: Corrections to implementation of power irq Vijay Viswanath
2017-09-27 5:34 ` [PATCH v2 1/4] mmc: sdhci-msm: fix issue with " Vijay Viswanath
2017-10-03 11:44 ` Adrian Hunter
2017-09-27 5:34 ` [PATCH v2 2/4] mmc: sdhci-msm: Fix HW issue with power IRQ handling during reset Vijay Viswanath
2017-10-03 11:44 ` Adrian Hunter
2017-09-27 5:34 ` [PATCH v2 3/4] mmc: Kconfig: Enable CONFIG_MMC_SDHCI_IO_ACCESSORS Vijay Viswanath
2017-10-03 11:44 ` Adrian Hunter
2017-09-27 5:34 ` [PATCH v2 4/4] mmc: sdhci-msm: Add sdhci msm register write APIs which wait for pwr irq Vijay Viswanath
2017-10-03 11:44 ` Adrian Hunter
2017-10-14 7:31 ` Bjorn Andersson
2017-10-20 10:54 ` Vijay Viswanath
2017-10-20 18:05 ` Bjorn Andersson
2018-05-29 12:19 ` Georgi Djakov
2018-05-30 7:11 ` Vijay Viswanath
2018-05-30 15:57 ` Georgi Djakov
2017-10-04 8:59 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFqZkOfSq416tuujOJx-aSw9Aio2DHQZGJmMOf69+nm_fg@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).