From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43BA0C433FE for ; Fri, 1 Apr 2022 09:24:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Go+ML344KqWVW4DONzS1TfcvjWj/qYr+EkTlA3w9Soo=; b=kYL1G+hQOeY0wz 0iin8X8Kz2kNpnRliphGRztd/pSVHHD+YJsz8Awz4xOW1AnLm5B5B/O+cL85/pbSvl7i5gxDK8ttK XHtA64Sn0dNycCXLCTJCD9CCbB6JtIwXgGHssC6k2qvVeHQdiFwoeAmadTJqf2o31YfpT09UwM5Hf HHUi7NR/i7v7aaR7ERSBYg8gwucy+UmUTr25xzxXhUS8BhjmdaZsRPlQrUnk5kwilp7V1u5YPHbP/ X5ddnWH9T/5wpz8zMXxNJXqwviufn+KsQZn7N0FgZUManXexrpOa/+tyBgT5XgnHJ2EdrfdRbN2j3 CeLSad53/qVrlzZlgS7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naDUe-0050vf-SP; Fri, 01 Apr 2022 09:22:56 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1naDUb-0050uK-KK for linux-arm-kernel@lists.infradead.org; Fri, 01 Apr 2022 09:22:55 +0000 Received: by mail-lf1-x136.google.com with SMTP id p15so3744975lfk.8 for ; Fri, 01 Apr 2022 02:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kqDhQ6uz5tP7E/u76ETFJKOp+CrWLSoKcxKKyX0RqW4=; b=VvgYSKL81nZLAs4hoT9cuIsMhmP8h+p1g8wsI7YmSZnBeQWKpXBsjn0tFPK6mWo+U2 38yZO++R3yRrPbTkM8dEjkga/lPr9tEW/5pUICD57kN2HDO3BhHC5axSG09Ik5EDogUC odEYy8MIWeo6kBwh2h5eip/pRRkKQhCifIcNTOZB3KSe2PCRUY+eZnDarzCNA6n2gYST SOkZAmrZ5l3VSV9pwY4R233uVdLQNubqwwsEHybGBF3sXnxmo5DLZK7DHk/Hj+e+73GQ p8Fz+9RGcb5+Sjw4wE9P5FkohTTgEP7sHGYookmt7H+nWkL+ROTUng18DaKcREcp96yR 6G4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kqDhQ6uz5tP7E/u76ETFJKOp+CrWLSoKcxKKyX0RqW4=; b=Zp16P5OY0XCRwg3mFrC2Df3P96CrKGf1PxnRligF8E7DOw/39Kd32ESYv9BP2yB4rU aImz7Q3V92Sj2hcmKtf9G77Ut8dE6iJpuYIlHySlSzt4QHS4kLfaL6znd4UH8zn7EldT jJEyI/GIDOoy+NcvR0lNzVt4FmrGqNOeZyg0sccDPJ4+6jqfoLqNwN+RWMZU3hUpSuyk U0kLb9K57xgarPaSQ4NAhlBEbP7Msepf1HgpH0X70FEHIE3liwvDmL4XbpfG1xAHt5lC poeeJkMaP3AdE/XF0tdCfwRu1fSz1F6y186TcdyKqCBpM7XSXuxxTVb6RWsOKHoU9Pdj w+3A== X-Gm-Message-State: AOAM532JRwBk12B7eMl4pdIl3dgL4hpthzJI8x/rKn2GWXxI7+AiI55d dqY6nBPDSuBaOHoThcPHaqH8VBWbRrNLCbXefFQTGQ== X-Google-Smtp-Source: ABdhPJwJrDnSzRPA1QW45MFiPs0C/KCemCmZtTlay3kzIbYxlsxllBZdkUFbUM0hK5gl/cOTN43YhXEhrJYg4D4w6LI= X-Received: by 2002:a05:6512:3b0e:b0:44a:547d:c8b8 with SMTP id f14-20020a0565123b0e00b0044a547dc8b8mr13429451lfv.373.1648804969656; Fri, 01 Apr 2022 02:22:49 -0700 (PDT) MIME-Version: 1.0 References: <20220329032913.8750-1-axe.yang@mediatek.com> <20220329032913.8750-2-axe.yang@mediatek.com> In-Reply-To: <20220329032913.8750-2-axe.yang@mediatek.com> From: Ulf Hansson Date: Fri, 1 Apr 2022 11:22:13 +0200 Message-ID: Subject: Re: [PATCH v9 1/3] dt-bindings: mmc: mtk-sd: extend interrupts and pinctrls properties To: Axe Yang Cc: Rob Herring , Chaotian Jing , Matthias Brugger , Adrian Hunter , Yoshihiro Shimoda , Satya Tangirala , Andy Shevchenko , Wolfram Sang , Lucas Stach , Eric Biggers , Andrew Jeffery , Stephen Boyd , Kiwoong Kim , Yue Hu , Tian Tao , angelogioacchino.delregno@collabora.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220401_022253_780221_77D86614 X-CRM114-Status: GOOD ( 20.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 29 Mar 2022 at 05:29, Axe Yang wrote: > > Extend interrupts and pinctrls for SDIO wakeup interrupt feature. > This feature allow SDIO devices alarm asynchronous interrupt to host > even when host stop providing clock to SDIO card. An extra wakeup > interrupt and pinctrl states for SDIO DAT1 pin state switching are > required in this scenario. > > Signed-off-by: Axe Yang > --- > .../devicetree/bindings/mmc/mtk-sd.yaml | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > index 297ada03e3de..3872a6ce2867 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > @@ -69,12 +69,22 @@ properties: > - const: ahb_cg > > interrupts: > - maxItems: 1 > + description: > + Should at least contain MSDC GIC interrupt. To support SDIO in-band wakeup, an extended > + interrupt is required and be configured as wakeup source irq. If I understand correctly, the extended interrupt (a GPIO irq) may not necessarily share the same interrupt parent as the primary device interrupt. Perhaps it's then better to extend this with "interrupts-extended" instead. See Documentation/devicetree/bindings/interrupt-controller/interrupts.txt. > + minItems: 1 > + maxItems: 2 > > pinctrl-names: > + description: > + Should at least contain default and state_uhs. To support SDIO in-band wakeup, dat1 pin > + will be switched between GPIO mode and SDIO DAT1 mode, state_eint and state_dat1 are > + mandatory in this scenarios. > + minItems: 2 > items: > - const: default > - const: state_uhs > + - const: state_eint > > pinctrl-0: > description: > @@ -86,6 +96,11 @@ properties: > should contain uhs mode pin ctrl. > maxItems: 1 > > + pinctrl-2: > + description: > + should switch dat1 pin to GPIO mode. > + maxItems: 1 > + > assigned-clocks: > description: > PLL of the source clock. > -- > 2.25.1 > Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel