From: ulf.hansson@linaro.org (Ulf Hansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] mmc: omap_hsmmc: Enable omap_hsmmc for Keystone 2
Date: Thu, 22 Oct 2015 15:32:38 +0200 [thread overview]
Message-ID: <CAPDyKFr+Nj510TC=J1oswSAxX++fAu=LLWjytcMx1vBeHA7VTA@mail.gmail.com> (raw)
In-Reply-To: <20151022105841.GR32532@n2100.arm.linux.org.uk>
On 22 October 2015 at 12:58, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Thu, Oct 22, 2015 at 11:28:55AM +0200, Ulf Hansson wrote:
>> On 20 October 2015 at 23:50, Franklin S Cooper Jr <fcooper@ti.com> wrote:
>> >
>> > From: Lokesh Vutla <lokeshvutla@ti.com>
>> >
>> > Enable omap_hsmmc for Keystone 2 architecture which reuses the HSMMC
>> > IP found on OMAP platforms.
>> >
>> > Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
>> > ---
>> > drivers/mmc/host/Kconfig | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>> > index 8a1e349..2ccec71 100644
>> > --- a/drivers/mmc/host/Kconfig
>> > +++ b/drivers/mmc/host/Kconfig
>> > @@ -366,7 +366,7 @@ config MMC_OMAP
>> > config MMC_OMAP_HS
>> > tristate "TI OMAP High Speed Multimedia Card Interface support"
>> > depends on HAS_DMA
>> > - depends on ARCH_OMAP2PLUS || COMPILE_TEST
>> > + depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || COMPILE_TEST
>>
>> How about:
>> "depends on ARM || COMPILE_TEST"
>
> I'd much prefer the former actually - it's already hard enough to use
> the config tools with the kernel due to the number of silly options
> being presented, there's no need to make it worse.
>
> In fact, I'd like to see more of the former (provided done sensibly)
> to reduce the number of config options seen for configurations to cut
> down on the shere noise of useless options. For example, if I've
> decided I don't want to support TI OMAP platforms, then I shouldn't
> be offered the TI OMAP MMC driver.
Okay, fair enough and I don't have any strong opinions around this.
I queued up the patch for next, thanks!
Kind regards
Uffe
next prev parent reply other threads:[~2015-10-22 13:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 21:50 [PATCH 1/5] ARM: Keystone: Enable PINCTRL for Keystone ARCH Franklin S Cooper Jr
2015-10-20 21:50 ` [PATCH 2/5] mmc: omap_hsmmc: Enable omap_hsmmc for Keystone 2 Franklin S Cooper Jr
2015-10-21 1:25 ` santosh shilimkar
2015-10-22 9:28 ` Ulf Hansson
2015-10-22 10:58 ` Russell King - ARM Linux
2015-10-22 13:32 ` Ulf Hansson [this message]
2015-10-20 21:50 ` [PATCH 3/5] ARM: keystone: defconfig: Enable PINCTRL SINGLE " Franklin S Cooper Jr
2015-10-20 21:50 ` [PATCH 4/5] ARM: keystone: defconfig: Enable MMC support Franklin S Cooper Jr
2015-10-21 1:27 ` santosh shilimkar
2015-10-20 21:50 ` [PATCH 5/5] ARM: keystone: defconfig: Enable CAN support Franklin S Cooper Jr
2015-10-21 1:28 ` santosh shilimkar
2015-10-21 1:26 ` [PATCH 1/5] ARM: Keystone: Enable PINCTRL for Keystone ARCH santosh shilimkar
2015-10-22 14:18 ` Murali Karicheri
2015-10-22 14:20 ` Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFr+Nj510TC=J1oswSAxX++fAu=LLWjytcMx1vBeHA7VTA@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).