[PATCH 1/5] ARM: Keystone: Enable PINCTRL for Keystone ARCH

[PATCH 1/5] ARM: Keystone: Enable PINCTRL for Keystone ARCH

[Franklin S Cooper Jr]

From: Franklin Cooper <fcooper@ti.com>

Unlike other Keystone 2 devices, newer Keystone 2 SOCs may utilize
pinmuxing which requires PINCTRL to be enabled. Therefore, enable
PINCTRL for all Keystone 2 devices.

Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
 arch/arm/mach-keystone/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-keystone/Kconfig b/arch/arm/mach-keystone/Kconfig
index ea955f6db..7a432ee 100644
--- a/arch/arm/mach-keystone/Kconfig
+++ b/arch/arm/mach-keystone/Kconfig
@@ -11,6 +11,7 @@ config ARCH_KEYSTONE
 	select ZONE_DMA if ARM_LPAE
 	select MIGHT_HAVE_PCI
 	select PCI_DOMAINS if PCI
+	select PINCTRL
 	help
 	  Support for boards based on the Texas Instruments Keystone family of
 	  SoCs.
-- 
2.6.1

[PATCH 2/5] mmc: omap_hsmmc: Enable omap_hsmmc for Keystone 2

[Franklin S Cooper Jr]

From: Lokesh Vutla <lokeshvutla@ti.com>

Enable omap_hsmmc for Keystone 2 architecture which reuses the HSMMC
IP found on OMAP platforms.

Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
 drivers/mmc/host/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 8a1e349..2ccec71 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -366,7 +366,7 @@ config MMC_OMAP
 config MMC_OMAP_HS
 	tristate "TI OMAP High Speed Multimedia Card Interface support"
 	depends on HAS_DMA
-	depends on ARCH_OMAP2PLUS || COMPILE_TEST
+	depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || COMPILE_TEST
 	help
 	  This selects the TI OMAP High Speed Multimedia card Interface.
 	  If you have an omap2plus board with a Multimedia Card slot,
-- 
2.6.1

[PATCH 2/5] mmc: omap_hsmmc: Enable omap_hsmmc for Keystone 2

[santosh shilimkar]

On 10/20/2015 2:50 PM, Franklin S Cooper Jr wrote:
> From: Lokesh Vutla <lokeshvutla@ti.com>
>
> Enable omap_hsmmc for Keystone 2 architecture which reuses the HSMMC
> IP found on OMAP platforms.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
>   drivers/mmc/host/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 8a1e349..2ccec71 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -366,7 +366,7 @@ config MMC_OMAP
>   config MMC_OMAP_HS
>   	tristate "TI OMAP High Speed Multimedia Card Interface support"
>   	depends on HAS_DMA
> -	depends on ARCH_OMAP2PLUS || COMPILE_TEST
> +	depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || COMPILE_TEST
>   	help
>   	  This selects the TI OMAP High Speed Multimedia card Interface.
>   	  If you have an omap2plus board with a Multimedia Card slot,
>
Please send this to MMC tree.

Regards,
Santosh

[PATCH 2/5] mmc: omap_hsmmc: Enable omap_hsmmc for Keystone 2

[Ulf Hansson]

On 20 October 2015 at 23:50, Franklin S Cooper Jr <fcooper@ti.com> wrote:
>
> From: Lokesh Vutla <lokeshvutla@ti.com>
>
> Enable omap_hsmmc for Keystone 2 architecture which reuses the HSMMC
> IP found on OMAP platforms.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
>  drivers/mmc/host/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 8a1e349..2ccec71 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -366,7 +366,7 @@ config MMC_OMAP
>  config MMC_OMAP_HS
>         tristate "TI OMAP High Speed Multimedia Card Interface support"
>         depends on HAS_DMA
> -       depends on ARCH_OMAP2PLUS || COMPILE_TEST
> +       depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || COMPILE_TEST

How about:
"depends on ARM || COMPILE_TEST"

>
>         help
>           This selects the TI OMAP High Speed Multimedia card Interface.
>           If you have an omap2plus board with a Multimedia Card slot,
> --
> 2.6.1
>

Kind regards
Uffe

[PATCH 2/5] mmc: omap_hsmmc: Enable omap_hsmmc for Keystone 2

[Russell King - ARM Linux]

On Thu, Oct 22, 2015 at 11:28:55AM +0200, Ulf Hansson wrote:
> On 20 October 2015 at 23:50, Franklin S Cooper Jr <fcooper@ti.com> wrote:
> >
> > From: Lokesh Vutla <lokeshvutla@ti.com>
> >
> > Enable omap_hsmmc for Keystone 2 architecture which reuses the HSMMC
> > IP found on OMAP platforms.
> >
> > Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> > ---
> >  drivers/mmc/host/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index 8a1e349..2ccec71 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -366,7 +366,7 @@ config MMC_OMAP
> >  config MMC_OMAP_HS
> >         tristate "TI OMAP High Speed Multimedia Card Interface support"
> >         depends on HAS_DMA
> > -       depends on ARCH_OMAP2PLUS || COMPILE_TEST
> > +       depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || COMPILE_TEST
> 
> How about:
> "depends on ARM || COMPILE_TEST"

I'd much prefer the former actually - it's already hard enough to use
the config tools with the kernel due to the number of silly options
being presented, there's no need to make it worse.

In fact, I'd like to see more of the former (provided done sensibly)
to reduce the number of config options seen for configurations to cut
down on the shere noise of useless options.  For example, if I've
decided I don't want to support TI OMAP platforms, then I shouldn't
be offered the TI OMAP MMC driver.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

[PATCH 2/5] mmc: omap_hsmmc: Enable omap_hsmmc for Keystone 2

[Ulf Hansson]

On 22 October 2015 at 12:58, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Thu, Oct 22, 2015 at 11:28:55AM +0200, Ulf Hansson wrote:
>> On 20 October 2015 at 23:50, Franklin S Cooper Jr <fcooper@ti.com> wrote:
>> >
>> > From: Lokesh Vutla <lokeshvutla@ti.com>
>> >
>> > Enable omap_hsmmc for Keystone 2 architecture which reuses the HSMMC
>> > IP found on OMAP platforms.
>> >
>> > Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
>> > ---
>> >  drivers/mmc/host/Kconfig | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>> > index 8a1e349..2ccec71 100644
>> > --- a/drivers/mmc/host/Kconfig
>> > +++ b/drivers/mmc/host/Kconfig
>> > @@ -366,7 +366,7 @@ config MMC_OMAP
>> >  config MMC_OMAP_HS
>> >         tristate "TI OMAP High Speed Multimedia Card Interface support"
>> >         depends on HAS_DMA
>> > -       depends on ARCH_OMAP2PLUS || COMPILE_TEST
>> > +       depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || COMPILE_TEST
>>
>> How about:
>> "depends on ARM || COMPILE_TEST"
>
> I'd much prefer the former actually - it's already hard enough to use
> the config tools with the kernel due to the number of silly options
> being presented, there's no need to make it worse.
>
> In fact, I'd like to see more of the former (provided done sensibly)
> to reduce the number of config options seen for configurations to cut
> down on the shere noise of useless options.  For example, if I've
> decided I don't want to support TI OMAP platforms, then I shouldn't
> be offered the TI OMAP MMC driver.

Okay, fair enough and I don't have any strong opinions around this.

I queued up the patch for next, thanks!

Kind regards
Uffe

[PATCH 3/5] ARM: keystone: defconfig: Enable PINCTRL SINGLE for Keystone 2

[Franklin S Cooper Jr]

Newer Keystone 2 devices utilize pinmuxing. Enable PINCTRL SINGLE
which is used to handle pinmuxing.

Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
 arch/arm/configs/keystone_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/keystone_defconfig b/arch/arm/configs/keystone_defconfig
index 95ce128..e0e0365 100644
--- a/arch/arm/configs/keystone_defconfig
+++ b/arch/arm/configs/keystone_defconfig
@@ -208,3 +208,4 @@ CONFIG_GPIO_SYSCON=y
 CONFIG_TI_DAVINCI_MDIO=y
 CONFIG_MARVELL_PHY=y
 CONFIG_DEVTMPFS=y
+CONFIG_PINCTRL_SINGLE=y
-- 
2.6.1

[PATCH 4/5] ARM: keystone: defconfig: Enable MMC support

[Franklin S Cooper Jr]

Newer Keystone 2 devices support MMC and can boot from MMC. Therefore,
enable MMC support along with MMC OMAP HS whose driver is reused.

Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
 arch/arm/configs/keystone_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/configs/keystone_defconfig b/arch/arm/configs/keystone_defconfig
index e0e0365..ed3e83e 100644
--- a/arch/arm/configs/keystone_defconfig
+++ b/arch/arm/configs/keystone_defconfig
@@ -137,6 +137,8 @@ CONFIG_I2C_DAVINCI=y
 CONFIG_SPI=y
 CONFIG_SPI_DAVINCI=y
 CONFIG_SPI_SPIDEV=y
+CONFIG_MMC=y
+CONFIG_MMC_OMAP_HS=y
 # CONFIG_HWMON is not set
 CONFIG_POWER_SUPPLY=y
 CONFIG_POWER_RESET=y
-- 
2.6.1

[PATCH 4/5] ARM: keystone: defconfig: Enable MMC support

[santosh shilimkar]

On 10/20/2015 2:50 PM, Franklin S Cooper Jr wrote:
> Newer Keystone 2 devices support MMC and can boot from MMC. Therefore,
> enable MMC support along with MMC OMAP HS whose driver is reused.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
Please notify once MMC patch is accepted and I will
this one then.

[PATCH 5/5] ARM: keystone: defconfig: Enable CAN support

[Franklin S Cooper Jr]

Newer Keystone 2 devices support CAN. Enable CAN support as modules.

Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
 arch/arm/configs/keystone_defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/configs/keystone_defconfig b/arch/arm/configs/keystone_defconfig
index ed3e83e..e9bd825 100644
--- a/arch/arm/configs/keystone_defconfig
+++ b/arch/arm/configs/keystone_defconfig
@@ -137,6 +137,9 @@ CONFIG_I2C_DAVINCI=y
 CONFIG_SPI=y
 CONFIG_SPI_DAVINCI=y
 CONFIG_SPI_SPIDEV=y
+CONFIG_CAN=m
+CONFIG_CAN_C_CAN=m
+CONFIG_CAN_C_CAN_PLATFORM=m
 CONFIG_MMC=y
 CONFIG_MMC_OMAP_HS=y
 # CONFIG_HWMON is not set
-- 
2.6.1

[PATCH 5/5] ARM: keystone: defconfig: Enable CAN support

[santosh shilimkar]

On 10/20/2015 2:50 PM, Franklin S Cooper Jr wrote:
> Newer Keystone 2 devices support CAN. Enable CAN support as modules.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
Again. Please shown me the usecases before adding config
option. DTS nodes have to be there.

>   arch/arm/configs/keystone_defconfig | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/configs/keystone_defconfig b/arch/arm/configs/keystone_defconfig
> index ed3e83e..e9bd825 100644
> --- a/arch/arm/configs/keystone_defconfig
> +++ b/arch/arm/configs/keystone_defconfig
> @@ -137,6 +137,9 @@ CONFIG_I2C_DAVINCI=y
>   CONFIG_SPI=y
>   CONFIG_SPI_DAVINCI=y
>   CONFIG_SPI_SPIDEV=y
> +CONFIG_CAN=m
> +CONFIG_CAN_C_CAN=m
> +CONFIG_CAN_C_CAN_PLATFORM=m
>   CONFIG_MMC=y
>   CONFIG_MMC_OMAP_HS=y
>   # CONFIG_HWMON is not set
>

[PATCH 1/5] ARM: Keystone: Enable PINCTRL for Keystone ARCH

[santosh shilimkar]

On 10/20/2015 2:50 PM, Franklin S Cooper Jr wrote:
> From: Franklin Cooper <fcooper@ti.com>
>
> Unlike other Keystone 2 devices, newer Keystone 2 SOCs may utilize
> pinmuxing which requires PINCTRL to be enabled. Therefore, enable
> PINCTRL for all Keystone 2 devices.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
>   arch/arm/mach-keystone/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
I would be happy to add this one when I see pin
control data in DTS and its actually going to be
used in upstream kernel. Till then I don't want
to add this one.

Regards,
Santosh

[PATCH 1/5] ARM: Keystone: Enable PINCTRL for Keystone ARCH

[Murali Karicheri]

On 10/20/2015 09:26 PM, santosh shilimkar wrote:
> On 10/20/2015 2:50 PM, Franklin S Cooper Jr wrote:
>> From: Franklin Cooper <fcooper@ti.com>
>>
>> Unlike other Keystone 2 devices, newer Keystone 2 SOCs may utilize
>> pinmuxing which requires PINCTRL to be enabled. Therefore, enable
>> PINCTRL for all Keystone 2 devices.
>>
>> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
>> ---
>>   arch/arm/mach-keystone/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
> I would be happy to add this one when I see pin
> control data in DTS and its actually going to be
> used in upstream kernel. Till then I don't want
> to add this one.
>
Agree. It is too early to add the defconfig update and should be 
deferred to when the DTS update is made. What if the newer keystone 2 
SoC never end up in the tree?

Murali
> Regards,
> Santosh
>


-- 
Murali Karicheri
Linux Kernel, Keystone

[PATCH 1/5] ARM: Keystone: Enable PINCTRL for Keystone ARCH

[Murali Karicheri]

On 10/20/2015 05:50 PM, Franklin S Cooper Jr wrote:
> From: Franklin Cooper <fcooper@ti.com>
>
> Unlike other Keystone 2 devices, newer Keystone 2 SOCs may utilize
> pinmuxing which requires PINCTRL to be enabled. Therefore, enable
> PINCTRL for all Keystone 2 devices.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
>   arch/arm/mach-keystone/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-keystone/Kconfig b/arch/arm/mach-keystone/Kconfig
> index ea955f6db..7a432ee 100644
> --- a/arch/arm/mach-keystone/Kconfig
> +++ b/arch/arm/mach-keystone/Kconfig
> @@ -11,6 +11,7 @@ config ARCH_KEYSTONE
>   	select ZONE_DMA if ARM_LPAE
>   	select MIGHT_HAVE_PCI
>   	select PCI_DOMAINS if PCI
> +	select PINCTRL
>   	help
>   	  Support for boards based on the Texas Instruments Keystone family of
>   	  SoCs.
>
Have the Newer SoC base port is sent to the list? Please add these along 
with that series, not now.

-- 
Murali Karicheri
Linux Kernel, Keystone