From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF1F0C433FE for ; Thu, 20 Oct 2022 11:25:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kHrzhE2EE26S1dFHRCF/7eGdzJNWVkU0HYb5YlF9gbw=; b=s/Qs1sSCksbkK9 wMZ6KtuveBaQs+4/FCHoGJ8ehuZHahWs08IYL0SZ2jia6bxcFv04X14lIJOOsNUye/bhsD77OCpwG dmHNKRF+Me9qD/IOLrRs0EwX0cAsLncXi44c8ErHfCfqzArmWr2ijO6pyjPx6x/b27gxjNKRjl2X+ NshwjCXCgi5E5tFdGDAAypDC0sljzhsQbaKrMC4ixz96u6Kc+YaA3mrvYzPW0gHDaJS+r9hcA0kXq lDNJabA76nT9M4SjhqcSIFm4aT/PYUHjyx5Ntn6SmV1ZL0bYod4d+MgXfR1lMGvE/G6PwP3PwndV0 0wRzjbQJ69JOXoj5ArLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olTfA-00E2qi-1u; Thu, 20 Oct 2022 11:24:36 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olSvQ-00De83-Ot for linux-arm-kernel@lists.infradead.org; Thu, 20 Oct 2022 10:37:22 +0000 Received: by mail-pj1-x102d.google.com with SMTP id t10-20020a17090a4e4a00b0020af4bcae10so2644474pjl.3 for ; Thu, 20 Oct 2022 03:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=z+za2fWWq/FJfBBcjb1tNCF1EGnC+USIRnJnBiSfyRA=; b=RJQT7TgwV++5Ot4Nh7q0NzY/MddbMV6I3iMYmbOTLicsiPprYBf9SXEASdusOc3JD9 Bq8ZWEdg/ieIwC1dJIxWxMSbqbRlC16StndYYYmVcmAzAaqzLkvrXHT+nSsV1wZEdQ5g T9rUoBuHv5pYYIkH8lJHrW96XDeumj3gP+5tbj8KW7l0TPEr3ZAWy50QTbxZ+woONXdv BBu5ZOBXWB68uj0jDc82zuSpzmmynLszsY71I/FKZzrVkFeg2r2kFSa3QSKpNWCtUGyP e4Ngk7mY9DLO2GucHKo78zGi0r7Fy0beDm3nr+3mERMZQ6C95iZnul83ZYlhZJArV7LF 3aEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z+za2fWWq/FJfBBcjb1tNCF1EGnC+USIRnJnBiSfyRA=; b=fJ3khPFFhQDxOZWspNFTcSPGj5jE4OUy/et7APS4pbY2EmmkBSRvHWjT9g7sQUoYhX 4yW4i55ypeGiSp+hHDdF8yQZQ6JvhvaRK4pfNdvzm0VkrfEjZ0kUmd9EgsVYqZVLXRBB HC3aH6wVxSGofduzZC3Pv1HKkGBTIeC6d967l/NQU4vlfDZwS3kHNQy/2hq2FlY0OoPc 1dhTCIRW0TyIv2ojBiLdTI8BDEBeLdiJGyLQol71MC9rXIQ8ZMqj17Hhbx7pv49oyNOS HwsnbkKeOeUcvH2ommtgcoSSwVxRbbJ6f2D0ZyE5WgZJGLheVgpVe/jOXouB+61oGWs7 CGmQ== X-Gm-Message-State: ACrzQf2X95mVAuosLhBTyw6WiRm8y9xyBimo1eoYx3/tVHZpuuCTupMk XpQWMZFKCmBFqlqGw5wp5JyNrVB9iKFqTYoM+Ri5UA== X-Google-Smtp-Source: AMsMyM4vJmc5X/03l+yCR183PiNOSqzELcttxJqqAeZ/GGB1DpS6wVWm/BZ366OVPUfHGbfq64PodwhC/laJR//QTP4= X-Received: by 2002:a17:903:246:b0:179:96b5:1ad2 with SMTP id j6-20020a170903024600b0017996b51ad2mr13160960plh.37.1666262237829; Thu, 20 Oct 2022 03:37:17 -0700 (PDT) MIME-Version: 1.0 References: <20221019144119.3848027-1-arnd@kernel.org> <20221019150410.3851944-1-arnd@kernel.org> <20221019150410.3851944-3-arnd@kernel.org> In-Reply-To: <20221019150410.3851944-3-arnd@kernel.org> From: Ulf Hansson Date: Thu, 20 Oct 2022 12:36:40 +0200 Message-ID: Subject: Re: [PATCH 03/17] mmc: remove cns3xxx driver To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Adrian Hunter , linux-kernel@vger.kernel.org, Arnd Bergmann , Krzysztof Halasa , linux-mmc@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221020_033720_862940_D8D064DA X-CRM114-Status: GOOD ( 27.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 19 Oct 2022 at 17:06, Arnd Bergmann wrote: > > From: Arnd Bergmann > > The cns3xxx platform is gone, so this driver is now orphaned. > > Cc: Krzysztof Halasa > Signed-off-by: Arnd Bergmann Acked-by: Ulf Hansson Kind regards Uffe > --- > drivers/mmc/host/Kconfig | 11 --- > drivers/mmc/host/Makefile | 1 - > drivers/mmc/host/sdhci-cns3xxx.c | 113 ------------------------------- > 3 files changed, 125 deletions(-) > delete mode 100644 drivers/mmc/host/sdhci-cns3xxx.c > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index f324daadaf70..1c5b1c48a230 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -253,17 +253,6 @@ config MMC_SDHCI_CADENCE > > If unsure, say N. > > -config MMC_SDHCI_CNS3XXX > - tristate "SDHCI support on the Cavium Networks CNS3xxx SoC" > - depends on ARCH_CNS3XXX || COMPILE_TEST > - depends on MMC_SDHCI_PLTFM > - help > - This selects the SDHCI support for CNS3xxx System-on-Chip devices. > - > - If you have a controller with this interface, say Y or M here. > - > - If unsure, say N. > - > config MMC_SDHCI_ESDHC_MCF > tristate "SDHCI support for the Freescale eSDHC ColdFire controller" > depends on M5441x > diff --git a/drivers/mmc/host/Makefile b/drivers/mmc/host/Makefile > index 4e4ceb32c4b4..7bea77c28b7e 100644 > --- a/drivers/mmc/host/Makefile > +++ b/drivers/mmc/host/Makefile > @@ -77,7 +77,6 @@ obj-$(CONFIG_MMC_REALTEK_USB) += rtsx_usb_sdmmc.o > > obj-$(CONFIG_MMC_SDHCI_PLTFM) += sdhci-pltfm.o > obj-$(CONFIG_MMC_SDHCI_CADENCE) += sdhci-cadence.o > -obj-$(CONFIG_MMC_SDHCI_CNS3XXX) += sdhci-cns3xxx.o > obj-$(CONFIG_MMC_SDHCI_ESDHC_MCF) += sdhci-esdhc-mcf.o > obj-$(CONFIG_MMC_SDHCI_ESDHC_IMX) += sdhci-esdhc-imx.o > obj-$(CONFIG_MMC_SDHCI_DOVE) += sdhci-dove.o > diff --git a/drivers/mmc/host/sdhci-cns3xxx.c b/drivers/mmc/host/sdhci-cns3xxx.c > deleted file mode 100644 > index 2a29c7a4f308..000000000000 > --- a/drivers/mmc/host/sdhci-cns3xxx.c > +++ /dev/null > @@ -1,113 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0-only > -/* > - * SDHCI support for CNS3xxx SoC > - * > - * Copyright 2008 Cavium Networks > - * Copyright 2010 MontaVista Software, LLC. > - * > - * Authors: Scott Shu > - * Anton Vorontsov > - */ > - > -#include > -#include > -#include > -#include > -#include "sdhci-pltfm.h" > - > -static unsigned int sdhci_cns3xxx_get_max_clk(struct sdhci_host *host) > -{ > - return 150000000; > -} > - > -static void sdhci_cns3xxx_set_clock(struct sdhci_host *host, unsigned int clock) > -{ > - struct device *dev = mmc_dev(host->mmc); > - int div = 1; > - u16 clk; > - unsigned long timeout; > - > - host->mmc->actual_clock = 0; > - > - sdhci_writew(host, 0, SDHCI_CLOCK_CONTROL); > - > - if (clock == 0) > - return; > - > - while (host->max_clk / div > clock) { > - /* > - * On CNS3xxx divider grows linearly up to 4, and then > - * exponentially up to 256. > - */ > - if (div < 4) > - div += 1; > - else if (div < 256) > - div *= 2; > - else > - break; > - } > - > - dev_dbg(dev, "desired SD clock: %d, actual: %d\n", > - clock, host->max_clk / div); > - > - /* Divide by 3 is special. */ > - if (div != 3) > - div >>= 1; > - > - clk = div << SDHCI_DIVIDER_SHIFT; > - clk |= SDHCI_CLOCK_INT_EN; > - sdhci_writew(host, clk, SDHCI_CLOCK_CONTROL); > - > - timeout = 20; > - while (!((clk = sdhci_readw(host, SDHCI_CLOCK_CONTROL)) > - & SDHCI_CLOCK_INT_STABLE)) { > - if (timeout == 0) { > - dev_warn(dev, "clock is unstable"); > - break; > - } > - timeout--; > - mdelay(1); > - } > - > - clk |= SDHCI_CLOCK_CARD_EN; > - sdhci_writew(host, clk, SDHCI_CLOCK_CONTROL); > -} > - > -static const struct sdhci_ops sdhci_cns3xxx_ops = { > - .get_max_clock = sdhci_cns3xxx_get_max_clk, > - .set_clock = sdhci_cns3xxx_set_clock, > - .set_bus_width = sdhci_set_bus_width, > - .reset = sdhci_reset, > - .set_uhs_signaling = sdhci_set_uhs_signaling, > -}; > - > -static const struct sdhci_pltfm_data sdhci_cns3xxx_pdata = { > - .ops = &sdhci_cns3xxx_ops, > - .quirks = SDHCI_QUIRK_BROKEN_DMA | > - SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK | > - SDHCI_QUIRK_INVERTED_WRITE_PROTECT | > - SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN | > - SDHCI_QUIRK_BROKEN_TIMEOUT_VAL, > -}; > - > -static int sdhci_cns3xxx_probe(struct platform_device *pdev) > -{ > - return sdhci_pltfm_register(pdev, &sdhci_cns3xxx_pdata, 0); > -} > - > -static struct platform_driver sdhci_cns3xxx_driver = { > - .driver = { > - .name = "sdhci-cns3xxx", > - .probe_type = PROBE_PREFER_ASYNCHRONOUS, > - .pm = &sdhci_pltfm_pmops, > - }, > - .probe = sdhci_cns3xxx_probe, > - .remove = sdhci_pltfm_unregister, > -}; > - > -module_platform_driver(sdhci_cns3xxx_driver); > - > -MODULE_DESCRIPTION("SDHCI driver for CNS3xxx"); > -MODULE_AUTHOR("Scott Shu, " > - "Anton Vorontsov "); > -MODULE_LICENSE("GPL v2"); > -- > 2.29.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel