From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E288C433ED for ; Tue, 11 May 2021 13:02:13 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5DF47611CB for ; Tue, 11 May 2021 13:02:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DF47611CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jZa0QRblSkQpwK4cbqMhugpL/y7mBf6+jSSS1ve0Awg=; b=YS+uJWcZ4xDBgITsMA2cCVHRh rV2a1odwzyX1RduSMO6mEU0zBpkTXBciKo/gE6yDIPqqM1tfMGxZ8llf5QzIDWBIcQmqT9B7VLBOh vU0fDDG8QpBSq5M+H8jr30FCqnkBGr5zttmJcRruwIdI8qqUkfQIgosms3MIORpqAF7gkHhjPEHa+ +gALY2sfYM4MUijC7qJc5p7uelPQoeSgDdAuTsZNT4Aui224Afbbnjr5MjdFG0RR3XxCwUY/rGa5z 9HFfDlSSp2ld635I3H9yWuRJmz7SPLrAaVeKzGiVKyrIg58RslNdideDwSdb4pl/U/0IWI0wyBLFU bGo8Bkz4Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgRzs-00HXcB-8k; Tue, 11 May 2021 13:00:24 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgQ4Q-00H2aj-KE for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 10:56:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=krrXoOQowFRAS4ha9BPKaEPs6gzq6K83uwGtNzWwAQg=; b=LqS077Du24ae9+qvy3QaibLa9C ivLJB92cmdAPWnVIRcaubpTT/x7bMram3lZM1+6lyeb0/2qT2s8VXH3eOiqGhvdZ8h1XhdCOyY8jR vEOKu9lC/MN2kysOozZmVVlTKua72j7chUNfR0gDtcmT8G/rNvLBv3Ac/5lzeWhulFGly9R+KuT3+ 7sK6YipkRrFd0ZcRPtENpBe+b6AcCU/xOymHRazWx2wAv0ca5T8EznXhzxFDKtIzGNWgs7mu2leiX 7hdJz8FMjjRQhVrWDqfQQ1yIYZIMhC709aBDgcIeMbtMRjCLx/MwHi0506a7/rxGVf0eUsA4rKIPf H+WJ2wHw==; Received: from mail-vs1-xe2f.google.com ([2607:f8b0:4864:20::e2f]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgQ4O-009UwU-0Z for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 10:56:57 +0000 Received: by mail-vs1-xe2f.google.com with SMTP id j13so9974592vsf.2 for ; Tue, 11 May 2021 03:56:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=krrXoOQowFRAS4ha9BPKaEPs6gzq6K83uwGtNzWwAQg=; b=ACnL0dHkwLYgVRLIqXXl9waYOfpeGuw6bxFeIn0GshIdwkCzuuDbsUDkcHVa3iHWbD 9dMFrYAOSH6caHfutfFKebSEauklzP02eMHhavj642e3BUN6RzyQTAZ06ZzHxH5bsX/p AO5X5sJBRZ75Y6HyMrXazCTDY3X8Nox9vnaFXMT0SZHfvuzMeEWhpEYw7g2kBWdv4XU/ nbbCd5oy+j72M7FLpX1+PnQNZ7OqXnEicQbzxRRjqlV6NUFQB9dhBwOAfq+FiITsBFwL oyH4FpASr2Y92pOiXm8TsNiZY9xTSYUEJA7Xi575WTf8k0e/kRc+UgzvshXpjUIh+wTi FX/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=krrXoOQowFRAS4ha9BPKaEPs6gzq6K83uwGtNzWwAQg=; b=R9EWPUUafKZwGXfVn20dobPMdlXEl0682BRmBAEJ2wUxbLDSVR9+gpshMuz1RJM+Hp 3nePsYZYwxQcwZ7wJXVVvoo/YsHRUvEUq4KSgO9nHcUxYRr7VRN0SGTAiJ+OeNLF90tl O2DtHv316Kbva4xIrrZAaHqxYUQL0cPrEXGOUoW4lDwKA4EWsACzeY5y80YyyXdnVZjF vJdj448w3CXaeUWBcKuz7Npva8DSMTt4KMjXUa8oQgahRslv5cnNlyXlb/6xmrytWtYK o+lCXAm7A7Jo3MCB+BIKKAwhsj3uy1lfdr7skF4fspTFTM9R0KGSq06GgD24Q+ma2xg7 hqdw== X-Gm-Message-State: AOAM53218fCfzxXl6iAi3pUvEym1L+/5BtLLSjozOb3brIMe2Qayu1c1 uXo4x2nxUOaP/RTWMGjjxq7fb67V1reEPZsURfswQg== X-Google-Smtp-Source: ABdhPJxzT/keb4NOKXYCQGmWjolAOxpB1deXwetWTWdB7OlQ0knG8WgebyOQPjN1sx3avf7QixyvXZE1TGni0Xt+ppw= X-Received: by 2002:a67:f60e:: with SMTP id k14mr25253513vso.48.1620730614934; Tue, 11 May 2021 03:56:54 -0700 (PDT) MIME-Version: 1.0 References: <20210426175559.3110575-1-narmstrong@baylibre.com> <20210426175559.3110575-2-narmstrong@baylibre.com> In-Reply-To: <20210426175559.3110575-2-narmstrong@baylibre.com> From: Ulf Hansson Date: Tue, 11 May 2021 12:56:17 +0200 Message-ID: Subject: Re: [PATCH 2/2] mmc: meson-gx: also check SD_IO_RW_EXTENDED for scatterlist size alignment To: Neil Armstrong Cc: Kevin Hilman , linux-mmc , "open list:ARM/Amlogic Meson..." , Linux ARM , Linux Kernel Mailing List , Christian Hewitt X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_035656_074961_1235A7F9 X-CRM114-Status: GOOD ( 23.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 26 Apr 2021 at 19:56, Neil Armstrong wrote: > > The brcmfmac driver can generate a scatterlist from a skb with each packets > not aligned to the block size. This is not supported by the Amlogic Descriptor > dma engine where each descriptor must match a multiple of the block size. > > The sg list is valid, since the sum of the sg buffers is a multiple of the > block size, but we must discard those when in SD_IO_RW_EXTENDED mode since > SDIO block mode can be used under the hood even with data->blocks == 1. > > Those transfers are very rare, thus can be replaced by a bounce buffer > without real performance loss. > > Fixes: 7412dee9f1fd ("mmc: meson-gx: replace WARN_ONCE with dev_warn_once about scatterlist size alignment in block mode") > Reported-by: Christian Hewitt > Signed-off-by: Neil Armstrong Applied for fixes and by adding a stable tag, thanks! Kind regards Uffe > --- > drivers/mmc/host/meson-gx-mmc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c > index 1c61f0f24c09..016a6106151a 100644 > --- a/drivers/mmc/host/meson-gx-mmc.c > +++ b/drivers/mmc/host/meson-gx-mmc.c > @@ -236,7 +236,8 @@ static void meson_mmc_get_transfer_mode(struct mmc_host *mmc, > if (host->dram_access_quirk) > return; > > - if (data->blocks > 1) { > + /* SD_IO_RW_EXTENDED (CMD53) can also use block mode under the hood */ > + if (data->blocks > 1 || mrq->cmd->opcode == SD_IO_RW_EXTENDED) { > /* > * In block mode DMA descriptor format, "length" field indicates > * number of blocks and there is no way to pass DMA size that > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel