Re: [PATCH v2] mmc: sdhci-esdhc-imx: fix few build warnings

[Ulf Hansson <ulf.hansson@linaro.org>]

On Fri, 16 May 2025 at 09:44, Haibo Chen <haibo.chen@nxp.com> wrote:
>
> drivers/mmc/host/sdhci-esdhc-imx.c:1566 sdhci_esdhc_imx_hwinit() warn: inconsistent indenting
> drivers/mmc/host/sdhci-esdhc-imx.c:1251 esdhc_executing_tuning() error: uninitialized symbol 'target_min'.
> drivers/mmc/host/sdhci-esdhc-imx.c:1251 esdhc_executing_tuning() error: uninitialized symbol 'target_max'.
>
> Fixes: be953af79cc6 ("mmc: sdhci-esdhc-imx: widen auto-tuning window for standard tuning")
> Fixes: 541a95e64d76 ("mmc: sdhci-esdhc-imx: optimize the manual tuing logic to get the best timing")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/all/202505160225.Csr5USfq-lkp@intel.com/
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-esdhc-imx.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index c0160c69a027826c4099c9bcf82cd4d83f1113fd..741db169f44d9c9c1e5e1dee591b72221fa1e2b9 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -1216,8 +1216,8 @@ static int esdhc_executing_tuning(struct sdhci_host *host, u32 opcode)
>         int win_length, target_min, target_max, target_win_length;
>         u32 clk_tune_ctrl_status, temp;
>
> -       min = ESDHC_TUNE_CTRL_MIN;
> -       max = ESDHC_TUNE_CTRL_MIN;
> +       min = target_min = ESDHC_TUNE_CTRL_MIN;
> +       max = target_max = ESDHC_TUNE_CTRL_MIN;
>         target_win_length = 0;
>         while (max < ESDHC_TUNE_CTRL_MAX) {
>                 /* find the mininum delay first which can pass tuning */
> @@ -1591,8 +1591,8 @@ static void sdhci_esdhc_imx_hwinit(struct sdhci_host *host)
>                          * wider, give auto tuning enough space to handle the sample
>                          * point shift cause by temperature change.
>                          */
> -                        tmp &= ~ESDHC_TUNING_WINDOW_MASK;
> -                        tmp |= FIELD_PREP(ESDHC_TUNING_WINDOW_MASK, ESDHC_AUTO_TUNING_WINDOW);
> +                       tmp &= ~ESDHC_TUNING_WINDOW_MASK;
> +                       tmp |= FIELD_PREP(ESDHC_TUNING_WINDOW_MASK, ESDHC_AUTO_TUNING_WINDOW);
>
>                         /* Disable the CMD CRC check for tuning, if not, need to
>                          * add some delay after every tuning command, because
>
> ---
> base-commit: 484803582c77061b470ac64a634f25f89715be3f
> change-id: 20250516-b4-usdhc-bcd8cea08ed6
>
> Best regards,
> --
> Haibo Chen <haibo.chen@nxp.com>
>