From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F53BC05027 for ; Wed, 8 Feb 2023 06:09:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jgJNNTBi78wYEzizDbpxz613id+Fdgdzb7zhUk9jx8I=; b=Eqtn6xyU/HB+oC 2zTotE32+W0hWNk3+bOC62B51llfs/041Lueh72M2tIbZlQrK8sN5YkxeHFeQ00RZ6S+bjYD9go+G oKYAbwYpjxcL3/3oG3QHxPwSl/XTbYcUABuTB8qsrblVb6VigLjTfFKVKBxiUlE3gd1MAT+5DoUli 30oMLZSXXulduu4lGF06C9ydmuyX4MqQrtFpXerBmmoVh/lGCBRVbM/gF6AL/MMIgauawpHDuz09v 0q/x+UwXTfDyAhIeDp4xFdsHsOmVAfiGHJtpT1gvJ95+HHZARUdo1bef00fXR2mSOK5L1Z2vbW5gV l228ZJcoRBQxdAxoBG5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPdcs-00EGm4-8P; Wed, 08 Feb 2023 06:08:14 +0000 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPdcp-00EGlf-Ac for linux-arm-kernel@lists.infradead.org; Wed, 08 Feb 2023 06:08:12 +0000 Received: by mail-pf1-x42c.google.com with SMTP id 194so1948416pfy.4 for ; Tue, 07 Feb 2023 22:08:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Iec23gsP+sSms2hV+HR+Vp0eFbhDQHdA6maO2iZiIVw=; b=LKUOLxjmnNMz9gvLHLLDkZ417tWU/oPLRPjDnHjj+O56WlbzroFIcAgNxOAnou09Td fq6PJ2vMNs6bzz2LqZas4kJwN6TIQKwcHleK2D0VS0yp1g1Tj3ko9+aMvpMYT0LXJjY6 LADxqQdVRhECEjv9q0Inr1hNMEdOPXAlN9mfhhNUu50/oZHECDvUdIBMpwc1zksr3d99 /hRoAJB9YcOQ9qYJ09bPJm/pQ9JaQidxeio6QRZw/k5SLWbNZWF5gCnC9J0rH+vn1DjD DhjLYhCq2b8LxHR/KhLuYaZgMjT3ydhbrTT5sD2S4KnTPD27vOGWf8yaTQGcmhJmqh21 soUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Iec23gsP+sSms2hV+HR+Vp0eFbhDQHdA6maO2iZiIVw=; b=jIGwhoEJDP6PUYkNgrHWjsV6/SKHbCN31BHIuTbYbn+tujmfFq8gUSTWgoGrXMzCIJ JXvE6tfCIdXO0CD6GtQw32iKCjK6izLQD347XLhS3P3r/mJYgAjgb1H4bH+oNit6uV5j 4gwhT2lnBME36XLGEogSuqcWXl1yaSVGsNP1baobUox8Du5MoCtrPkDWqXGPHXS1B2iQ KKN6rtwR/eFORPBoc3IPHsTWCAvHUsVULNKriiGuBm+FtVNYDs0c9+pMzQgCHInxFkjH CtEmC4BodnCdOmUlBXKsiadRTHDgr0fJpxGV/Qwm72uzqdQ/iJ/ecCaAgyIvtT8gtIqy 4p0A== X-Gm-Message-State: AO0yUKUufpJ1E/fQt9IUshjsuFXdm8COyqW+wDOJYJi3iqn0+gXzLNue u1Z1d8KV6lG0m4Qz72xeXyCeVAyIry7OGQU3rHVeEA== X-Google-Smtp-Source: AK7set9VK9sGir420UmhyaPvxF5uQawzrlEDIpDo9OvveQC0SfMGXXRUKk/qqxnI3hWKpv94NGRSPK5OJiOWw65QFas= X-Received: by 2002:a62:cf06:0:b0:5a8:1929:f482 with SMTP id b6-20020a62cf06000000b005a81929f482mr388781pfg.49.1675836489152; Tue, 07 Feb 2023 22:08:09 -0800 (PST) MIME-Version: 1.0 References: <20230203060924.8257-1-semen.protsenko@linaro.org> <20230203060924.8257-7-semen.protsenko@linaro.org> <59ff815b-baad-02c5-67df-e4d65f63afa3@linaro.org> In-Reply-To: <59ff815b-baad-02c5-67df-e4d65f63afa3@linaro.org> From: Sam Protsenko Date: Wed, 8 Feb 2023 00:08:18 -0600 Message-ID: Subject: Re: [PATCH 6/6] clk: samsung: exynos5433: Extract PM support to common ARM64 layer To: Krzysztof Kozlowski Cc: Marek Szyprowski , Sylwester Nawrocki , Chanwoo Choi , Tomasz Figa , Alim Akhtar , Chanho Park , David Virag , Sumit Semwal , Michael Turquette , Stephen Boyd , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230207_220811_407545_3D54E5B4 X-CRM114-Status: GOOD ( 18.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 3 Feb 2023 at 03:18, Krzysztof Kozlowski wrote: > > On 03/02/2023 07:09, Sam Protsenko wrote: > > Exynos5433 clock driver implements PM support internally, which might be > > also useful for other Exynos clock drivers. Extract all PM related code > > from clk-exynos5433 to common ARM64 functions. > > > > Signed-off-by: Sam Protsenko > > --- > > > > > > if (IS_ERR(parent_clk)) { > > pr_err("%s: could not find bus clock %s; err = %ld\n", > > @@ -91,6 +112,46 @@ static int __init exynos_arm64_enable_bus_clk(struct device *dev, > > return 0; > > } > > > > +static int __init exynos_arm64_cmu_prepare_pm(struct device *dev, > > + const struct samsung_cmu_info *cmu) > > Align the arguments. > The same issue here as in my previous answer, unfortunately: when I try to align the `cmu' argument to match the open parentheses, it doesn't fit 80 characters limit, which doesn't look nice to me. Do you mind if I leave it as is? > Rest looks good to me. > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel