From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5432EC433EF for ; Tue, 19 Jul 2022 14:11:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W7CPwtMCYB7QhJKlSHaZWRcuD5MS6y/YS7aO3wzeU9c=; b=qbcDvB/nF1dbui /akfCnG9e3DkCTv8/nZpu3EW5RDFMRDPL4gVmnfhlHoc1IbaqoRRNBP9654Q7xAFRwdy6I4RaJrmb 6RRX79+Gw38nm5QawgdmAOwb7Bplp/SK0blX+Ngqg0rJ30V6Mei29Ny7G7W79SRK6/syZ1/LxtEQZ BmKMcqjIhM93AYyg2uG3sdQ8ElbpCW2yiBS9Bn06Fd+axRQ4nN7x6tKnVwsTQL44IAvzqCpbNrcF0 EgUcGG7AMc+vvJgSZ68i3tx799uko7/iXrOJcKl24QQKXuYcX3q13giOT7WuRkOWCo0tSunXES6Vf GSOnFPARqOBU9+8U0t3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDnvI-009WG6-0l; Tue, 19 Jul 2022 14:10:04 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDnvA-009WDH-A6 for linux-arm-kernel@lists.infradead.org; Tue, 19 Jul 2022 14:09:57 +0000 Received: by mail-ej1-x634.google.com with SMTP id ez10so27362943ejc.13 for ; Tue, 19 Jul 2022 07:09:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vJMDPQ6JxZqQ5e3bQhZhMXmqqZrhAcVL6XK53qf+yZo=; b=dF2CF31GTyulq3yHsXUA1vHe2kfxBlnZD2GJKEsvd21wdJODJxisNWK5q2qqnE8jRu dVdbJZgJTdqzovcJwW3t3CbaOdfS7JC++7wFa1cueWGgZqoHtEShGi3yiRc+wcJrYe4R 1LFTz0mj3OE37GgsKHiR2JRreETgNkWJL5b224HFw8FerDiKE6dZ30/Pr4BcZoTpNWO6 LjMlrr9ctQA+eOUZrwmG9DpU0IgSFYaJsGs4ivXnZeU0dsPshkBt2jV5QpyyshaVtwXy CjnkN3P/7C7EvzeYPIrklHPAh3suJ7JUpSe25X3FMsfE1SytE7IEz7Itd2ae7s+4mmvN HKNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vJMDPQ6JxZqQ5e3bQhZhMXmqqZrhAcVL6XK53qf+yZo=; b=unht9HNc7yvFgRzWUZB/0gJXNXRlU9G21dpM8RnEE3dqr5O0mwj6S+7JbGVrX+sYqo /zuMc7snwH9M5RQV9oiyevGkyGUVng4WnhAeAQO84QPUwYxzW6Wyazlvs2JBOpwHd4fR J5uZqtUzOZGigu2TDs/hA0r6PLTG1WZuwBeXr1v8XANKmK72RtQC2Nwwu5JR45AawhNv ALcZNKxG6wpIzPj+27U5Nt7RT09ZVsiUaY/sMQBKnHLxuqj6rkRtLkAwoAqNuHGuFI5b t9LP20ny4DPD0hstEg8xb37jJijVzwAI+h/JQk9XxWicbGXNk9bJUYSs5RXrmZ395j9H VaZw== X-Gm-Message-State: AJIora93jgOZSbD1EMUh+vpZ+eq22AQ3MaenSXoNbJUojxXKGegL5ZJm NdJCTbBVORsQS7T0iFi48FeFQXfwF12VtIdbmpNafg== X-Google-Smtp-Source: AGRyM1vIvrL+ynTCXW9jozSCwBKEDF7zOHgYSDXBTQzuGSuKy/E6HIdmsx6PziOBLoPRrbpWd3BC/TOOutSHeTbYer0= X-Received: by 2002:a17:907:97c2:b0:72b:9ec4:9a60 with SMTP id js2-20020a17090797c200b0072b9ec49a60mr29861218ejc.154.1658239795128; Tue, 19 Jul 2022 07:09:55 -0700 (PDT) MIME-Version: 1.0 References: <20220717174454.46616-1-sam@ravnborg.org> <20220717175801.78668-1-sam@ravnborg.org> In-Reply-To: <20220717175801.78668-1-sam@ravnborg.org> From: Dave Stevenson Date: Tue, 19 Jul 2022 15:09:38 +0100 Message-ID: Subject: Re: [PATCH v1 08/12] drm/mediatek: Drop mtk_hdmi_bridge_mode_fixup To: Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Dafna Hirschfeld , David Airlie , Tomi Valkeinen , Guenter Roeck , chrome-platform@lists.linux.dev, Chun-Kuang Hu , Jitao Shi , Thomas Zimmermann , Arnd Bergmann , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, Philip Chen , linux-renesas-soc@vger.kernel.org, Kieran Bingham , Enric Balletbo i Serra , Cai Huoqing X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220719_070956_386555_65EC58C1 X-CRM114-Status: GOOD ( 18.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 17 Jul 2022 at 18:58, Sam Ravnborg wrote: > > The implementation of drm_bridge_funcs.mode_fixup is optional > so there is no need to provide an empty implementation. > Drop mtk_hdmi_bridge_mode_fixup() so the driver no longer uses the > deprecated drm_bridge_funcs.mode_fixup() operation. > > Signed-off-by: Sam Ravnborg Reviewed-by: Dave Stevenson > Cc: Chun-Kuang Hu > Cc: Philipp Zabel > Cc: Matthias Brugger > Cc: linux-mediatek@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c > index a63b76055f81..7321aa1ee6f0 100644 > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c > @@ -1293,13 +1293,6 @@ static int mtk_hdmi_bridge_attach(struct drm_bridge *bridge, > return 0; > } > > -static bool mtk_hdmi_bridge_mode_fixup(struct drm_bridge *bridge, > - const struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode) > -{ > - return true; > -} > - > static void mtk_hdmi_bridge_atomic_disable(struct drm_bridge *bridge, > struct drm_bridge_state *old_bridge_state) > { > @@ -1399,7 +1392,6 @@ static const struct drm_bridge_funcs mtk_hdmi_bridge_funcs = { > .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, > .atomic_reset = drm_atomic_helper_bridge_reset, > .attach = mtk_hdmi_bridge_attach, > - .mode_fixup = mtk_hdmi_bridge_mode_fixup, > .atomic_disable = mtk_hdmi_bridge_atomic_disable, > .atomic_post_disable = mtk_hdmi_bridge_atomic_post_disable, > .mode_set = mtk_hdmi_bridge_mode_set, > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel