From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48070C4361B for ; Fri, 18 Dec 2020 14:30:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09A7B23A84 for ; Fri, 18 Dec 2020 14:30:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 09A7B23A84 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=raspberrypi.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aGyj5AePYq6abAblGocgJ55HsVALoO86kUE8Xd29lfU=; b=z+4Cr9ccurupnn826BeQFrgMg T+7qs/MrKwxD7kneic5QRaTlHBuczMl6BOsHVu1Y4CCGTGhrozY0v3voJWjtCZbRoSkvbEUG5QYo9 KlmJqLi5aoN/vCvPx9ksG3aqcJO1ZcUtre6ZVefFsz3bBYl9ymlQ9Egc0H4Ci9MKKyVRiEiwFBS+y s6QElqn1Kt3fFCfbH1hc0yA8idzLOtOoA5WbygW4IFChOX1UY6OkoPSBqSvrkGK52l+IGzF/7Sjuz j1BF/MC1x1vpFX6HyYZtivXzPDBqvLLzP0j8C+7ODnLHHzsj6lHzXpv5SNTHZJVXKpyidgPGzgmkB 6P6NT3s2Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kqGlD-00039y-Nf; Fri, 18 Dec 2020 14:29:35 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kqGlA-00038u-Iz for linux-arm-kernel@lists.infradead.org; Fri, 18 Dec 2020 14:29:33 +0000 Received: by mail-wm1-x331.google.com with SMTP id 3so2770264wmg.4 for ; Fri, 18 Dec 2020 06:29:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fQcnaVeKn76lYRwiXKR4yvTyQ/9Lgo43QJdLzaw88No=; b=dPH2ZMGlXf7qxs4VLNk1sqQ6DOFTn3EJphiLC07Hd/sKNpQ9O+b48p1oN5bMMLsNcw hUCxxdBSaWxlRLCiL9I/Tfv7Ip15ldWsKrB+y0tzx17DQZbd5X0qybJL4dS6oezkjXuL 1YSWS2M66tLqmHYc3wFa0FqObn3OYwwVpqrlVgWf01NBCJq8VBu1OVSdI4xzZvIqedxg 0eUb8r35JQVUXYis0AZPc+9VNUaDtE9dWc6DIn2A/6aZsBXFJBtRfvgj9tL/HyxINwoa hYGargZwS5AyYExBC9Pyy1MRNHD2HRaJI2tnVrHRDiAkjnG+32WYgMNbODrH25LBY6hy w3JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fQcnaVeKn76lYRwiXKR4yvTyQ/9Lgo43QJdLzaw88No=; b=oGYm4c/mCmJ5F9ii/1R32i0U7RN4010q9c4KTWcsJndD+fnkhL+j5AmXDtk+wX5Bum oYxUbVrQKWwSZcqL/RovE5T7MKj12TOMoxLjERz54zfNWszbA80CbCBJELYVmgv0OTq9 XYWaIxWjNarcI2XewyUnMIE8if00wswhUjOlVRlOwHv9J02JhpvLkW3veA0Cfk6GkUcq RlkLhZocZ30z+4g+vGuzivp0xjPonHfe9LB5a5eS5smzAoDZxnd3EphulUDDwdDI1hJH 9E7PsoCkd3QldxSnco8nkNjEkzBmtbJjCNrZh8BEiuyib4rABoOonf5NvETCbVa7+DIF mkKA== X-Gm-Message-State: AOAM532hQQ5CLzl4cRCbi/Yj8TOuwxmwNoOHIxcVFD1xgSJQIJBJN0gN q8U7pYKlK27PF0szCGKiAbnWslXWOq0P1MOhOVlTrg== X-Google-Smtp-Source: ABdhPJx1zfDnyXEmVWiw9EZm8yj56h7EPNv2EiQk8r5FgzIdRnBEqEC4Oc6xyUqbtGIHIlNzOeHBGh+HWy5KnmgE0kE= X-Received: by 2002:a1c:bc88:: with SMTP id m130mr4645539wmf.82.1608301771650; Fri, 18 Dec 2020 06:29:31 -0800 (PST) MIME-Version: 1.0 References: <20201210134648.272857-1-maxime@cerno.tech> <20201210134648.272857-13-maxime@cerno.tech> In-Reply-To: <20201210134648.272857-13-maxime@cerno.tech> From: Dave Stevenson Date: Fri, 18 Dec 2020 14:29:14 +0000 Message-ID: Subject: Re: [PATCH 12/15] drm/vc4: hdmi: Don't register the CEC adapter if there's no interrupts To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201218_092932_638593_C4CF7FA0 X-CRM114-Status: GOOD ( 19.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Cooper , David Airlie , Marc Zyngier , Maarten Lankhorst , LKML , DRI Development , Eric Anholt , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Thomas Zimmermann , Hans Verkuil , Daniel Vetter , Thomas Gleixner , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 10 Dec 2020 at 13:47, Maxime Ripard wrote: > > We introduced the BCM2711 support to the vc4 HDMI controller with 5.10, > but this was lacking any of the interrupts of the CEC controller so we > have to deal with the backward compatibility. > > Do so by simply ignoring the CEC setup if the DT doesn't have the > interrupts property. > > Signed-off-by: Maxime Ripard Reviewed-by: Dave Stevenson > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c > index 327638d93032..69217c68d3a4 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > @@ -1655,9 +1655,15 @@ static int vc4_hdmi_cec_init(struct vc4_hdmi *vc4_hdmi) > { > struct cec_connector_info conn_info; > struct platform_device *pdev = vc4_hdmi->pdev; > + struct device *dev = &pdev->dev; > u32 value; > int ret; > > + if (!of_find_property(dev->of_node, "interrupts", NULL)) { > + dev_warn(dev, "'interrupts' DT property is missing, no CEC\n"); > + return 0; > + } > + > vc4_hdmi->cec_adap = cec_allocate_adapter(&vc4_hdmi_cec_adap_ops, > vc4_hdmi, "vc4", > CEC_CAP_DEFAULTS | > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel