From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55B0CC433EF for ; Tue, 19 Jul 2022 14:13:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4rCS4EO8Q2SeQx5a5Olml+EJZWLM8T/DrPqDmPhW9GE=; b=PHSbOv7CXcq2Jh VSz/N++ZI4ytX07bPnqJuXULUDpEpbqqWm+gKzBNPGFA9vnnfACbc4AjaktOxK6uN5TdbbhONEb/z N5AswLwG2cH+z7s9uxrILv3SwXCj7u6V0rXs5SitCH9+o4u0bAWiW/TJ0Yhi5XJMFBRolp1QP8UBl HMcCTLe5ixD+V3khqvAi0BWr/b5lY8G4PBghV/Hlsnik7F5byRdQrAMPGfTZHPGFgymi/StQzQGRL OtgCexIEX0CPfInhq/VpmLrkpp2QXPbtvkYLXeuPGOlqHWqFhVgSw9Q9gA5BbNIyzv1MGoJhbuOZh h0MdgSMlcTqTk4xF5nIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDnxF-009XfO-Gc; Tue, 19 Jul 2022 14:12:05 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDnx4-009XYC-FR for linux-arm-kernel@lists.infradead.org; Tue, 19 Jul 2022 14:11:56 +0000 Received: by mail-ed1-x533.google.com with SMTP id r6so19770859edd.7 for ; Tue, 19 Jul 2022 07:11:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RnWAYtgDrYhGZC/PZ1B5ZCm3OmGHZOVctKEIlU+z6rI=; b=PpOMFXjn4g8lzVw5rHY4cup+bAESdluj4/3YOF7f+Nf6pVaKQIAOCl03o9pc+ycEg8 JzGF5OksPZHIYo8KnyZYmZrW0WECIAz29OUSWAxfSBkt+qSOGEMeFW+lYpOJ57/DLLk7 PYdg8BrOQbM/KkKhw1ljgw+DJ9JyqPEhrGlv2s2Xvji0jloqJWQx744c24n/HazvLKzM WP4RxGlwmQKNkwOHSxdqcVxD+OllnYAgIwd9FtDOhTQtG2CjkBm7BK7nWEWdcovEANB6 3gYZHINxB0I37Oya/rNkBvm7c6jRL+syTFjrov0FBNiRiOJ7LGx5YQEWJkrCKPAmY03h pSfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RnWAYtgDrYhGZC/PZ1B5ZCm3OmGHZOVctKEIlU+z6rI=; b=MTOFEPs1jg9/Ki/ToVXZzv1SEgaihtl/uYP9E/S6UFUKuoVFQqogBFVu2ntIXewxtB A3o0ERIyJ06vH3cFS19leO4TCupU4vYhZPrZRpQVD/xR0u9zOQ8Tp3izQrPh0ZK51UQR 36f9sT9vIRrrDp62450syVibt2lHHkVZn7Za6HNNaT6VwkNpmhcFNmmje4czCrejvNMK NDPN6JGjOzS74Cj1l6Wbkb2U/cXjw5+dS7tPJdfg1dvnntSoK6sc7NoHKHuzYH2rYvbH tSVtrHp7P7Svig9/LTVLZE37eiEnqA8K0LySr0z+WZUfWtZCkVlUG2iV7RTvSUn51k9V xHug== X-Gm-Message-State: AJIora/a791fQB+Ckg6a3U0QE8b99OWM3FJmCJlN74kSkrA5KKqBcndG 4FTM2P2HRCCAKW+SUPuKl7ySB8Vs67KAJwa6//t92Q== X-Google-Smtp-Source: AGRyM1u8NJW8Er8LUi8nkjhRDlt2K9GTp5JSpALaf1s7vzpZ3L6Y6cv9xNTWc9xabCNHNsVc63LyB1SwXY5mz2IiJeg= X-Received: by 2002:a05:6402:42d3:b0:435:2c49:313d with SMTP id i19-20020a05640242d300b004352c49313dmr43193671edc.86.1658239910831; Tue, 19 Jul 2022 07:11:50 -0700 (PDT) MIME-Version: 1.0 References: <20220717174454.46616-1-sam@ravnborg.org> <20220717175801.78668-1-sam@ravnborg.org> <20220717175801.78668-2-sam@ravnborg.org> In-Reply-To: <20220717175801.78668-2-sam@ravnborg.org> From: Dave Stevenson Date: Tue, 19 Jul 2022 15:11:34 +0100 Message-ID: Subject: Re: [PATCH v1 09/12] drm/rcar-du: lvds: Use drm_bridge_funcs.atomic_check To: Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Dafna Hirschfeld , David Airlie , Tomi Valkeinen , Guenter Roeck , chrome-platform@lists.linux.dev, Chun-Kuang Hu , Jitao Shi , Thomas Zimmermann , Arnd Bergmann , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, Philip Chen , linux-renesas-soc@vger.kernel.org, Kieran Bingham , Enric Balletbo i Serra , Cai Huoqing X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220719_071154_571972_DF43C5CF X-CRM114-Status: GOOD ( 19.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 17 Jul 2022 at 18:58, Sam Ravnborg wrote: > > Replace the deprecated drm_bridge_funcs.mode_fixup() with > drm_bridge_funcs.atomic_check(). > The driver implements the state operations, so no other changes > are required for the replacement. > > Signed-off-by: Sam Ravnborg Reviewed-by: Dave Stevenson > Cc: Laurent Pinchart > Cc: Kieran Bingham > Cc: linux-renesas-soc@vger.kernel.org > --- > drivers/gpu/drm/rcar-du/rcar_lvds.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c > index 830aac0a2cb4..c4adbcede090 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c > +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c > @@ -554,10 +554,12 @@ static void rcar_lvds_atomic_disable(struct drm_bridge *bridge, > clk_disable_unprepare(lvds->clocks.mod); > } > > -static bool rcar_lvds_mode_fixup(struct drm_bridge *bridge, > - const struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode) > +static int rcar_lvds_atomic_check(struct drm_bridge *bridge, > + struct drm_bridge_state *bridge_state, > + struct drm_crtc_state *crtc_state, > + struct drm_connector_state *conn_state) > { > + struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode; > struct rcar_lvds *lvds = bridge_to_rcar_lvds(bridge); > int min_freq; > > @@ -569,7 +571,7 @@ static bool rcar_lvds_mode_fixup(struct drm_bridge *bridge, > min_freq = lvds->info->quirks & RCAR_LVDS_QUIRK_EXT_PLL ? 5000 : 31000; > adjusted_mode->clock = clamp(adjusted_mode->clock, min_freq, 148500); > > - return true; > + return 0; > } > > static int rcar_lvds_attach(struct drm_bridge *bridge, > @@ -591,7 +593,7 @@ static const struct drm_bridge_funcs rcar_lvds_bridge_ops = { > .atomic_reset = drm_atomic_helper_bridge_reset, > .atomic_enable = rcar_lvds_atomic_enable, > .atomic_disable = rcar_lvds_atomic_disable, > - .mode_fixup = rcar_lvds_mode_fixup, > + .atomic_check = rcar_lvds_atomic_check, > }; > > bool rcar_lvds_dual_link(struct drm_bridge *bridge) > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel