From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49208C4361B for ; Fri, 18 Dec 2020 14:31:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F26E023A84 for ; Fri, 18 Dec 2020 14:31:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F26E023A84 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=raspberrypi.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PrAWMHmgku4VVYSe5zeS+o6FlMncwaaYy+2t0zLB7nQ=; b=YKW0gUfeyt/u62/+xUmYrpMym jcmj1BWV5yrnm+fIu/F5KWLdHvIjaZpSPSBMjT3hVz15oSGJ7csZm9MdBtBhky25mswkry3k8ZPUn VIU31IKCw2LWCsu8mnsDaxorzK6sUTS8D/h+57t46a0H7MNIIGGOBoMsy8dEC2ZoFpTDzCKjCPYMV zqM9jU1byjAyAhetNij2zYHb5IhPNc8tGJjOlVmafpBHiz2x9G0ys5rId37EMKkflkkqh0tEb6FFe MzRU12sttDOlV6O6mZ9GiHPL4MvXmBB3sqy+DvkbEydL/Q0skZOPYjhbM0sF+002X6QTlo+n4BZvp gN6c+rPCQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kqGm9-0003Ki-Bp; Fri, 18 Dec 2020 14:30:33 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kqGm4-0003IH-1S for linux-arm-kernel@lists.infradead.org; Fri, 18 Dec 2020 14:30:29 +0000 Received: by mail-wm1-x32b.google.com with SMTP id k10so2524545wmi.3 for ; Fri, 18 Dec 2020 06:30:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cSf/A3KMFP7l6dKoCFldn4orJN3Li1SRGvRFJDZdZBk=; b=FAxD2Y0NbqFM3ObrBbKO1uzFTAkuZkfq4nO0/y02pStuULzcEQVJ++qE6xjAOWSiMJ Z+zJK/11O7gH7sBtClCoRC44Lu5RNjqID1MNzTa4s/odoqiMyCdQE7nRSDhOIstJf1nv GoaY7I4IJDvHuiglAV1NWAN18RRDFPmabOcytUignipoOKlOQkMbQ+WDk0oqEuda5C8P eqDwlymwP/5kXCAkXMbeuU6nLmgGm8gdBKksDocR0F6Her14FIhXm+vqz+vCxEWde6iH Ui7oJC4E7fWuKt027IzbeCK6dw/U1rS3uFhcgxG/51fn3oVXly8LPUrMCwOpXTcbwavv jreg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cSf/A3KMFP7l6dKoCFldn4orJN3Li1SRGvRFJDZdZBk=; b=ipt+n5jImCtxy36eMN/DpFVTFitzB56jVF3aBgXMDb1rU1nbIpoozdSTMVD5GWqp6M SQmcNlk6d0/ZTbxiApksCeZeR3rGDvBN2ia27VyZRx5gE2MDrQQmL6xrhKmrI1yf1SPz GXhIcN7DqZEyeFsxT//vmFgNkhg8KYgYl9imDAEdvcCTNzt5EpjmjuBxpavmCml85VFd 1ildmVKQo5KrIFX3wgXBI/QbzPGEQFyIs5aoKsg56+JzspAQSyYWycJx0HWQz8w+oPGq Gf/KMkpKA77dm6/oxx8TBJ86rcW+bltpHudyqCoJN9uM0Vou6Tc7WqW0tQNl7YvUR85C IKGw== X-Gm-Message-State: AOAM531AHWXJLkOdGiQW/7L2qPvMAy0uukvD7csm0f8ouUxYxU7T3QYz i3DJNSmg4VXaHfbiPi6zi7OE1Bt4pW76E7pWgCr+mQ== X-Google-Smtp-Source: ABdhPJwZPxE2hgQD4zqrk0QkQvmTF5EOdTM22UN833i/JzSn6RMW16hnmxGVt7Jtvfucob2k4gTUusWtU/lA6XrmCQw= X-Received: by 2002:a1c:9a57:: with SMTP id c84mr4329681wme.183.1608301826242; Fri, 18 Dec 2020 06:30:26 -0800 (PST) MIME-Version: 1.0 References: <20201210134648.272857-1-maxime@cerno.tech> <20201210134648.272857-12-maxime@cerno.tech> In-Reply-To: <20201210134648.272857-12-maxime@cerno.tech> From: Dave Stevenson Date: Fri, 18 Dec 2020 14:30:09 +0000 Message-ID: Subject: Re: [PATCH 11/15] drm/vc4: hdmi: Remove cec_available flag To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201218_093028_092903_62F832B3 X-CRM114-Status: GOOD ( 18.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Cooper , David Airlie , Marc Zyngier , Maarten Lankhorst , LKML , DRI Development , Dom Cobley , Eric Anholt , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Thomas Zimmermann , Hans Verkuil , Daniel Vetter , Thomas Gleixner , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Dom & Maxime On Thu, 10 Dec 2020 at 13:47, Maxime Ripard wrote: > > From: Dom Cobley > > Now that our HDMI controller supports CEC for the BCM2711, let's remove > that flag. > > Signed-off-by: Dom Cobley > Signed-off-by: Maxime Ripard Reviewed-by: Dave Stevenson > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 4 ---- > drivers/gpu/drm/vc4/vc4_hdmi.h | 3 --- > 2 files changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c > index d208b7d1d937..327638d93032 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > @@ -1658,9 +1658,6 @@ static int vc4_hdmi_cec_init(struct vc4_hdmi *vc4_hdmi) > u32 value; > int ret; > > - if (!vc4_hdmi->variant->cec_available) > - return 0; > - > vc4_hdmi->cec_adap = cec_allocate_adapter(&vc4_hdmi_cec_adap_ops, > vc4_hdmi, "vc4", > CEC_CAP_DEFAULTS | > @@ -2074,7 +2071,6 @@ static const struct vc4_hdmi_variant bcm2835_variant = { > .debugfs_name = "hdmi_regs", > .card_name = "vc4-hdmi", > .max_pixel_clock = 162000000, > - .cec_available = true, > .registers = vc4_hdmi_fields, > .num_registers = ARRAY_SIZE(vc4_hdmi_fields), > > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.h b/drivers/gpu/drm/vc4/vc4_hdmi.h > index 27352827f70c..c93ada62f429 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.h > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.h > @@ -42,9 +42,6 @@ struct vc4_hdmi_variant { > /* Filename to expose the registers in debugfs */ > const char *debugfs_name; > > - /* Set to true when the CEC support is available */ > - bool cec_available; > - > /* Maximum pixel clock supported by the controller (in Hz) */ > unsigned long long max_pixel_clock; > > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel