From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBA03C10F0E for ; Sun, 7 Apr 2019 22:25:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FE5E20863 for ; Sun, 7 Apr 2019 22:25:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="O/gQcV+m"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="STseUu4Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FE5E20863 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ojo80mGohYTOOJZo4cre4Ps1Ltbvlx8iPrqHh+no3x8=; b=O/gQcV+mBcz8eZ S3gj2ncWcrPfusx2pXoHyyeA7IrLlKLumm+7M+kGwWjixfbD5CdWCISTQbAj6+sE0502nWDCd8ghm ghXGc/3efM2kDqNhN4IMmIp2WfnsUYOh4Jt4vZnfxRA+XhT4xItkHZS9uB9xvJ+/GqzqIQbPnEzS0 AQR1//KbG+Bn1kEzaMuF9IP1eU7krae7x+cOX1p9yQ3rrTXmVEMKshJvCmWNm9rimIaY5yrmW+NE2 eomVFk1Muz4xIKXrd+7GyPbfEObH2bk0QW4EyvwNVVVlgErVldcikV1XA/smN/ef2YZHbPzzuklb5 O+Iya/llz2qB/JgbE/Zw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDGEe-0006Zn-Q4; Sun, 07 Apr 2019 22:25:56 +0000 Received: from mail-ot1-x32f.google.com ([2607:f8b0:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDGEc-0006Vm-5D for linux-arm-kernel@lists.infradead.org; Sun, 07 Apr 2019 22:25:55 +0000 Received: by mail-ot1-x32f.google.com with SMTP id t8so10288514otp.7 for ; Sun, 07 Apr 2019 15:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dSIYyhAN+JUdcw1802IqaWulYZduXux4t9PncKdVS1w=; b=STseUu4Qjgjy9njAA9r9SS89Q1Qc1mHyKUU6BCe0QtFlsn76GnFYLweuE49QM8DbB5 hFS9YcVM7A71oTo2WmekqkNlZmZHSOtNhIjgxzR01ggAKWwcmWuMP0mkFiOWI5NanNzp KORWicJE2SBhGZYKlmT3gmnJLLzv+Yox4jAKmuOKS3KtKbhavdkLXOm8roFPfdaN7PzJ zeb8XaMtoe8ax/i1r5fGfNQogByAO9Zv3rLVL5K0yIji8fafHY/gWNX9lQtu2YduUaKo xIKIjsaUNOkuH4fNWJT+oh5EbWths1bWHB4Vdgp7M4yRdz0jDyLrIm01sj8i+QmN2MJd GI2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dSIYyhAN+JUdcw1802IqaWulYZduXux4t9PncKdVS1w=; b=itVg6WRWnDZLgnSKn9ylJ6WeDJYzjArrrTfl7LqZzKNzCZTSZtF3CULQTrT3PzNKZS XJqaQ08FyuZDhrlEBXdcbDE1pp4gB7YI9QuLt3tOJDkdZMhW/m9a1GqE8kmKMQIppHv7 hDjnqadfiHnqIqvUKjdPYLqtxF6UF0TY19C7OkNXsWrbfa1L+TFGjq6d4EktkemVXBqy pSYH7yDJ518aGHDB4OrCK4VgCkM8YZ6qyUOeS80fjwuukrKnUO77D1nf5mtawL6nDBGl zIR3dOgpIPlF1i6yTFi1hVJPLRB097/LMpG5oMadjIpNedrb2aIjxyqft7zOIvzOJ/19 kKMg== X-Gm-Message-State: APjAAAWAravG5H/mWQ3NUQelf1H1nP9KtJzATIQzRH/aQztCAvEiBLMc bszHAMHbt7tzOZIdcdQKUpENqTZxV+Cgqy3lA2K0UQ== X-Google-Smtp-Source: APXvYqwoVM65s3bU6ZL6Dq7BGZF2PTZbAkqqEHOI98T6m0K2l5zk/iusjB/xG87bXCPh38ljdRy+0lGj09jZOYWPeys= X-Received: by 2002:a9d:3f4b:: with SMTP id m69mr17287564otc.246.1554675953202; Sun, 07 Apr 2019 15:25:53 -0700 (PDT) MIME-Version: 1.0 References: <7885dce0-edbe-db04-b5ec-bd271c9a0612@arm.com> <5b18e1c2-4ec5-8c61-a658-fb91996b95d0@arm.com> <60d1c5b7-7f85-7658-00f3-a3e5c6edc302@arm.com> In-Reply-To: <60d1c5b7-7f85-7658-00f3-a3e5c6edc302@arm.com> From: Dan Williams Date: Sun, 7 Apr 2019 15:25:42 -0700 Message-ID: Subject: Re: struct dev_pagemap corruption To: Anshuman Khandual X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190407_152554_205843_84CF269D X-CRM114-Status: UNSURE ( 8.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Will Deacon , "linux-mm@kvack.org" , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Robin Murphy , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 5, 2019 at 7:54 AM Anshuman Khandual wrote: [..] > > Given that what seems to ultimately get corrupted is the memory pointed to by pgmap here, how is *that* being allocated? > > struct dev_pagemap *pgmap; > > pgmap = devm_kzalloc(dev, sizeof(struct dev_pagemap), GFP_KERNEL); > > Is it problematic to use dev_kzalloc here instead of generic kmalloc/kzalloc > functions ? On this specific question, no. devm_kzalloc() is how the pmem and device-dax drivers allocate the pgmap passed to devm_memremap_pages(). The unwind order of the devres resources ensures that the devm_memremap_pages() devres actions occur before the release of the pgmap allocation. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel