From: r.sh.open@gmail.com (Rahul Sharma)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] ARM: EXYNOS: initial board support for exynos5260 SoC
Date: Fri, 3 Jan 2014 14:54:26 +0530 [thread overview]
Message-ID: <CAPdUM4MHZz4z6D8VtyAAA0T1znQpeTeC-NR1shMBMJwmJ3_fqQ@mail.gmail.com> (raw)
In-Reply-To: <2452273.S9E2sU17uX@amdc1227>
Hi Tomasz,
Sorry for responding late.
On 10 December 2013 21:27, Tomasz Figa <t.figa@samsung.com> wrote:
> Hi Pankaj, Rahul, Arun,
>
> In addition to issues already pointed by Sachin, please also see my
> comments inline.
>
> On Friday 06 of December 2013 21:26:25 Rahul Sharma wrote:
>> From: Pankaj Dubey <pankaj.dubey@samsung.com>
>>
>> This patch add basic arch side support for exynos5260 SoC.
>>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>> Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
>> ---
>> arch/arm/mach-exynos/Kconfig | 9 +++++++++
>> arch/arm/mach-exynos/common.c | 19 ++++++++++++++++++-
>> arch/arm/mach-exynos/cpuidle.c | 2 +-
>> arch/arm/mach-exynos/include/mach/map.h | 1 +
>> arch/arm/mach-exynos/include/mach/regs-pmu.h | 4 ++++
>> arch/arm/mach-exynos/mach-exynos5-dt.c | 1 +
>> arch/arm/plat-samsung/include/plat/cpu.h | 8 ++++++++
>> arch/arm/plat-samsung/include/plat/map-s5p.h | 1 +
>> 8 files changed, 43 insertions(+), 2 deletions(-)
> [snip]
>> diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c
>> index ddbfe87..405c11a 100644
>> --- a/arch/arm/mach-exynos/cpuidle.c
>> +++ b/arch/arm/mach-exynos/cpuidle.c
>> @@ -120,7 +120,7 @@ static int exynos4_enter_core0_aftr(struct cpuidle_device *dev,
>> cpu_suspend(0, idle_finisher);
>>
>> #ifdef CONFIG_SMP
>> - if (!soc_is_exynos5250())
>> + if (!soc_is_exynos5250() || soc_is_exynos5260())
>
> The added OR condition doesn't affect the if condition in any way, because
> when running on Exynos5260, soc_is_exynos5250() will return false and make
> the whole condition evaluate to true.
>
> Shouldn't it be
>
> if (!soc_is_exynos5250() && !soc_is_exynos5260())
>
> if Exynos5260 doesn't need scu_enable(), or left as is if it needs?
>
Actually we don't need to call scu_enable() for 5260. Hence leaving it as it is.
>> scu_enable(S5P_VA_SCU);
>> #endif
>> cpu_pm_exit();
>> diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h
>> index 7b046b5..bd6fa02 100644
>> --- a/arch/arm/mach-exynos/include/mach/map.h
>> +++ b/arch/arm/mach-exynos/include/mach/map.h
>> @@ -29,6 +29,7 @@
>> #define EXYNOS4210_PA_SYSRAM_NS 0x0203F000
>> #define EXYNOS4x12_PA_SYSRAM_NS 0x0204F000
>> #define EXYNOS5250_PA_SYSRAM_NS 0x0204F000
>> +#define EXYNOS5260_PA_SYSRAM_NS 0x02073000
>>
>> #define EXYNOS_PA_CHIPID 0x10000000
>>
>> diff --git a/arch/arm/mach-exynos/include/mach/regs-pmu.h b/arch/arm/mach-exynos/include/mach/regs-pmu.h
>> index 2cdb63e..09ae29a 100644
>> --- a/arch/arm/mach-exynos/include/mach/regs-pmu.h
>> +++ b/arch/arm/mach-exynos/include/mach/regs-pmu.h
>> @@ -234,6 +234,10 @@
>>
>> #define EXYNOS5_SYS_WDTRESET (1 << 20)
>>
>> +#define EXYNOS5260_A7_WDTRST (1 << 24)
>> +#define EXYNOS5260_A15_WDTRST (1 << 23)
>> +#define EXYNOS5260_SYS_WDTRESET (EXYNOS5260_A7_WDTRST || EXYNOS5260_A15_WDTRST)
>> +
>
> Are these definitions needed? I don't see any user in this patch.
>
Removed these definitions.
Regards,
Rahul Sharma.
> Best regards,
> Tomasz
>
next prev parent reply other threads:[~2014-01-03 9:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 15:56 [PATCH 0/7] exynos: add basic support for exynos5260 SoC Rahul Sharma
2013-12-06 15:56 ` [PATCH 1/7] ARM: EXYNOS: initial board " Rahul Sharma
2013-12-09 6:23 ` Sachin Kamat
2013-12-09 6:33 ` Rahul Sharma
2013-12-23 4:39 ` Rahul Sharma
2013-12-10 15:57 ` Tomasz Figa
2014-01-03 9:24 ` Rahul Sharma [this message]
2013-12-06 15:56 ` [PATCH 2/7] pinctrl: exynos: add exynos5260 SoC specific data Rahul Sharma
2013-12-09 4:51 ` Sachin Kamat
2013-12-09 6:36 ` Rahul Sharma
2014-01-03 9:25 ` Rahul Sharma
2013-12-10 16:04 ` Tomasz Figa
2014-01-03 9:26 ` Rahul Sharma
2013-12-06 15:56 ` [PATCH 3/7] ARM: dts: add dts files for exynos5260 SoC Rahul Sharma
2013-12-10 17:10 ` Tomasz Figa
2014-01-06 9:40 ` Rahul Sharma
2013-12-06 15:56 ` [PATCH 4/7] clk/samsung: add support for multuple clock providers Rahul Sharma
2013-12-11 11:15 ` Tomasz Figa
2014-01-06 11:35 ` Rahul Sharma
2013-12-06 15:56 ` [PATCH 5/7] clk/samsung: add support for pll2550xx Rahul Sharma
2013-12-09 8:06 ` Sachin Kamat
2013-12-19 12:01 ` Tomasz Figa
2014-01-06 11:36 ` Rahul Sharma
2013-12-06 15:56 ` [PATCH 6/7] clk/samsung: add support for pll2650xx Rahul Sharma
2013-12-09 8:09 ` Sachin Kamat
2013-12-19 11:45 ` Tomasz Figa
2014-01-06 11:44 ` Rahul Sharma
2014-01-08 0:37 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPdUM4MHZz4z6D8VtyAAA0T1znQpeTeC-NR1shMBMJwmJ3_fqQ@mail.gmail.com \
--to=r.sh.open@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).