[PATCH v3 5/5] clk: export tree topology and clk data via sysfs

[mturquette@linaro.org (Mike Turquette)]

On Tue, Nov 22, 2011 at 5:07 AM, Arnd Bergmann <arnd.bergmann@linaro.org> wrote:
> On Tuesday 22 November 2011, Mike Turquette wrote:
>> Introduces kobject support for the common struct clk, exports per-clk
>> data via read-only callbacks and models the clk tree topology in sysfs.
>>
>> Also adds support for generating the clk tree in clk_init and migrating
>> nodes when input sources are switches in clk_set_parent.
>>
>> Signed-off-by: Mike Turquette <mturquette@linaro.org>
>> ---
>> ?drivers/clk/Kconfig ? ? | ? 10 +++
>> ?drivers/clk/Makefile ? ?| ? ?1 +
>> ?drivers/clk/clk-sysfs.c | ?199 +++++++++++++++++++++++++++++++++++++++++++++++
>> ?drivers/clk/clk.c ? ? ? | ? ?5 +-
>> ?include/linux/clk.h ? ? | ? 36 ++++++++-
>> ?5 files changed, 248 insertions(+), 3 deletions(-)
>> ?create mode 100644 drivers/clk/clk-sysfs.c
>
> Since this introduces a new top-level hierarchy in sysfs, it certainly needs
> to be reviewed by Greg K-H (on Cc now). Also, you have to add a proper
> documentation for every new node and attribute in Documentation/ABI along
> with the code.

I don't intend to keep it in the top-level /sys/ directory.  I
mentioned that in the coverletter, but not here.  I wasn't sure where
to put it, and I knew reviewers would be happy to point the right
place out to me.

>> +static struct kobject *clk_kobj;
>> +LIST_HEAD(kobj_list);
>
> The list head should be static.

Will put into V4.

Thanks,
Mike

>
> ? ? ? ?Arnd
>