From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2630BC433ED for ; Mon, 26 Apr 2021 10:13:16 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F0C06135D for ; Mon, 26 Apr 2021 10:13:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F0C06135D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:To:From:Subject:Cc:Message-Id :Date:Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NUUFaKB22qd7KHhUUnK0OPMV9Adn4aTa2efVnBeQmfI=; b=FP4Le2ElArVP2NDsSnXmq7X0a yvLbctPDzPoK58mEwyn25WSoroBIBoFGVUkCp9gcnaS+JLIJTrw2Stdxu7ymc5EXbTzKiI1ExqshQ W+DiUK/uLexja8E8VCYe6OR2m9MIYxG//teSrcEkhWmDg9z7ExBnmNCutUomVg/nm8yuU3N6B41ZH hg/48HxMH9HdvcPaEm3SG2UxXHPX8NOQpNzE3n4DRVFo0Bv9w/FJ5mexM6FiHQt6tprt2yWYgVpRe KinRjn1vkWJQTp7kZcctq71QP+sLRoAaN7MTITdgpP0oXP9d9Yo/pJqUKRtPYjreXzhafEQ1H2Pau F4BLaY1WQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1layDM-007NjF-2O; Mon, 26 Apr 2021 10:11:40 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1layD1-007Ngy-F5 for linux-arm-kernel@desiato.infradead.org; Mon, 26 Apr 2021 10:11:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:References:To:From: Subject:Cc:Message-Id:Date:Content-Type:Content-Transfer-Encoding: Mime-Version:Sender:Reply-To:Content-ID:Content-Description; bh=6QJuBXRzJn2AF9buhoiLcgCgPyLx4ghe04B214br8tk=; b=uWDhSaAmMRrzzz/DjrceEoypXc 8LQJX3uFyMJfX7RAn5qw+xJ4RfqncMwORgD1V1FR5uqU0yu8s5URuvxMH/57rU87/tWu14CnFuXWl 3odAU65MFZD8lQWJmSDGOI7c03cQ/XNYyMRi3xzVgV5pdeEZYRBfepzJNVmf4wtwHAgBdcye7gxER MX1GXgXpsERyVsn/hqCZ3s1RYEsPqsYnj5+KvhcchAvaHS+43ujMQshtt1rvm8dJ4vhomm+RJp8cL mqaEayNY36wB13ArBgDXfZwaaJ1qPGzlwxk6DhPm+VzfdiUtJGRpZgY8/edKqmp0PH+BiG+kYppRV DqRJv+7g==; Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1layCz-00Ft5U-2z for linux-arm-kernel@lists.infradead.org; Mon, 26 Apr 2021 10:11:18 +0000 Received: by mail-wr1-x429.google.com with SMTP id h15so2980477wre.11 for ; Mon, 26 Apr 2021 03:11:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:content-transfer-encoding:date:message-id:cc:subject :from:to:references:in-reply-to; bh=6QJuBXRzJn2AF9buhoiLcgCgPyLx4ghe04B214br8tk=; b=bmowWUwJPdLle6EVB+jkPN3+4gi1p99iRZVN9vq7P3avoRZQRJ3TsIdOegV46+FQkh go+MXbeLjk2E2rncmkHnArovf1hnt2sn8/pknG4+WXCqX3l0Dv7KR1wqjdpCOJPzfYaA /DtY+4zkL0gDI5tUKgNwjuL921ejoi7/5R5WPzYXvt829R5JWqwXoKQhyKW8y1oCwzAX 4EvueEoFP1U3bEPBXdZvMMJiGavh718lBxN37vrUoVFQF802sZFnxrRYPfs9pcbK2poJ wFiM9cbT1sFp/w2uFyfeFdc4aCqyXcBjXJb0vp+GmM9bcas88qdNY9bWzCLHbW8L12wd wZ0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding:date :message-id:cc:subject:from:to:references:in-reply-to; bh=6QJuBXRzJn2AF9buhoiLcgCgPyLx4ghe04B214br8tk=; b=kF5cta3frpoQTKMbvYt1stwfFbpB32R55Z0MpX64QuZ3/fqjgaPWto5nXcyIp4Cctb vXYHTwLiSoRA3Y1BCkUI6myJjBjmuxxY8Grp+qypkHThNbTj+ErovoXtDT8WbYGwJ0xt 7ol6YxERteNMY4s+cFelHDK8sUBOp21BqGtntDD8hZRQ4GRluhAQG/9jje2g9AxxsFoc I3M+q4o3ykqY3330fF4+pV2pPFm+RpjYIfgfrHJaXGUyWsPsa/NkC6G6ePDMtumGfpWx 2vbb50ykszeOD4ap8XZZv77gVOp0NQ8i/031FCj1BSZB2V3Y1JOB71bjR3Mcvuamj3IR LzuA== X-Gm-Message-State: AOAM530/+e216y97JbDW4Away3ZRDJkbzMAg9U9YYtl5G7/X7hJJdQH8 h3VG6d2YTe9S3vLPgdewVXg= X-Google-Smtp-Source: ABdhPJzDZ3attoVnXeyn+fChhpBJF1lVz+ag12kYIzWsOz4Xclar1aHxa9Q2LuDCRIipxhRncod7dw== X-Received: by 2002:a5d:47cc:: with SMTP id o12mr21898459wrc.227.1619431874480; Mon, 26 Apr 2021 03:11:14 -0700 (PDT) Received: from localhost (a109-49-46-234.cpe.netcabo.pt. [109.49.46.234]) by smtp.gmail.com with ESMTPSA id g6sm7391184wrr.63.2021.04.26.03.11.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Apr 2021 03:11:13 -0700 (PDT) Mime-Version: 1.0 Date: Mon, 26 Apr 2021 11:11:13 +0100 Message-Id: Cc: , , "Fabio Estevam" , "Greg Kroah-Hartman" , "Mauro Carvalho Chehab" , "NXP Linux Team" , "Pengutronix Kernel Team" , "Philipp Zabel" , "Sascha Hauer" , "Shawn Guo" , "Steve Longerbeam" , , , , Subject: Re: [PATCH 14/78] staging: media: imx7-mipi-csis: use pm_runtime_resume_and_get() From: "Rui Miguel Silva" To: "Mauro Carvalho Chehab" References: In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210426_031117_151771_242CFEC0 X-CRM114-Status: GOOD ( 16.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mauro, On Sat Apr 24, 2021 at 7:44 AM WEST, Mauro Carvalho Chehab wrote: > Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") > added pm_runtime_resume_and_get() in order to automatically handle > dev->power.usage_count decrement on errors. > > Use the new API, in order to cleanup the error check logic. > > Signed-off-by: Mauro Carvalho Chehab Thanks, looks good. Acked-by: Rui Miguel Silva ------ Cheers, Rui > --- > drivers/staging/media/imx/imx7-mipi-csis.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c > index 025fdc488bd6..1dc680d94a46 100644 > --- a/drivers/staging/media/imx/imx7-mipi-csis.c > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c > @@ -695,11 +695,10 @@ static int mipi_csis_s_stream(struct v4l2_subdev *mipi_sd, int enable) > > mipi_csis_clear_counters(state); > > - ret = pm_runtime_get_sync(&state->pdev->dev); > - if (ret < 0) { > - pm_runtime_put_noidle(&state->pdev->dev); > + ret = pm_runtime_resume_and_get(&state->pdev->dev); > + if (ret < 0) > return ret; > - } > + > ret = v4l2_subdev_call(state->src_sd, core, s_power, 1); > if (ret < 0 && ret != -ENOIOCTLCMD) > goto done; > -- > 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel