From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08CEBC4707F for ; Tue, 25 May 2021 20:51:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFA7D6140B for ; Tue, 25 May 2021 20:51:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFA7D6140B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Subject:Cc:To: From:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i1TuGgwBETCwB2kpHCTgbfjbkVpM7mFkqKB6v1d9Ouk=; b=CJvr3MrY3Lessf ZN8udIY+pFPNaF+V6ORDjArMZtM9KsOftd85ySNZx0NCzqCpLJQp9CHiirJwuDcK+MQ/EHP7rP9d5 mdOEC6mir8h3KxCwp8uRKaeRRw74rYZ/PAKNNU5+mqNp5TjBH2WNy440/5m+CULxpuOZgA62gEIBq DS9DJ2dpSujBvDqecGZx91V3un++j+UCKh823kHhJAVEqbVOmkKSuq8CmDEqMrE9NtBM5aqKdy7N8 Q01/ynJStV4NuD/tjme3e1ySvBYd/pr3CdsthPlg5Xz/u7HwPi0h3p7kl+c48PNGP6YkxvL/gGNEa ZnmK+v+BqrxzNTFgKx0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lldzM-008EA0-DB; Tue, 25 May 2021 20:49:20 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lldzB-008E6a-7h for linux-arm-kernel@lists.infradead.org; Tue, 25 May 2021 20:49:10 +0000 Received: by mail-wm1-x331.google.com with SMTP id b7so16876482wmh.5 for ; Tue, 25 May 2021 13:49:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:content-transfer-encoding:date:message-id:from:to:cc :subject:references:in-reply-to; bh=jII/VVluno3yfO2v6lRJ0YYluonaqN09SkqoJIS1cfw=; b=fGLl/uDUZ+ISpUMFDUVq4paXMAAcK8ivEawXPm/C/YVAyiEPUTIO2tzCtv8WI2nbrH be5r5SldPYICUq5Ben/JBlbhYCk1mj+/Iqkn5PkmvwfF/2pvyiO4mQR8ElDiVAE7Q2x6 uBDKeUNW9zqpwJpiLRGO5/ZUsuAe/UuTTUcbsiJ87U8BgyO3ofgQdyDIz+3kvdVlHIku YfDHuwpjjV0du9bxq4NCw1htoCpNhoGXeVGYnItCTmoySovuDOFeR32BsYyGp7MS+dbd MlswfwWXIxRGlwyT67DGBj+kmjyoKXPpsf1UVTI2pq8W/p6Lc0Qe/usnZzV51rHkvZ4p C5+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding:date :message-id:from:to:cc:subject:references:in-reply-to; bh=jII/VVluno3yfO2v6lRJ0YYluonaqN09SkqoJIS1cfw=; b=Dg8qeGn6vs1lbNv9stfemNlcm0BPwGkLAqqJC2JCfs4h8y6qJzoiqkm9s3Cnx70QQG KCPQSoh71f8kvAAmJ6YUhKYbSeXtQYunok1mP+rPbz1cUkblknfvqgXk9GMTIblCYJsn JStHKlE5MD163sJ0vEVlhIdZcyQ6fq0J4vgHMRwEDGQn7AXXfByoHdb5qJlDpWxb9gY+ N+WJNEQY0yjP/ELVjFiSclYyjEgsVTtQ1rjfaNiUlEwQd9qVfOy4lpQUYZodBiOPMxRN kOl7nCQ7+yESWs/Tll5U8/6lkmr7bnCtl1M6fYpybAR41jus2T+Bsm7vwt9PnBo/3oxm JTxA== X-Gm-Message-State: AOAM5311/aZtUMDy5Lx3hS2Nn6eDkdwr8H0GeM7NHoI9Ra0uZ+6o1Nm1 A4jiWrPGn/KNBNp1WQbzacA= X-Google-Smtp-Source: ABdhPJzJlfJfIB37PK009nDgE5KqNXiHeyp9sColJ243inXDZKrA09gHbcrlDVRcpswW/LYb8SDsCg== X-Received: by 2002:a05:600c:3795:: with SMTP id o21mr18550555wmr.70.1621975746411; Tue, 25 May 2021 13:49:06 -0700 (PDT) Received: from localhost (a109-49-46-234.cpe.netcabo.pt. [109.49.46.234]) by smtp.gmail.com with ESMTPSA id m11sm11668543wmq.33.2021.05.25.13.49.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 13:49:05 -0700 (PDT) Mime-Version: 1.0 Date: Tue, 25 May 2021 21:49:04 +0100 Message-Id: From: "Rui Miguel Silva" To: "Wei Yongjun" , "Laurent Pinchart" , "Steve Longerbeam" , "Philipp Zabel" , "Mauro Carvalho Chehab" , "Greg Kroah-Hartman" , "Shawn Guo" , "Sascha Hauer" Cc: , , , , "Hulk Robot" Subject: Re: [PATCH -next] media: imx: imx7_mipi_csis: Fix error return code in mipi_csis_async_register() References: <20210524133552.2365248-1-weiyongjun1@huawei.com> In-Reply-To: <20210524133552.2365248-1-weiyongjun1@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210525_134909_298963_56795CAB X-CRM114-Status: GOOD ( 15.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Yongjun, Thanks for the patch. On Mon May 24, 2021 at 2:35 PM WEST, Wei Yongjun wrote: > Fix to return negative error code -EINVAL from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 88fc81388df9 ("media: imx: imx7_mipi_csis: Reject invalid data-lanes settings") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun Looks good to me, thanks. Acked-by: Rui Miguel Silva ------ Cheers, Rui > --- > drivers/staging/media/imx/imx7-mipi-csis.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c > index d573f3475d28..9cd3c86fee58 100644 > --- a/drivers/staging/media/imx/imx7-mipi-csis.c > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c > @@ -1175,6 +1175,7 @@ static int mipi_csis_async_register(struct csi_state *state) > if (vep.bus.mipi_csi2.data_lanes[i] != i + 1) { > dev_err(state->dev, > "data lanes reordering is not supported"); > + ret = -EINVAL; > goto err_parse; > } > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel