* [PATCH 0/3] media: De-stage imx7-mipi-csis.c
@ 2022-02-11 18:02 Jacopo Mondi
2022-02-11 18:02 ` [PATCH 1/3] media: imx: De-stage imx7-mipi-csis Jacopo Mondi
` (2 more replies)
0 siblings, 3 replies; 19+ messages in thread
From: Jacopo Mondi @ 2022-02-11 18:02 UTC (permalink / raw)
To: slongerbeam, p.zabel, shawnguo, s.hauer, festevam, mchehab,
hverkuil-cisco, laurent.pinchart, martin.kepplinger, rmfrfs,
xavier.roumegue
Cc: kernel, linux-imx, linux-media, linux-staging, linux-arm-kernel,
Jacopo Mondi
The imx7-mipi-csis.c driver has no obvious problems and can be destaged.
Move it to a newly created drivers/media/platform/imx directory and plumb
the Kconfig and build system.
To make it more controversial, I'm annoyed by having the SoC identifier in the
driver file name, as the same IP the driver controls is found on i.MX7 as well
as i.MX8 SoCs.
I'm not sure how it will look like when more CSI-2 receiver drivers will be
de-staged. Currently the situation is a bit confusing, but I think, looking at
the compatibles for each driver that it might be doable to remove the SoC
identifiers from driver names (although I'm sure it has been attempted in the
past).
Anyway, I'm mostly interested in 1/3 to be able to move the driver out of
staging and start adding support for other i.MX8 SoC revisions on top.
Series based on the most recent media/master tree.
Thanks
j
Jacopo Mondi (3):
media: imx: De-stage imx7-mipi-csis
media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c
media: imx: Remove reference to i.MX7 from driver
MAINTAINERS | 2 +-
drivers/media/platform/Kconfig | 1 +
drivers/media/platform/Makefile | 1 +
drivers/media/platform/imx/Kconfig | 23 +++++++++++++++++++
drivers/media/platform/imx/Makefile | 1 +
.../platform/imx/imx-mipi-csis.c} | 10 +++++---
drivers/staging/media/imx/Makefile | 1 -
7 files changed, 34 insertions(+), 5 deletions(-)
create mode 100644 drivers/media/platform/imx/Kconfig
create mode 100644 drivers/media/platform/imx/Makefile
rename drivers/{staging/media/imx/imx7-mipi-csis.c => media/platform/imx/imx-mipi-csis.c} (99%)
--
2.35.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 1/3] media: imx: De-stage imx7-mipi-csis 2022-02-11 18:02 [PATCH 0/3] media: De-stage imx7-mipi-csis.c Jacopo Mondi @ 2022-02-11 18:02 ` Jacopo Mondi 2022-02-11 18:32 ` Fabio Estevam ` (2 more replies) 2022-02-11 18:02 ` [PATCH 2/3] media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c Jacopo Mondi 2022-02-11 18:02 ` [PATCH 3/3] media: imx: Remove reference to i.MX7 from driver Jacopo Mondi 2 siblings, 3 replies; 19+ messages in thread From: Jacopo Mondi @ 2022-02-11 18:02 UTC (permalink / raw) To: slongerbeam, p.zabel, shawnguo, s.hauer, festevam, mchehab, hverkuil-cisco, laurent.pinchart, martin.kepplinger, rmfrfs, xavier.roumegue Cc: kernel, linux-imx, linux-media, linux-staging, linux-arm-kernel, Jacopo Mondi The imx7-mipi-csis driver is in a good state and can be staged. Move the imx7-mipi-csis.c driver to the newly created drivers/media/platform/imx directory and plumb the related options in Kconfig and in Makefile. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- MAINTAINERS | 2 +- drivers/media/platform/Kconfig | 1 + drivers/media/platform/Makefile | 1 + drivers/media/platform/imx/Kconfig | 23 +++++++++++++++++++ drivers/media/platform/imx/Makefile | 1 + .../platform}/imx/imx7-mipi-csis.c | 0 drivers/staging/media/imx/Makefile | 1 - 7 files changed, 27 insertions(+), 2 deletions(-) create mode 100644 drivers/media/platform/imx/Kconfig create mode 100644 drivers/media/platform/imx/Makefile rename drivers/{staging/media => media/platform}/imx/imx7-mipi-csis.c (100%) diff --git a/MAINTAINERS b/MAINTAINERS index 83d27b57016f..5bdb8c881b0b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11891,8 +11891,8 @@ T: git git://linuxtv.org/media_tree.git F: Documentation/admin-guide/media/imx7.rst F: Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml F: Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml +F: drivers/media/platform/imx/imx7-mipi-csis.c F: drivers/staging/media/imx/imx7-media-csi.c -F: drivers/staging/media/imx/imx7-mipi-csis.c MEDIA DRIVERS FOR HELENE M: Abylay Ospan <aospan@netup.ru> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index 9fbdba0fd1e7..d9eeccffea69 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -171,6 +171,7 @@ source "drivers/media/platform/xilinx/Kconfig" source "drivers/media/platform/rcar-vin/Kconfig" source "drivers/media/platform/atmel/Kconfig" source "drivers/media/platform/sunxi/Kconfig" +source "drivers/media/platform/imx/Kconfig" config VIDEO_TI_CAL tristate "TI CAL (Camera Adaptation Layer) driver" diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile index 28eb4aadbf45..a9466c854610 100644 --- a/drivers/media/platform/Makefile +++ b/drivers/media/platform/Makefile @@ -20,6 +20,7 @@ obj-y += ti-vpe/ obj-$(CONFIG_VIDEO_MX2_EMMAPRP) += mx2_emmaprp.o obj-$(CONFIG_VIDEO_CODA) += coda/ +obj-$(CONFIG_VIDEO_IMX) += imx/ obj-$(CONFIG_VIDEO_IMX_PXP) += imx-pxp.o obj-$(CONFIG_VIDEO_IMX8_JPEG) += imx-jpeg/ diff --git a/drivers/media/platform/imx/Kconfig b/drivers/media/platform/imx/Kconfig new file mode 100644 index 000000000000..0cf35733040c --- /dev/null +++ b/drivers/media/platform/imx/Kconfig @@ -0,0 +1,23 @@ +# SPDX-License-Identifier: GPL-2.0-only + +menuconfig VIDEO_IMX + bool "V4L2 capture drivers for NXP i.MX devices" + depends on VIDEO_DEV && VIDEO_V4L2 && (ARCH_MXC || COMPILE_TEST) + help + Say yes here to enable support for capture drivers on i.MX SoCs. + Support for the single SoC features are selectable in the sub-menu + options. + +if VIDEO_IMX + +config VIDEO_IMX_MIPI_CSIS + tristate "MIPI CSI-2 CSIS receiver found on i.MX7 and i.MX8 models" + select MEDIA_CONTROLLER + select V4L2_FWNODE + select VIDEO_V4L2_SUBDEV_API + default n + help + Video4Linux2 sub-device driver for the MIPI CSI-2 CSIS receiver + v3.3/v3.6 found on some i.MX7 and i.MX8 SoCs. + +endif # VIDEO_IMX diff --git a/drivers/media/platform/imx/Makefile b/drivers/media/platform/imx/Makefile new file mode 100644 index 000000000000..ee272234c8d7 --- /dev/null +++ b/drivers/media/platform/imx/Makefile @@ -0,0 +1 @@ +obj-$(CONFIG_VIDEO_IMX_MIPI_CSIS) += imx7-mipi-csis.o diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/media/platform/imx/imx7-mipi-csis.c similarity index 100% rename from drivers/staging/media/imx/imx7-mipi-csis.c rename to drivers/media/platform/imx/imx7-mipi-csis.c diff --git a/drivers/staging/media/imx/Makefile b/drivers/staging/media/imx/Makefile index 19c2fc54d424..d82be898145b 100644 --- a/drivers/staging/media/imx/Makefile +++ b/drivers/staging/media/imx/Makefile @@ -15,5 +15,4 @@ obj-$(CONFIG_VIDEO_IMX_CSI) += imx6-media-csi.o obj-$(CONFIG_VIDEO_IMX_CSI) += imx6-mipi-csi2.o obj-$(CONFIG_VIDEO_IMX7_CSI) += imx7-media-csi.o -obj-$(CONFIG_VIDEO_IMX7_CSI) += imx7-mipi-csis.o obj-$(CONFIG_VIDEO_IMX7_CSI) += imx8mq-mipi-csi2.o -- 2.35.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 1/3] media: imx: De-stage imx7-mipi-csis 2022-02-11 18:02 ` [PATCH 1/3] media: imx: De-stage imx7-mipi-csis Jacopo Mondi @ 2022-02-11 18:32 ` Fabio Estevam 2022-02-11 20:21 ` Laurent Pinchart 2022-02-14 9:23 ` Jacopo Mondi 2022-02-11 20:40 ` Laurent Pinchart 2022-02-14 9:43 ` (EXT) " Alexander Stein 2 siblings, 2 replies; 19+ messages in thread From: Fabio Estevam @ 2022-02-11 18:32 UTC (permalink / raw) To: Jacopo Mondi Cc: Steve Longerbeam, Philipp Zabel, Shawn Guo, Sascha Hauer, Mauro Carvalho Chehab, Hans Verkuil, Laurent Pinchart, Martin Kepplinger, Rui Miguel Silva, xavier.roumegue, Sascha Hauer, NXP Linux Team, linux-media, open list:STAGING SUBSYSTEM, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE Hi Jacopo, On Fri, Feb 11, 2022 at 3:01 PM Jacopo Mondi <jacopo@jmondi.org> wrote: > > The imx7-mipi-csis driver is in a good state and can be staged. I think you meant de-staged :-) > Move the imx7-mipi-csis.c driver to the newly created > drivers/media/platform/imx directory and plumb the related > options in Kconfig and in Makefile. What about the comments in drivers/staging/media/imx/TODO? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/3] media: imx: De-stage imx7-mipi-csis 2022-02-11 18:32 ` Fabio Estevam @ 2022-02-11 20:21 ` Laurent Pinchart 2022-02-14 9:23 ` Jacopo Mondi 1 sibling, 0 replies; 19+ messages in thread From: Laurent Pinchart @ 2022-02-11 20:21 UTC (permalink / raw) To: Fabio Estevam Cc: Jacopo Mondi, Steve Longerbeam, Philipp Zabel, Shawn Guo, Sascha Hauer, Mauro Carvalho Chehab, Hans Verkuil, Martin Kepplinger, Rui Miguel Silva, xavier.roumegue, Sascha Hauer, NXP Linux Team, linux-media, open list:STAGING SUBSYSTEM, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE Hi Fabio, On Fri, Feb 11, 2022 at 03:32:31PM -0300, Fabio Estevam wrote: > On Fri, Feb 11, 2022 at 3:01 PM Jacopo Mondi wrote: > > > > The imx7-mipi-csis driver is in a good state and can be staged. > > I think you meant de-staged :-) > > > Move the imx7-mipi-csis.c driver to the newly created > > drivers/media/platform/imx directory and plumb the related > > options in Kconfig and in Makefile. > > What about the comments in drivers/staging/media/imx/TODO? As far as I can tell, they apply to the other drivers, not this one. Is there any particular comment you're concerned about ? -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/3] media: imx: De-stage imx7-mipi-csis 2022-02-11 18:32 ` Fabio Estevam 2022-02-11 20:21 ` Laurent Pinchart @ 2022-02-14 9:23 ` Jacopo Mondi 2022-02-14 11:40 ` Fabio Estevam 1 sibling, 1 reply; 19+ messages in thread From: Jacopo Mondi @ 2022-02-14 9:23 UTC (permalink / raw) To: Fabio Estevam Cc: Steve Longerbeam, Philipp Zabel, Shawn Guo, Sascha Hauer, Mauro Carvalho Chehab, Hans Verkuil, Laurent Pinchart, Martin Kepplinger, Rui Miguel Silva, xavier.roumegue, Sascha Hauer, NXP Linux Team, linux-media, open list:STAGING SUBSYSTEM, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE Hi Fabio On Fri, Feb 11, 2022 at 03:32:31PM -0300, Fabio Estevam wrote: > Hi Jacopo, > > On Fri, Feb 11, 2022 at 3:01 PM Jacopo Mondi <jacopo@jmondi.org> wrote: > > > > The imx7-mipi-csis driver is in a good state and can be staged. > > I think you meant de-staged :-) > Indeed :) > > Move the imx7-mipi-csis.c driver to the newly created > > drivers/media/platform/imx directory and plumb the related > > options in Kconfig and in Makefile. > > What about the comments in drivers/staging/media/imx/TODO? I found nothing there that applies to this driver. Have I missed any point ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/3] media: imx: De-stage imx7-mipi-csis 2022-02-14 9:23 ` Jacopo Mondi @ 2022-02-14 11:40 ` Fabio Estevam 0 siblings, 0 replies; 19+ messages in thread From: Fabio Estevam @ 2022-02-14 11:40 UTC (permalink / raw) To: Jacopo Mondi Cc: Steve Longerbeam, Philipp Zabel, Shawn Guo, Sascha Hauer, Mauro Carvalho Chehab, Hans Verkuil, Laurent Pinchart, Martin Kepplinger, Rui Miguel Silva, xavier.roumegue, Sascha Hauer, NXP Linux Team, linux-media, open list:STAGING SUBSYSTEM, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE Hi Jacopo, On Mon, Feb 14, 2022 at 6:22 AM Jacopo Mondi <jacopo@jmondi.org> wrote: > I found nothing there that applies to this driver. > Have I missed any point ? You are right. After reading the comments in the TODO I see it does not apply to this driver. Sorry about the noise. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/3] media: imx: De-stage imx7-mipi-csis 2022-02-11 18:02 ` [PATCH 1/3] media: imx: De-stage imx7-mipi-csis Jacopo Mondi 2022-02-11 18:32 ` Fabio Estevam @ 2022-02-11 20:40 ` Laurent Pinchart 2022-02-14 9:43 ` (EXT) " Alexander Stein 2 siblings, 0 replies; 19+ messages in thread From: Laurent Pinchart @ 2022-02-11 20:40 UTC (permalink / raw) To: Jacopo Mondi Cc: slongerbeam, p.zabel, shawnguo, s.hauer, festevam, mchehab, hverkuil-cisco, martin.kepplinger, rmfrfs, xavier.roumegue, kernel, linux-imx, linux-media, linux-staging, linux-arm-kernel Hi Jacopo, Thank you for the patch. On Fri, Feb 11, 2022 at 07:02:14PM +0100, Jacopo Mondi wrote: > The imx7-mipi-csis driver is in a good state and can be staged. > > Move the imx7-mipi-csis.c driver to the newly created > drivers/media/platform/imx directory and plumb the related > options in Kconfig and in Makefile. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > MAINTAINERS | 2 +- > drivers/media/platform/Kconfig | 1 + > drivers/media/platform/Makefile | 1 + > drivers/media/platform/imx/Kconfig | 23 +++++++++++++++++++ > drivers/media/platform/imx/Makefile | 1 + > .../platform}/imx/imx7-mipi-csis.c | 0 > drivers/staging/media/imx/Makefile | 1 - > 7 files changed, 27 insertions(+), 2 deletions(-) > create mode 100644 drivers/media/platform/imx/Kconfig > create mode 100644 drivers/media/platform/imx/Makefile > rename drivers/{staging/media => media/platform}/imx/imx7-mipi-csis.c (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 83d27b57016f..5bdb8c881b0b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11891,8 +11891,8 @@ T: git git://linuxtv.org/media_tree.git > F: Documentation/admin-guide/media/imx7.rst > F: Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml > F: Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml > +F: drivers/media/platform/imx/imx7-mipi-csis.c > F: drivers/staging/media/imx/imx7-media-csi.c > -F: drivers/staging/media/imx/imx7-mipi-csis.c > > MEDIA DRIVERS FOR HELENE > M: Abylay Ospan <aospan@netup.ru> > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > index 9fbdba0fd1e7..d9eeccffea69 100644 > --- a/drivers/media/platform/Kconfig > +++ b/drivers/media/platform/Kconfig > @@ -171,6 +171,7 @@ source "drivers/media/platform/xilinx/Kconfig" > source "drivers/media/platform/rcar-vin/Kconfig" > source "drivers/media/platform/atmel/Kconfig" > source "drivers/media/platform/sunxi/Kconfig" > +source "drivers/media/platform/imx/Kconfig" One day I'll order all this alphabetically. > > config VIDEO_TI_CAL > tristate "TI CAL (Camera Adaptation Layer) driver" > diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile > index 28eb4aadbf45..a9466c854610 100644 > --- a/drivers/media/platform/Makefile > +++ b/drivers/media/platform/Makefile > @@ -20,6 +20,7 @@ obj-y += ti-vpe/ > obj-$(CONFIG_VIDEO_MX2_EMMAPRP) += mx2_emmaprp.o > obj-$(CONFIG_VIDEO_CODA) += coda/ > > +obj-$(CONFIG_VIDEO_IMX) += imx/ > obj-$(CONFIG_VIDEO_IMX_PXP) += imx-pxp.o > obj-$(CONFIG_VIDEO_IMX8_JPEG) += imx-jpeg/ No in this series, but it would be nice to move those drivers to imx/ one day. > diff --git a/drivers/media/platform/imx/Kconfig b/drivers/media/platform/imx/Kconfig > new file mode 100644 > index 000000000000..0cf35733040c > --- /dev/null > +++ b/drivers/media/platform/imx/Kconfig > @@ -0,0 +1,23 @@ > +# SPDX-License-Identifier: GPL-2.0-only > + > +menuconfig VIDEO_IMX > + bool "V4L2 capture drivers for NXP i.MX devices" > + depends on VIDEO_DEV && VIDEO_V4L2 && (ARCH_MXC || COMPILE_TEST) It's quite common to list the platform dependencies separately: depends on ARCH_MXC || COMPILE_TEST depends on VIDEO_DEV && VIDEO_V4L2 Up to you. > + help > + Say yes here to enable support for capture drivers on i.MX SoCs. > + Support for the single SoC features are selectable in the sub-menu > + options. > + > +if VIDEO_IMX > + > +config VIDEO_IMX_MIPI_CSIS > + tristate "MIPI CSI-2 CSIS receiver found on i.MX7 and i.MX8 models" > + select MEDIA_CONTROLLER > + select V4L2_FWNODE > + select VIDEO_V4L2_SUBDEV_API > + default n > + help > + Video4Linux2 sub-device driver for the MIPI CSI-2 CSIS receiver > + v3.3/v3.6 found on some i.MX7 and i.MX8 SoCs. The latter is v3.6.3. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > + > +endif # VIDEO_IMX > diff --git a/drivers/media/platform/imx/Makefile b/drivers/media/platform/imx/Makefile > new file mode 100644 > index 000000000000..ee272234c8d7 > --- /dev/null > +++ b/drivers/media/platform/imx/Makefile > @@ -0,0 +1 @@ > +obj-$(CONFIG_VIDEO_IMX_MIPI_CSIS) += imx7-mipi-csis.o > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/media/platform/imx/imx7-mipi-csis.c > similarity index 100% > rename from drivers/staging/media/imx/imx7-mipi-csis.c > rename to drivers/media/platform/imx/imx7-mipi-csis.c > diff --git a/drivers/staging/media/imx/Makefile b/drivers/staging/media/imx/Makefile > index 19c2fc54d424..d82be898145b 100644 > --- a/drivers/staging/media/imx/Makefile > +++ b/drivers/staging/media/imx/Makefile > @@ -15,5 +15,4 @@ obj-$(CONFIG_VIDEO_IMX_CSI) += imx6-media-csi.o > obj-$(CONFIG_VIDEO_IMX_CSI) += imx6-mipi-csi2.o > > obj-$(CONFIG_VIDEO_IMX7_CSI) += imx7-media-csi.o > -obj-$(CONFIG_VIDEO_IMX7_CSI) += imx7-mipi-csis.o > obj-$(CONFIG_VIDEO_IMX7_CSI) += imx8mq-mipi-csi2.o -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: (EXT) [PATCH 1/3] media: imx: De-stage imx7-mipi-csis 2022-02-11 18:02 ` [PATCH 1/3] media: imx: De-stage imx7-mipi-csis Jacopo Mondi 2022-02-11 18:32 ` Fabio Estevam 2022-02-11 20:40 ` Laurent Pinchart @ 2022-02-14 9:43 ` Alexander Stein 2022-02-14 9:51 ` Laurent Pinchart 2 siblings, 1 reply; 19+ messages in thread From: Alexander Stein @ 2022-02-14 9:43 UTC (permalink / raw) To: laurent.pinchart, Jacopo Mondi Cc: slongerbeam, p.zabel, shawnguo, s.hauer, festevam, mchehab, hverkuil-cisco, martin.kepplinger, rmfrfs, xavier.roumegue, linux-arm-kernel, kernel, linux-imx, linux-media, linux-staging, linux-arm-kernel, Jacopo Mondi Am Freitag, 11. Februar 2022, 19:02:14 CET schrieb Jacopo Mondi: > The imx7-mipi-csis driver is in a good state and can be staged. > > Move the imx7-mipi-csis.c driver to the newly created > drivers/media/platform/imx directory and plumb the related > options in Kconfig and in Makefile. Please note that there is (at least) one pending patch at [1] which is crucial for my setup. Also what about calculation for clk_settle in mipi_csis_calculate_params()? Is it really ok to leave it at 0? Despite that I can't say if that driver is ready to be moved out of staging or not. Laurent, do you have any preference in which order they should be applied? Regards, Alexander [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/ 20220211142752.779952-6-alexander.stein@ew.tq-group.com/ > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > MAINTAINERS | 2 +- > drivers/media/platform/Kconfig | 1 + > drivers/media/platform/Makefile | 1 + > drivers/media/platform/imx/Kconfig | 23 +++++++++++++++++++ > drivers/media/platform/imx/Makefile | 1 + > .../platform}/imx/imx7-mipi-csis.c | 0 > drivers/staging/media/imx/Makefile | 1 - > 7 files changed, 27 insertions(+), 2 deletions(-) > create mode 100644 drivers/media/platform/imx/Kconfig > create mode 100644 drivers/media/platform/imx/Makefile > rename drivers/{staging/media => media/platform}/imx/imx7-mipi-csis.c > (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 83d27b57016f..5bdb8c881b0b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11891,8 +11891,8 @@ T: git git://linuxtv.org/media_tree.git > F: Documentation/admin-guide/media/imx7.rst > F: Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml > F: Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml > +F: drivers/media/platform/imx/imx7-mipi-csis.c > F: drivers/staging/media/imx/imx7-media-csi.c > -F: drivers/staging/media/imx/imx7-mipi-csis.c > > MEDIA DRIVERS FOR HELENE > M: Abylay Ospan <aospan@netup.ru> > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > index 9fbdba0fd1e7..d9eeccffea69 100644 > --- a/drivers/media/platform/Kconfig > +++ b/drivers/media/platform/Kconfig > @@ -171,6 +171,7 @@ source "drivers/media/platform/xilinx/Kconfig" > source "drivers/media/platform/rcar-vin/Kconfig" > source "drivers/media/platform/atmel/Kconfig" > source "drivers/media/platform/sunxi/Kconfig" > +source "drivers/media/platform/imx/Kconfig" > > config VIDEO_TI_CAL > tristate "TI CAL (Camera Adaptation Layer) driver" > diff --git a/drivers/media/platform/Makefile > b/drivers/media/platform/Makefile index 28eb4aadbf45..a9466c854610 100644 > --- a/drivers/media/platform/Makefile > +++ b/drivers/media/platform/Makefile > @@ -20,6 +20,7 @@ obj-y += ti-vpe/ > obj-$(CONFIG_VIDEO_MX2_EMMAPRP) += mx2_emmaprp.o > obj-$(CONFIG_VIDEO_CODA) += coda/ > > +obj-$(CONFIG_VIDEO_IMX) += imx/ > obj-$(CONFIG_VIDEO_IMX_PXP) += imx-pxp.o > obj-$(CONFIG_VIDEO_IMX8_JPEG) += imx-jpeg/ > > diff --git a/drivers/media/platform/imx/Kconfig > b/drivers/media/platform/imx/Kconfig new file mode 100644 > index 000000000000..0cf35733040c > --- /dev/null > +++ b/drivers/media/platform/imx/Kconfig > @@ -0,0 +1,23 @@ > +# SPDX-License-Identifier: GPL-2.0-only > + > +menuconfig VIDEO_IMX > + bool "V4L2 capture drivers for NXP i.MX devices" > + depends on VIDEO_DEV && VIDEO_V4L2 && (ARCH_MXC || COMPILE_TEST) > + help > + Say yes here to enable support for capture drivers on i.MX SoCs. > + Support for the single SoC features are selectable in the sub- menu > + options. > + > +if VIDEO_IMX > + > +config VIDEO_IMX_MIPI_CSIS > + tristate "MIPI CSI-2 CSIS receiver found on i.MX7 and i.MX8 models" > + select MEDIA_CONTROLLER > + select V4L2_FWNODE > + select VIDEO_V4L2_SUBDEV_API > + default n > + help > + Video4Linux2 sub-device driver for the MIPI CSI-2 CSIS receiver > + v3.3/v3.6 found on some i.MX7 and i.MX8 SoCs. > + > +endif # VIDEO_IMX > diff --git a/drivers/media/platform/imx/Makefile > b/drivers/media/platform/imx/Makefile new file mode 100644 > index 000000000000..ee272234c8d7 > --- /dev/null > +++ b/drivers/media/platform/imx/Makefile > @@ -0,0 +1 @@ > +obj-$(CONFIG_VIDEO_IMX_MIPI_CSIS) += imx7-mipi-csis.o > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c > b/drivers/media/platform/imx/imx7-mipi-csis.c similarity index 100% > rename from drivers/staging/media/imx/imx7-mipi-csis.c > rename to drivers/media/platform/imx/imx7-mipi-csis.c > diff --git a/drivers/staging/media/imx/Makefile > b/drivers/staging/media/imx/Makefile index 19c2fc54d424..d82be898145b > 100644 > --- a/drivers/staging/media/imx/Makefile > +++ b/drivers/staging/media/imx/Makefile > @@ -15,5 +15,4 @@ obj-$(CONFIG_VIDEO_IMX_CSI) += imx6-media-csi.o > obj-$(CONFIG_VIDEO_IMX_CSI) += imx6-mipi-csi2.o > > obj-$(CONFIG_VIDEO_IMX7_CSI) += imx7-media-csi.o > -obj-$(CONFIG_VIDEO_IMX7_CSI) += imx7-mipi-csis.o > obj-$(CONFIG_VIDEO_IMX7_CSI) += imx8mq-mipi-csi2.o _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: (EXT) [PATCH 1/3] media: imx: De-stage imx7-mipi-csis 2022-02-14 9:43 ` (EXT) " Alexander Stein @ 2022-02-14 9:51 ` Laurent Pinchart 0 siblings, 0 replies; 19+ messages in thread From: Laurent Pinchart @ 2022-02-14 9:51 UTC (permalink / raw) To: Alexander Stein Cc: Jacopo Mondi, slongerbeam, p.zabel, shawnguo, s.hauer, festevam, mchehab, hverkuil-cisco, martin.kepplinger, rmfrfs, xavier.roumegue, linux-arm-kernel, kernel, linux-imx, linux-media, linux-staging Hi Alexander, On Mon, Feb 14, 2022 at 10:43:59AM +0100, Alexander Stein wrote: > Am Freitag, 11. Februar 2022, 19:02:14 CET schrieb Jacopo Mondi: > > The imx7-mipi-csis driver is in a good state and can be staged. > > > > Move the imx7-mipi-csis.c driver to the newly created > > drivers/media/platform/imx directory and plumb the related > > options in Kconfig and in Makefile. > > Please note that there is (at least) one pending patch at [1] which is crucial > for my setup. > > Also what about calculation for clk_settle in mipi_csis_calculate_params()? Is > it really ok to leave it at 0? It should ideally be computed based on the timing parameters of the transmitter, but until we figure out how to do so, I don't think it blocks de-staging the driver. Moving to drivers/media/ doesn't mean everything has to be perfect, we can continue improving the driver after the move. > Despite that I can't say if that driver is ready to be moved out of staging or > not. > > Laurent, do you have any preference in which order they should be applied? Not really, I'm fine with either order. > [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/ > 20220211142752.779952-6-alexander.stein@ew.tq-group.com/ > > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > > --- > > MAINTAINERS | 2 +- > > drivers/media/platform/Kconfig | 1 + > > drivers/media/platform/Makefile | 1 + > > drivers/media/platform/imx/Kconfig | 23 +++++++++++++++++++ > > drivers/media/platform/imx/Makefile | 1 + > > .../platform}/imx/imx7-mipi-csis.c | 0 > > drivers/staging/media/imx/Makefile | 1 - > > 7 files changed, 27 insertions(+), 2 deletions(-) > > create mode 100644 drivers/media/platform/imx/Kconfig > > create mode 100644 drivers/media/platform/imx/Makefile > > rename drivers/{staging/media => media/platform}/imx/imx7-mipi-csis.c > > (100%) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 83d27b57016f..5bdb8c881b0b 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -11891,8 +11891,8 @@ T: git git://linuxtv.org/media_tree.git > > F: Documentation/admin-guide/media/imx7.rst > > F: Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml > > F: Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml > > +F: drivers/media/platform/imx/imx7-mipi-csis.c > > F: drivers/staging/media/imx/imx7-media-csi.c > > -F: drivers/staging/media/imx/imx7-mipi-csis.c > > > > MEDIA DRIVERS FOR HELENE > > M: Abylay Ospan <aospan@netup.ru> > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > > index 9fbdba0fd1e7..d9eeccffea69 100644 > > --- a/drivers/media/platform/Kconfig > > +++ b/drivers/media/platform/Kconfig > > @@ -171,6 +171,7 @@ source "drivers/media/platform/xilinx/Kconfig" > > source "drivers/media/platform/rcar-vin/Kconfig" > > source "drivers/media/platform/atmel/Kconfig" > > source "drivers/media/platform/sunxi/Kconfig" > > +source "drivers/media/platform/imx/Kconfig" > > > > config VIDEO_TI_CAL > > tristate "TI CAL (Camera Adaptation Layer) driver" > > diff --git a/drivers/media/platform/Makefile > > b/drivers/media/platform/Makefile index 28eb4aadbf45..a9466c854610 100644 > > --- a/drivers/media/platform/Makefile > > +++ b/drivers/media/platform/Makefile > > @@ -20,6 +20,7 @@ obj-y += ti-vpe/ > > obj-$(CONFIG_VIDEO_MX2_EMMAPRP) += mx2_emmaprp.o > > obj-$(CONFIG_VIDEO_CODA) += coda/ > > > > +obj-$(CONFIG_VIDEO_IMX) += imx/ > > obj-$(CONFIG_VIDEO_IMX_PXP) += imx-pxp.o > > obj-$(CONFIG_VIDEO_IMX8_JPEG) += imx-jpeg/ > > > > diff --git a/drivers/media/platform/imx/Kconfig > > b/drivers/media/platform/imx/Kconfig new file mode 100644 > > index 000000000000..0cf35733040c > > --- /dev/null > > +++ b/drivers/media/platform/imx/Kconfig > > @@ -0,0 +1,23 @@ > > +# SPDX-License-Identifier: GPL-2.0-only > > + > > +menuconfig VIDEO_IMX > > + bool "V4L2 capture drivers for NXP i.MX devices" > > + depends on VIDEO_DEV && VIDEO_V4L2 && (ARCH_MXC || COMPILE_TEST) > > + help > > + Say yes here to enable support for capture drivers on i.MX SoCs. > > + Support for the single SoC features are selectable in the sub- > menu > > + options. > > + > > +if VIDEO_IMX > > + > > +config VIDEO_IMX_MIPI_CSIS > > + tristate "MIPI CSI-2 CSIS receiver found on i.MX7 and i.MX8 models" > > + select MEDIA_CONTROLLER > > + select V4L2_FWNODE > > + select VIDEO_V4L2_SUBDEV_API > > + default n > > + help > > + Video4Linux2 sub-device driver for the MIPI CSI-2 CSIS receiver > > + v3.3/v3.6 found on some i.MX7 and i.MX8 SoCs. > > + > > +endif # VIDEO_IMX > > diff --git a/drivers/media/platform/imx/Makefile > > b/drivers/media/platform/imx/Makefile new file mode 100644 > > index 000000000000..ee272234c8d7 > > --- /dev/null > > +++ b/drivers/media/platform/imx/Makefile > > @@ -0,0 +1 @@ > > +obj-$(CONFIG_VIDEO_IMX_MIPI_CSIS) += imx7-mipi-csis.o > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c > > b/drivers/media/platform/imx/imx7-mipi-csis.c similarity index 100% > > rename from drivers/staging/media/imx/imx7-mipi-csis.c > > rename to drivers/media/platform/imx/imx7-mipi-csis.c > > diff --git a/drivers/staging/media/imx/Makefile > > b/drivers/staging/media/imx/Makefile index 19c2fc54d424..d82be898145b > > 100644 > > --- a/drivers/staging/media/imx/Makefile > > +++ b/drivers/staging/media/imx/Makefile > > @@ -15,5 +15,4 @@ obj-$(CONFIG_VIDEO_IMX_CSI) += imx6-media-csi.o > > obj-$(CONFIG_VIDEO_IMX_CSI) += imx6-mipi-csi2.o > > > > obj-$(CONFIG_VIDEO_IMX7_CSI) += imx7-media-csi.o > > -obj-$(CONFIG_VIDEO_IMX7_CSI) += imx7-mipi-csis.o > > obj-$(CONFIG_VIDEO_IMX7_CSI) += imx8mq-mipi-csi2.o -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 2/3] media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c 2022-02-11 18:02 [PATCH 0/3] media: De-stage imx7-mipi-csis.c Jacopo Mondi 2022-02-11 18:02 ` [PATCH 1/3] media: imx: De-stage imx7-mipi-csis Jacopo Mondi @ 2022-02-11 18:02 ` Jacopo Mondi 2022-02-11 20:42 ` Laurent Pinchart ` (3 more replies) 2022-02-11 18:02 ` [PATCH 3/3] media: imx: Remove reference to i.MX7 from driver Jacopo Mondi 2 siblings, 4 replies; 19+ messages in thread From: Jacopo Mondi @ 2022-02-11 18:02 UTC (permalink / raw) To: slongerbeam, p.zabel, shawnguo, s.hauer, festevam, mchehab, hverkuil-cisco, laurent.pinchart, martin.kepplinger, rmfrfs, xavier.roumegue Cc: kernel, linux-imx, linux-media, linux-staging, linux-arm-kernel, Jacopo Mondi Rename the imx7-mipi-csis.c driver to remove the reference to i.MX7. The driver is for an IP core found on i.MX7 and i.MX8 SoC so do not specify a SoC version number in the driver name. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- MAINTAINERS | 2 +- .../media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename drivers/media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} (100%) diff --git a/MAINTAINERS b/MAINTAINERS index 5bdb8c881b0b..7def3b7d56bc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11891,7 +11891,7 @@ T: git git://linuxtv.org/media_tree.git F: Documentation/admin-guide/media/imx7.rst F: Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml F: Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml -F: drivers/media/platform/imx/imx7-mipi-csis.c +F: drivers/media/platform/imx/imx-mipi-csis.c F: drivers/staging/media/imx/imx7-media-csi.c MEDIA DRIVERS FOR HELENE diff --git a/drivers/media/platform/imx/imx7-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c similarity index 100% rename from drivers/media/platform/imx/imx7-mipi-csis.c rename to drivers/media/platform/imx/imx-mipi-csis.c -- 2.35.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c 2022-02-11 18:02 ` [PATCH 2/3] media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c Jacopo Mondi @ 2022-02-11 20:42 ` Laurent Pinchart 2022-02-14 10:28 ` Rui Miguel Silva 2022-02-11 22:15 ` kernel test robot ` (2 subsequent siblings) 3 siblings, 1 reply; 19+ messages in thread From: Laurent Pinchart @ 2022-02-11 20:42 UTC (permalink / raw) To: Jacopo Mondi Cc: slongerbeam, p.zabel, shawnguo, s.hauer, festevam, mchehab, hverkuil-cisco, martin.kepplinger, rmfrfs, xavier.roumegue, kernel, linux-imx, linux-media, linux-staging, linux-arm-kernel Hi Jacopo, Thank you for the patch. On Fri, Feb 11, 2022 at 07:02:15PM +0100, Jacopo Mondi wrote: > Rename the imx7-mipi-csis.c driver to remove the reference to i.MX7. > > The driver is for an IP core found on i.MX7 and i.MX8 SoC so do not > specify a SoC version number in the driver name. I'm not against this, but I think we should then rename the symbols in the source code too. I don't mind keeping the current name if the rename causes too much churn. > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > MAINTAINERS | 2 +- > .../media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename drivers/media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 5bdb8c881b0b..7def3b7d56bc 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11891,7 +11891,7 @@ T: git git://linuxtv.org/media_tree.git > F: Documentation/admin-guide/media/imx7.rst > F: Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml > F: Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml > -F: drivers/media/platform/imx/imx7-mipi-csis.c > +F: drivers/media/platform/imx/imx-mipi-csis.c > F: drivers/staging/media/imx/imx7-media-csi.c > > MEDIA DRIVERS FOR HELENE > diff --git a/drivers/media/platform/imx/imx7-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c > similarity index 100% > rename from drivers/media/platform/imx/imx7-mipi-csis.c > rename to drivers/media/platform/imx/imx-mipi-csis.c -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c 2022-02-11 20:42 ` Laurent Pinchart @ 2022-02-14 10:28 ` Rui Miguel Silva 0 siblings, 0 replies; 19+ messages in thread From: Rui Miguel Silva @ 2022-02-14 10:28 UTC (permalink / raw) To: Laurent Pinchart, Jacopo Mondi Cc: slongerbeam, p.zabel, shawnguo, s.hauer, festevam, mchehab, hverkuil-cisco, martin.kepplinger, xavier.roumegue, kernel, linux-imx, linux-media, linux-staging, linux-arm-kernel Hi Laurent, On Fri Feb 11, 2022 at 8:42 PM WET, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Fri, Feb 11, 2022 at 07:02:15PM +0100, Jacopo Mondi wrote: > > Rename the imx7-mipi-csis.c driver to remove the reference to i.MX7. > > > > The driver is for an IP core found on i.MX7 and i.MX8 SoC so do not > > specify a SoC version number in the driver name. > > I'm not against this, but I think we should then rename the symbols in > the source code too. I don't mind keeping the current name if the rename > causes too much churn. I think Jacopo does that in the 3/3 patch in the source and I think he cover all, since the main symbols namespace is mipi_csis and do not include imx7 specifically. Cheers, Rui > > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > > --- > > MAINTAINERS | 2 +- > > .../media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} | 0 > > 2 files changed, 1 insertion(+), 1 deletion(-) > > rename drivers/media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} (100%) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 5bdb8c881b0b..7def3b7d56bc 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -11891,7 +11891,7 @@ T: git git://linuxtv.org/media_tree.git > > F: Documentation/admin-guide/media/imx7.rst > > F: Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml > > F: Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml > > -F: drivers/media/platform/imx/imx7-mipi-csis.c > > +F: drivers/media/platform/imx/imx-mipi-csis.c > > F: drivers/staging/media/imx/imx7-media-csi.c > > > > MEDIA DRIVERS FOR HELENE > > diff --git a/drivers/media/platform/imx/imx7-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c > > similarity index 100% > > rename from drivers/media/platform/imx/imx7-mipi-csis.c > > rename to drivers/media/platform/imx/imx-mipi-csis.c > > -- > Regards, > > Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c 2022-02-11 18:02 ` [PATCH 2/3] media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c Jacopo Mondi 2022-02-11 20:42 ` Laurent Pinchart @ 2022-02-11 22:15 ` kernel test robot 2022-02-11 23:57 ` kernel test robot 2022-02-14 10:20 ` Rui Miguel Silva 3 siblings, 0 replies; 19+ messages in thread From: kernel test robot @ 2022-02-11 22:15 UTC (permalink / raw) To: Jacopo Mondi, slongerbeam, p.zabel, shawnguo, s.hauer, festevam, mchehab, hverkuil-cisco, laurent.pinchart, martin.kepplinger, rmfrfs, xavier.roumegue Cc: kbuild-all, kernel, linux-imx, linux-media, linux-staging, linux-arm-kernel, Jacopo Mondi Hi Jacopo, I love your patch! Yet something to improve: [auto build test ERROR on media-tree/master] [also build test ERROR on shawnguo/for-next pza/reset/next linus/master v5.17-rc3 next-20220211] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jacopo-Mondi/media-De-stage-imx7-mipi-csis-c/20220212-020342 base: git://linuxtv.org/media_tree.git master config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220212/202202120641.u7xFAEMc-lkp@intel.com/config) compiler: sh4-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/18a307fb15879832a050d12ae32bd9d94a9e5c91 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jacopo-Mondi/media-De-stage-imx7-mipi-csis-c/20220212-020342 git checkout 18a307fb15879832a050d12ae32bd9d94a9e5c91 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash M=drivers/media If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> make[4]: *** No rule to make target 'drivers/media/platform/imx/imx7-mipi-csis.o', needed by 'drivers/media/platform/imx/imx7-mipi-csis.mod'. make[4]: Target '__build' not remade because of errors. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c 2022-02-11 18:02 ` [PATCH 2/3] media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c Jacopo Mondi 2022-02-11 20:42 ` Laurent Pinchart 2022-02-11 22:15 ` kernel test robot @ 2022-02-11 23:57 ` kernel test robot 2022-02-14 10:20 ` Rui Miguel Silva 3 siblings, 0 replies; 19+ messages in thread From: kernel test robot @ 2022-02-11 23:57 UTC (permalink / raw) To: Jacopo Mondi, slongerbeam, p.zabel, shawnguo, s.hauer, festevam, mchehab, hverkuil-cisco, laurent.pinchart, martin.kepplinger, rmfrfs, xavier.roumegue Cc: kbuild-all, kernel, linux-imx, linux-media, linux-staging, linux-arm-kernel, Jacopo Mondi Hi Jacopo, I love your patch! Yet something to improve: [auto build test ERROR on media-tree/master] [also build test ERROR on shawnguo/for-next pza/reset/next linus/master v5.17-rc3 next-20220211] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jacopo-Mondi/media-De-stage-imx7-mipi-csis-c/20220212-020342 base: git://linuxtv.org/media_tree.git master config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20220212/202202120715.pWMiLjja-lkp@intel.com/config) compiler: alpha-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/18a307fb15879832a050d12ae32bd9d94a9e5c91 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jacopo-Mondi/media-De-stage-imx7-mipi-csis-c/20220212-020342 git checkout 18a307fb15879832a050d12ae32bd9d94a9e5c91 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> make[5]: *** No rule to make target 'drivers/media/platform/imx/imx7-mipi-csis.o', needed by 'drivers/media/platform/imx/built-in.a'. make[5]: Target '__build' not remade because of errors. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c 2022-02-11 18:02 ` [PATCH 2/3] media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c Jacopo Mondi ` (2 preceding siblings ...) 2022-02-11 23:57 ` kernel test robot @ 2022-02-14 10:20 ` Rui Miguel Silva 2022-02-14 11:20 ` Jacopo Mondi 3 siblings, 1 reply; 19+ messages in thread From: Rui Miguel Silva @ 2022-02-14 10:20 UTC (permalink / raw) To: Jacopo Mondi, slongerbeam, p.zabel, shawnguo, s.hauer, festevam, mchehab, hverkuil-cisco, laurent.pinchart, martin.kepplinger, xavier.roumegue Cc: kernel, linux-imx, linux-media, linux-staging, linux-arm-kernel Hey Jacopo, I think you by now saw the kernel test report. You miss the rename in the makefile also. ------ Cheers, Rui On Fri Feb 11, 2022 at 6:02 PM WET, Jacopo Mondi wrote: > Rename the imx7-mipi-csis.c driver to remove the reference to i.MX7. > > The driver is for an IP core found on i.MX7 and i.MX8 SoC so do not > specify a SoC version number in the driver name. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > MAINTAINERS | 2 +- > .../media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename drivers/media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 5bdb8c881b0b..7def3b7d56bc 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11891,7 +11891,7 @@ T: git git://linuxtv.org/media_tree.git > F: Documentation/admin-guide/media/imx7.rst > F: Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml > F: Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml > -F: drivers/media/platform/imx/imx7-mipi-csis.c > +F: drivers/media/platform/imx/imx-mipi-csis.c > F: drivers/staging/media/imx/imx7-media-csi.c > > MEDIA DRIVERS FOR HELENE > diff --git a/drivers/media/platform/imx/imx7-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c > similarity index 100% > rename from drivers/media/platform/imx/imx7-mipi-csis.c > rename to drivers/media/platform/imx/imx-mipi-csis.c > -- > 2.35.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c 2022-02-14 10:20 ` Rui Miguel Silva @ 2022-02-14 11:20 ` Jacopo Mondi 2022-02-14 11:22 ` Laurent Pinchart 0 siblings, 1 reply; 19+ messages in thread From: Jacopo Mondi @ 2022-02-14 11:20 UTC (permalink / raw) To: Rui Miguel Silva, Laurent Pinchart Cc: slongerbeam, p.zabel, shawnguo, s.hauer, festevam, mchehab, hverkuil-cisco, laurent.pinchart, martin.kepplinger, xavier.roumegue, kernel, linux-imx, linux-media, linux-staging, linux-arm-kernel Hi Rui, On Mon, Feb 14, 2022 at 10:20:57AM +0000, Rui Miguel Silva wrote: > Hey Jacopo, > I think you by now saw the kernel test report. > > You miss the rename in the makefile also. Yes, that's pretty stupid sorry, I forgot to add the Makefile :( I'll fix in v2 Laurent, do you want to squash 2/3 and 3/3 to have the symbols and the file rename in the same patch ? Thanks j > > ------ > Cheers, > Rui > On Fri Feb 11, 2022 at 6:02 PM WET, Jacopo Mondi wrote: > > > Rename the imx7-mipi-csis.c driver to remove the reference to i.MX7. > > > > The driver is for an IP core found on i.MX7 and i.MX8 SoC so do not > > specify a SoC version number in the driver name. > > > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > > --- > > MAINTAINERS | 2 +- > > .../media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} | 0 > > 2 files changed, 1 insertion(+), 1 deletion(-) > > rename drivers/media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} (100%) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 5bdb8c881b0b..7def3b7d56bc 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -11891,7 +11891,7 @@ T: git git://linuxtv.org/media_tree.git > > F: Documentation/admin-guide/media/imx7.rst > > F: Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml > > F: Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml > > -F: drivers/media/platform/imx/imx7-mipi-csis.c > > +F: drivers/media/platform/imx/imx-mipi-csis.c > > F: drivers/staging/media/imx/imx7-media-csi.c > > > > MEDIA DRIVERS FOR HELENE > > diff --git a/drivers/media/platform/imx/imx7-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c > > similarity index 100% > > rename from drivers/media/platform/imx/imx7-mipi-csis.c > > rename to drivers/media/platform/imx/imx-mipi-csis.c > > -- > > 2.35.0 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c 2022-02-14 11:20 ` Jacopo Mondi @ 2022-02-14 11:22 ` Laurent Pinchart 0 siblings, 0 replies; 19+ messages in thread From: Laurent Pinchart @ 2022-02-14 11:22 UTC (permalink / raw) To: Jacopo Mondi Cc: Rui Miguel Silva, slongerbeam, p.zabel, shawnguo, s.hauer, festevam, mchehab, hverkuil-cisco, martin.kepplinger, xavier.roumegue, kernel, linux-imx, linux-media, linux-staging, linux-arm-kernel Hi Jacopo, On Mon, Feb 14, 2022 at 12:20:00PM +0100, Jacopo Mondi wrote: > On Mon, Feb 14, 2022 at 10:20:57AM +0000, Rui Miguel Silva wrote: > > Hey Jacopo, > > I think you by now saw the kernel test report. > > > > You miss the rename in the makefile also. > > Yes, that's pretty stupid sorry, I forgot to add the Makefile :( > > I'll fix in v2 > > Laurent, do you want to squash 2/3 and 3/3 to have the symbols and the > file rename in the same patch ? I think I'd prefer that, but if it ends up being messy you can keep them separate. > > ------ > > Cheers, > > Rui > > On Fri Feb 11, 2022 at 6:02 PM WET, Jacopo Mondi wrote: > > > > > Rename the imx7-mipi-csis.c driver to remove the reference to i.MX7. > > > > > > The driver is for an IP core found on i.MX7 and i.MX8 SoC so do not > > > specify a SoC version number in the driver name. > > > > > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > > > --- > > > MAINTAINERS | 2 +- > > > .../media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} | 0 > > > 2 files changed, 1 insertion(+), 1 deletion(-) > > > rename drivers/media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} (100%) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 5bdb8c881b0b..7def3b7d56bc 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -11891,7 +11891,7 @@ T: git git://linuxtv.org/media_tree.git > > > F: Documentation/admin-guide/media/imx7.rst > > > F: Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml > > > F: Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml > > > -F: drivers/media/platform/imx/imx7-mipi-csis.c > > > +F: drivers/media/platform/imx/imx-mipi-csis.c > > > F: drivers/staging/media/imx/imx7-media-csi.c > > > > > > MEDIA DRIVERS FOR HELENE > > > diff --git a/drivers/media/platform/imx/imx7-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c > > > similarity index 100% > > > rename from drivers/media/platform/imx/imx7-mipi-csis.c > > > rename to drivers/media/platform/imx/imx-mipi-csis.c -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 3/3] media: imx: Remove reference to i.MX7 from driver 2022-02-11 18:02 [PATCH 0/3] media: De-stage imx7-mipi-csis.c Jacopo Mondi 2022-02-11 18:02 ` [PATCH 1/3] media: imx: De-stage imx7-mipi-csis Jacopo Mondi 2022-02-11 18:02 ` [PATCH 2/3] media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c Jacopo Mondi @ 2022-02-11 18:02 ` Jacopo Mondi 2022-02-11 20:46 ` Laurent Pinchart 2 siblings, 1 reply; 19+ messages in thread From: Jacopo Mondi @ 2022-02-11 18:02 UTC (permalink / raw) To: slongerbeam, p.zabel, shawnguo, s.hauer, festevam, mchehab, hverkuil-cisco, laurent.pinchart, martin.kepplinger, rmfrfs, xavier.roumegue Cc: kernel, linux-imx, linux-media, linux-staging, linux-arm-kernel, Jacopo Mondi Remove the references to the i.MX7 in the driver description and expand it with more information about the IP core the driver controls. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- drivers/media/platform/imx/imx-mipi-csis.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/imx/imx-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c index a22d0e6b3d44..59f4485bbe70 100644 --- a/drivers/media/platform/imx/imx-mipi-csis.c +++ b/drivers/media/platform/imx/imx-mipi-csis.c @@ -1,6 +1,10 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Freescale i.MX7 SoC series MIPI-CSI V3.3 receiver driver + * CSIS MIPI CSI-2 receiver driver. + * + * CSIS is an IP core originating from Samsung found in NXP i.MX7 and i.MX8 + * SoC series. i.MX7 features version 3.3 of the IP, while i.MX8 features + * version 3.6.3 * * Copyright (C) 2019 Linaro Ltd * Copyright (C) 2015-2016 Freescale Semiconductor, Inc. All Rights Reserved. @@ -31,7 +35,7 @@ #include <media/v4l2-mc.h> #include <media/v4l2-subdev.h> -#define CSIS_DRIVER_NAME "imx7-mipi-csis" +#define CSIS_DRIVER_NAME "imx-mipi-csis" #define CSIS_PAD_SINK 0 #define CSIS_PAD_SOURCE 1 @@ -1515,4 +1519,4 @@ module_platform_driver(mipi_csis_driver); MODULE_DESCRIPTION("i.MX7 & i.MX8 MIPI CSI-2 receiver driver"); MODULE_LICENSE("GPL v2"); -MODULE_ALIAS("platform:imx7-mipi-csi2"); +MODULE_ALIAS("platform:imx-mipi-csi2"); -- 2.35.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 3/3] media: imx: Remove reference to i.MX7 from driver 2022-02-11 18:02 ` [PATCH 3/3] media: imx: Remove reference to i.MX7 from driver Jacopo Mondi @ 2022-02-11 20:46 ` Laurent Pinchart 0 siblings, 0 replies; 19+ messages in thread From: Laurent Pinchart @ 2022-02-11 20:46 UTC (permalink / raw) To: Jacopo Mondi Cc: slongerbeam, p.zabel, shawnguo, s.hauer, festevam, mchehab, hverkuil-cisco, martin.kepplinger, rmfrfs, xavier.roumegue, kernel, linux-imx, linux-media, linux-staging, linux-arm-kernel Hi Jacopo, Thank you for the patch. On Fri, Feb 11, 2022 at 07:02:16PM +0100, Jacopo Mondi wrote: > Remove the references to the i.MX7 in the driver description and expand > it with more information about the IP core the driver controls. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > drivers/media/platform/imx/imx-mipi-csis.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/imx/imx-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c > index a22d0e6b3d44..59f4485bbe70 100644 > --- a/drivers/media/platform/imx/imx-mipi-csis.c > +++ b/drivers/media/platform/imx/imx-mipi-csis.c > @@ -1,6 +1,10 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * Freescale i.MX7 SoC series MIPI-CSI V3.3 receiver driver > + * CSIS MIPI CSI-2 receiver driver. "CSIS" states for "CSI Slave", there's also a CSIM core available from Samsung. As you acknowledge the Samsung origin in the next paragraph, I'd write * Samsung CSIS CSI-2 receiver driver > + * > + * CSIS is an IP core originating from Samsung found in NXP i.MX7 and i.MX8 > + * SoC series. i.MX7 features version 3.3 of the IP, while i.MX8 features > + * version 3.6.3 And maybe this could then become * The Samsung CSIS IP is a MIPI CSI-2 receiver found in various NXP i.MX7 and * i.MX8 SoCs. The i.MX7 features version 3.3 of the IP, while i.MX8 features * version 3.6.3 Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > * > * Copyright (C) 2019 Linaro Ltd > * Copyright (C) 2015-2016 Freescale Semiconductor, Inc. All Rights Reserved. > @@ -31,7 +35,7 @@ > #include <media/v4l2-mc.h> > #include <media/v4l2-subdev.h> > > -#define CSIS_DRIVER_NAME "imx7-mipi-csis" > +#define CSIS_DRIVER_NAME "imx-mipi-csis" > > #define CSIS_PAD_SINK 0 > #define CSIS_PAD_SOURCE 1 > @@ -1515,4 +1519,4 @@ module_platform_driver(mipi_csis_driver); > > MODULE_DESCRIPTION("i.MX7 & i.MX8 MIPI CSI-2 receiver driver"); > MODULE_LICENSE("GPL v2"); > -MODULE_ALIAS("platform:imx7-mipi-csi2"); > +MODULE_ALIAS("platform:imx-mipi-csi2"); -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2022-02-14 12:28 UTC | newest] Thread overview: 19+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-02-11 18:02 [PATCH 0/3] media: De-stage imx7-mipi-csis.c Jacopo Mondi 2022-02-11 18:02 ` [PATCH 1/3] media: imx: De-stage imx7-mipi-csis Jacopo Mondi 2022-02-11 18:32 ` Fabio Estevam 2022-02-11 20:21 ` Laurent Pinchart 2022-02-14 9:23 ` Jacopo Mondi 2022-02-14 11:40 ` Fabio Estevam 2022-02-11 20:40 ` Laurent Pinchart 2022-02-14 9:43 ` (EXT) " Alexander Stein 2022-02-14 9:51 ` Laurent Pinchart 2022-02-11 18:02 ` [PATCH 2/3] media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c Jacopo Mondi 2022-02-11 20:42 ` Laurent Pinchart 2022-02-14 10:28 ` Rui Miguel Silva 2022-02-11 22:15 ` kernel test robot 2022-02-11 23:57 ` kernel test robot 2022-02-14 10:20 ` Rui Miguel Silva 2022-02-14 11:20 ` Jacopo Mondi 2022-02-14 11:22 ` Laurent Pinchart 2022-02-11 18:02 ` [PATCH 3/3] media: imx: Remove reference to i.MX7 from driver Jacopo Mondi 2022-02-11 20:46 ` Laurent Pinchart
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).