From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1886EC6FA99 for ; Fri, 10 Mar 2023 14:24:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:From:Subject: Cc:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=newjmxKfFsuq4+YWxcJii0v+HYyvp3tXgrW58QhXBb4=; b=AHYShiv4/cdrsC 8elLgOUwjHVaQsL0lCFn/72subMHNvmj76kzSYi1G+IkAw18eAyxeoft/SVXVPi4L6s3s5Ev8HFoa VxbSRoyZT23FwQOQ66gStxnqxyxJlygwmg+BQXJALBQd5Y/KBOBMT+2YKNWTbQfAjsNm+ajKhiHai z7l2K9Nc35G7ar/E04A4KXGsieX/LJbAMeTLAIrW2oQRQfM5fAPfXahyo8qc5EZhZ3on36QCsGFAM zaGdY1OZJd4IpiN4amMliYMg3XokHBu2Go5vnzf5O7K02v6owomJ4TzmF3uS5Wv3bmqc0drFq2NCP iOjLh/dDyWlXuxVJ2Slw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pader-00EizD-4E; Fri, 10 Mar 2023 14:23:45 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1padeo-00Eiy3-HM for linux-arm-kernel@lists.infradead.org; Fri, 10 Mar 2023 14:23:43 +0000 Received: by mail-ed1-x52a.google.com with SMTP id a25so21286868edb.0 for ; Fri, 10 Mar 2023 06:23:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678458218; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2eE8vid9FM7x60cVTVIebF5BuQoaUundVFu4YvIZ1pg=; b=P1bPsHoUwW3cQQCFMX0G4KReC17NSYR6Ugpgpto2MXCW2Dd5TWs+qSkiJnsXxdtDum WrNvvs5VbKMCRqKll1h4Telz7X80bieZa2usRcl1ohozhCFIOaoj7tbo4IWpAT0oR4K+ 53K2bolfqcBbR06xt7greJiWKraV6KradSbZsY1/n/u5OJvRbibN2W+K1prL2tRdPc2f hlr96Db0hzDVVRPh1gyCrv0JOTNgeNtzVY8hBCEUIQEN84+lTeYS+x8bC53W91GlDMYd B7OkupxnaYaFDcOZG8CwFlOTKqkbpEbvhELIpETx0WsXZtjaLYFt6BAM30k8H0mciCgS P4aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678458218; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2eE8vid9FM7x60cVTVIebF5BuQoaUundVFu4YvIZ1pg=; b=fqhlZZvQU5qZHiwaMsaP4vYrjAThHnSLUTcnlDS7v9ZDrNLY09AMnVPg5umBWbOmY2 YNUiXFbbqTftq+PL2u9ZZyfvP3l2WwqIHU3+JU6leLU4Eyn2gErtkdACMeTiU8vOK4o8 cv//jO+4kkcAX697T9/MW/BTW1tpfop/+cZ2X9QNfcPxuQCFB+3eyoR0S2CfVncv9eZT H8D7cwJg9R40yPtz38k9vKSbM5J3nx2g8TSNYa6U//F5dkIJHLJkBMhrZe9MRlLeUQmR dHYKoVkeclMegt2V2rStGvA2AE6l37QzJQKnCKZI+B0sDIXfKlyfJo0yAPq6KaR1rBqu 2h2g== X-Gm-Message-State: AO0yUKWG4x/uhP6NHOkx79dzUCZ6tZMWrbkhTE8oV8LFQN3qLnWDiG1B 5scWTJZX4M9Csxtl+IRPW5E= X-Google-Smtp-Source: AK7set9n9wsHVA0I7R07oQLeCZ4PHbeXCrxG7OO8HPOdKMat0zhCd8MpDGCEIF7K21bJ9R3cdfobZw== X-Received: by 2002:a17:907:c28b:b0:861:4671:a834 with SMTP id tk11-20020a170907c28b00b008614671a834mr23321762ejc.71.1678458218142; Fri, 10 Mar 2023 06:23:38 -0800 (PST) Received: from localhost ([2001:b07:5d37:537d:5e25:9ef5:7977:d60c]) by smtp.gmail.com with ESMTPSA id qb4-20020a1709077e8400b008b17e55e8f7sm995895ejc.186.2023.03.10.06.23.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Mar 2023 06:23:37 -0800 (PST) Mime-Version: 1.0 Date: Fri, 10 Mar 2023 15:23:36 +0100 Message-Id: Cc: "Arnd Bergmann" , "Russell King" , , Subject: Re: [PATCH] ARM: dyndbg: allow including dyndbg.h in decompressor From: "Vincenzo Palazzo" To: "Arnd Bergmann" , "Luis Chamberlain" , "Jason Baron" References: <20230310140133.291594-1-arnd@kernel.org> In-Reply-To: <20230310140133.291594-1-arnd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230310_062342_610007_6F917E52 X-CRM114-Status: GOOD ( 16.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > From: Arnd Bergmann > > After a change to linux/module.h, dyndbg.h is now included > indirectly from the decompressor for lz4 support, which in turn > causes a build failure on 32-bit Arm: > > In file included from include/linux/module.h:30, > from arch/arm/boot/compressed/../../../../lib/lz4/lz4_decompress.c:39, > from arch/arm/boot/compressed/../../../../lib/decompress_unlz4.c:10, > from arch/arm/boot/compressed/decompress.c:59: > include/linux/dynamic_debug.h: In function 'ddebug_dyndbg_module_param_cb': > include/linux/dynamic_debug.h:307:14: error: implicit declaration of function 'strcmp' [-Werror=implicit-function-declaration] > 307 | if (!strcmp(param, "dyndbg")) { > | ^~~~~~ > include/linux/dynamic_debug.h:1:1: note: 'strcmp' is defined in header ''; did you forget to '#include '? > +++ |+#include > > The decompressor has its own replacement for the linux/string.h contents, > so the normal declaration is not visible here. Since the function is > not actually called, it is sufficient to add a declaration, and this > is in fact the correct one as it matches the definition in > arch/arm/boot/compressed/string.c. > > Fixes: 7deabd674988 ("dyndbg: use the module notifier callbacks") > Signed-off-by: Arnd Bergmann > --- Reviewed-by: Vincenzo Palazzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel