From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2563C76196 for ; Mon, 3 Apr 2023 13:53:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LHtVz4TCHLOp/vNnWrzMdUH2r6pnVvKRdcVp9WJechI=; b=iwWa+wW2ave7Pm DKw3I/ZukQNd0lMLviLqLtMUxBlJL6vNZ/sYYRglfQLJ+QJ/vSCvcBe+GWeR6bUgEn0hd/Qa9IXTa ag0QSAGmtvoWHbBbwQkpBN/j2S1nwkrBM3DhSw3q/E2d1dTZEI95HBSUB9V2voFpOBInupqvggL9y 12ckoslGAhukzgJPQXybvRgkIt+qrRiJ90nFzWmcqi41KnuEdGD26wPTWeldqL7SR6G1EUmvU5qal NUcc8t1B1K/cUhg+sBP/swnRCMyRlrEIhyt+JB3uv+tVvPkrsi46fzIoQ0qzDShRieB4yMTq4eLV+ WQnYXlYAMpqIBrTjU/lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pjKc7-00FWqY-2n; Mon, 03 Apr 2023 13:52:51 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pjKc4-00FWns-1u for linux-arm-kernel@lists.infradead.org; Mon, 03 Apr 2023 13:52:50 +0000 Received: (Authenticated sender: me@crly.cz) by mail.gandi.net (Postfix) with ESMTPSA id 02CD660007; Mon, 3 Apr 2023 13:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crly.cz; s=gm1; t=1680529959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yjZVA2mMTeWzOtGqbKtDtJ1agsEpiSlCHKJk6KjuyTk=; b=a+axboIp+P2/EKx8WVgBZOoRoRb9hQH4yMUJKl/KYwTUXyWTHkrdOcsRBihMNMuo2dl3QV zWOf2kr4ADe3KnTUNknPdufaa+L4lsOwXiR2y7Gma3pvVwv3JpTkY8iVX7m5RtIHlWCqfj gtlXcAJzUSIjwDYnwLcdHWT6bi2HsK3G6cunNA5Ir3/fkY5mIBklap5LlA1PVfm27uqBIc RM2xnKgFFxAo/EPlKGKCWqf3BP+rWeYJXnEO5ARANwcYxyCRVZd058YKlxfLKQ5MLzUgC6 upc7FgQGmjHoLlWXZL9JaTEk2pbSI7L8GYt2tdTN6hhcXvidQ3OevjSfPQHwPA== Mime-Version: 1.0 Date: Mon, 03 Apr 2023 15:52:36 +0200 Message-Id: Subject: Re: [PATCH 3/3] drm: sun4i: calculate proper DCLK rate for DSI From: "Roman Beranek" To: "Frank Oltmanns" Cc: "Maxime Ripard" , "Chen-Yu Tsai" , "David Airlie" , "Daniel Vetter" , "Jernej Skrabec" , "Samuel Holland" , , , , X-Mailer: aerc 0.14.0 References: <20230331110245.43527-1-me@crly.cz> <20230331110245.43527-4-me@crly.cz> <87h6tya70h.fsf@oltmanns.dev> In-Reply-To: <87h6tya70h.fsf@oltmanns.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230403_065248_789938_D84A6A6F X-CRM114-Status: GOOD ( 11.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun Apr 2, 2023 at 12:49 PM CEST, Frank Oltmanns wrote: > > When apply this to drm-next my panel stays dark. I haven't figured out > yet why, though. The other two patches in this series work fine, i.e. > they have no effect as they are just a refactoring. > > I'm testing this on my pinephone. It's the same with the patch I > submitted. For whatever reason, it no longer works on drm-next. I've reproduced the issue on my PinePhone and noticed that tcon0 had set pll-video0-2x as its parent instead of pll-mipi. Having tried a whole range of pll-video0 rates, I'm now convinced that DSI only works when tcon0 has pll-mipi as its parent. As little a change as setting .clock in the default mode of PP's panel to 73500 can fix it. Better yet, dropping pll-video0-2x from the set of acceptable parents for tcon0 fixes it universally. And that's what megi's kernel does, though the measure was introduced with a different rationale: Roman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel