From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F394C48260 for ; Tue, 13 Feb 2024 15:51:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:References:To:From:Subject:Cc:Message-Id:Date:Mime-Version: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MwG0a6oh2K8UQnEzfn/VVfjFCKJfwqYIyDt9iKzh3sI=; b=Hn+gk4sHXPSvX/Pn2h6SQZlm2A Ew4wtKdOE7nA7tqtKIphGGX+p7aGd80YUqDn7euTazg/LrgK/TEuksj8R/vc+xYWrFo3/cje3vdQg z9tDR7tYK1cYbhZpZnPxrtvsE/ZKHRhWbM8yCL2EEee67qm+arLHARzzgWouIvccgs7JnvJrCSyay N8cQ/Nn7YRAVmhbc7TOb2zxZnXnYUYkeNGAEhjBVr45hsMjD/Dba6/BwXp40Q5IaPSxv7aIogF7Eu HGwjO1vzATIOh6IZ7+43yiWltNz+9sSDh8FF0G7kz3lDAL4kmwhu86BlzXjgL+Sq/bkA6DvWJIo5r 2pnBCDHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZv4O-00000009pbk-2sUk; Tue, 13 Feb 2024 15:51:40 +0000 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZv4M-00000009pbG-39ay for linux-arm-kernel@lists.infradead.org; Tue, 13 Feb 2024 15:51:39 +0000 Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-5118d65cf9cso2844719e87.0 for ; Tue, 13 Feb 2024 07:51:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707839496; x=1708444296; darn=lists.infradead.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=j5nluc7rACTm9e7KyTW8p7QXPYnj/OIsgMqpSFU5hoo=; b=Dw/+sySqUQW3S21j67EtNgiBhDp0+YoWq4ApQrR0cKk7iJHjgGnxbP9ZTRGuXva3v/ le7bXGAaIl/tKTZZoe+Bwl6zoh6w9EJJtvk4oPuKiv1ir7IyIwG3lw2Ay4cFMVH9ssuW KfppeIPfKWr9iVlXz8lxdKsQEc/aEOxkUiXR0X+Uzj/uFzST0SXXg/YAphJCVZQ3Q5l5 NT0ywGBuKO9N4eNneEnODfW06o/2noA6U7nlMOOyZArhiS07se2Q2gc/2OESbabjb9po ksWSFyPAatnmW2BLns8yqdIFVKEuwko9+fvCdj1GyvHuRfJtWjLblmIs/hgC7zku0Vj5 EkqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707839496; x=1708444296; h=in-reply-to:references:to:from:subject:cc:message-id:date :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j5nluc7rACTm9e7KyTW8p7QXPYnj/OIsgMqpSFU5hoo=; b=KOg7soFCVwMw9pFkeOwkqkhY16mFJY9QQiunYAkKCnQ7ODxkgrPqZ4qXOaq4ksw30k ml0QrFjT5UoD4L1JAvG3lUffVWRbzV/VDhv9jBho5ch7VYW9IjXsUKqra8aNo7vVUhIO uzHJUxFNEfzbrqyZmgu6iUbCjuKa2+jXBcNqBX5qI66V9ARyhgXu101b71ZYPMFIeTHa YTZcHbSydbiaLu0e2eR0ZExAcWghXvgJPPCpSp0ZnEXZ+cmdO3NeEIK9Njoz34KJCfwt E2bLupwdew8landGh6ostTBYvLFSqS4Yj24vU852VkGWamzA21PdO8F+7fU+6WKufxnE h6qA== X-Forwarded-Encrypted: i=1; AJvYcCUbkNy8SFLr7sUK4rOYwcDEKyg/fE0yAZgaExkh5+JRYc+N7/7TV+DkI9rImhYhVvZa6Yg1cZMbPOKjx7T80HkIuQDOand644grk38yXQb2P0Vr8Mw= X-Gm-Message-State: AOJu0YyHmjaLzkIjZWDV4h7tnAWRlloKAKn96PECQbXoRwvzPBXaSQ1o BgXDzP/F6TnayYkuM3L4ypnpt+ihwqKBzxXe5bbQqA9N8waZwoh9RgslzlRI X-Google-Smtp-Source: AGHT+IFWyZC7z5UQHaeXsMQIqqpgCO/rfzao3TGvlmhOSjICYP0D1kLKY44LrpKKMyl7qF3fXdcQ5g== X-Received: by 2002:ac2:46e8:0:b0:511:933c:64e9 with SMTP id q8-20020ac246e8000000b00511933c64e9mr3107277lfo.66.1707839495973; Tue, 13 Feb 2024 07:51:35 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCU2oInC5bB4kgCVw92bLjNBtS/DiMGH11yOilf5sZB3nJEhEzIMK5ObuBiemAzgrxXQX8ldO48VfVkhateEJLgxBjOgRw3/1c9D2hGGO2lCiTP0aW3iNECsttorD1dAiznuZW7O2OZobKuTBU7TA9GpwAukumir45Z3wotrHqqaMMuR750vPkB2xqcbdGumM7g0+WGghRHEZ86kchEnZCpgAI6jL36/qJPKt31Sgvh6eMudbWOzXSQO77YTV0FGdO7UGroFpmATuEsw1e7peKIdnUYlcHhRTzzMseThuiHpwYdhj/puLf5fS41Qy+ibjOMztsyACOtBSoqsTqfBjRe5QQD8nFbGqSuJbC7fvc/q+6TUTD6/A6h5afFEuBWI+xlyZ1GDxh0lu+3Y3me6XBTgU8yJits= Received: from localhost (p200300e41f147f00f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f14:7f00:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id ig12-20020a056402458c00b0056213094d7bsm140732edb.69.2024.02.13.07.51.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Feb 2024 07:51:35 -0800 (PST) Mime-Version: 1.0 Date: Tue, 13 Feb 2024 16:51:34 +0100 Message-Id: Cc: "Alexandre Torgue" , "Jose Abreu" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , , , , , Subject: Re: [PATCH net-next v2 3/3] net: stmmac: Configure AXI on Tegra234 MGBE From: "Thierry Reding" To: "Serge Semin" X-Mailer: aerc 0.16.0-1-0-g560d6168f0ed-dirty References: <20240202-stmmac-axi-config-v2-0-64eab2bab17b@nvidia.com> <20240202-stmmac-axi-config-v2-3-64eab2bab17b@nvidia.com> In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240213_075138_814898_CF1CF901 X-CRM114-Status: GOOD ( 33.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5691070719625060257==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5691070719625060257== Content-Type: multipart/signed; boundary=cfa596c0b51d52dd3aecf0f90e9ae3c845fbf778d202ed71698f391c8fdb; micalg=pgp-sha256; protocol="application/pgp-signature" --cfa596c0b51d52dd3aecf0f90e9ae3c845fbf778d202ed71698f391c8fdb Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Mon Feb 5, 2024 at 1:44 AM CET, Serge Semin wrote: > On Fri, Feb 02, 2024 at 12:53:35PM +0100, Thierry Reding wrote: > > From: Thierry Reding > >=20 > > Allow the device to use bursts and increase the maximum number of > > outstanding requests to improve performance. Measurements show an > > increase in throughput of around 5x on a 1 Gbps link. > >=20 > > Signed-off-by: Thierry Reding > > --- > > drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > >=20 > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c b/driver= s/net/ethernet/stmicro/stmmac/dwmac-tegra.c > > index bab57d1675df..b6bfa48f279d 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c > > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c > > @@ -199,6 +199,12 @@ static void mgbe_uphy_lane_bringup_serdes_down(str= uct net_device *ndev, void *mg > > writel(value, mgbe->xpcs + XPCS_WRAP_UPHY_RX_CONTROL); > > } > > =20 > > +static const struct stmmac_axi tegra234_mgbe_axi =3D { > > + .axi_wr_osr_lmt =3D 63, > > + .axi_rd_osr_lmt =3D 63, > > + .axi_blen =3D { 256, }, > > +}; > > + > > static int tegra_mgbe_probe(struct platform_device *pdev) > > { > > struct plat_stmmacenet_data *plat; > > @@ -284,6 +290,9 @@ static int tegra_mgbe_probe(struct platform_device = *pdev) > > if (err < 0) > > goto disable_clks; > > =20 > > + /* setup default AXI configuration */ > > + res.axi =3D &tegra234_mgbe_axi; > > + > > plat =3D devm_stmmac_probe_config_dt(pdev, &res); > > if (IS_ERR(plat)) { > > err =3D PTR_ERR(plat); > > The entire series can be converted to just a few lines of change: Sorry for the delay, I missed this reply. > plat =3D devm_stmmac_probe_config_dt(pdev, res.mac); > if (IS_ERR(plat)) { > err =3D PTR_ERR(plat); > goto disable_clks; > } > + > + if (IS_ERR_OR_NULL(plat->axi)) { > + plat->axi =3D devm_kzalloc(&pdev->dev, sizeof(*axi), GFP_KERNEL); > + if (!plat->axi) { > + ret =3D -ENOMEM; > + goto disable_clks; > + } > + } /* else memset plat->axi with zeros if you wish */ > + > + plat->axi->axi_wr_osr_lmt =3D 63; > + plat->axi->axi_rd_osr_lmt =3D 63; > + plat->axi->axi_blen[0] =3D 256; > =20 > plat->has_xgmac =3D 1; > plat->flags |=3D STMMAC_FLAG_TSO_EN; > plat->pmt =3D 1; > > Please don't overcomplicate the already overcomplicated driver with a > functionality which can be reached by the default one. In this case > the easiest way is to let the generic code work and then > override/replace/fix/etc the retrieved values. Thus there won't be > need in adding the redundant functionality and keep the generic > DT-platform code a bit simpler to read. I'm not sure I understand how this is overcomplicating things. The code is pretty much unchanged, except that the AXI configuration can now have driver-specified defaults before the DT is parsed. Perhaps I need to add comments to make that a bit clearer? While your version is certainly simpler it has the drawback that it no longer allows the platform defaults to be overridden in device tree. I would prefer if the defaults can be derived from the compatible string but if need be for those defaults to still be overridable from device tree. Thierry --cfa596c0b51d52dd3aecf0f90e9ae3c845fbf778d202ed71698f391c8fdb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmXLkAcACgkQ3SOs138+ s6HY6g//TyBX07vSPy79ApF01cK74bhK4woNCTlScH1jk/Pky8il9Yw+GrXfnnEk 9d6LiXfIWLHIvPLS4xcvwM0dT/FTTdDjgS41G2X0p06Bn7BGTHVJ+xuPjKh6yRuv mVbYhtqUJynPHkT9R3OIBKZ6E3nTNGPp8ocpAe82uN6Opl1QI4BRJ8syKYciUcHj REtkb1HZBXlxYhnWlFCHEsyD+mNdnZ1Z1mD50lauYCdkjhu/GnL8Czt1ScCy8q/s URZ/Ft5r+6M8aBVyfRfR+r9XalZiRtxksOL2Ova79dlistCGl8S2NNWw7M3vxHPO HvfhWMHyf0ywdQXoYEhTW/pt98X+fJPtIhnCfSrdOac58+WRSCiKekarM2WkS4ma lUm4Azh/xK5z4zexVXB6j5Szgb9Hz/u3twxKvnNxu/frAJL7WesujOUy2RR+g2CM KI3xDH9t2yuWE45vhv2MGAuPEeAtVmG5R2OxV7duuCXHCsY7njs6bZLyT1nX6eC1 ON9D4tsIj6TGo51UPokLNU04KzDB/D2xEqzqeV1GUuEXe/CsJIey76JpFT0UvJry D1/UtEp+lAczY85TRiILc6z+NqSCq4p3kEqi+txrfr806bkHfBmRz/ZxlZbgrYPZ ijRgUxzyXZxcL0ci0o8g+YFcoXfTJhD5cTt8NvBoolThfwHM/aY= =vhC9 -----END PGP SIGNATURE----- --cfa596c0b51d52dd3aecf0f90e9ae3c845fbf778d202ed71698f391c8fdb-- --===============5691070719625060257== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5691070719625060257==--