Re: [PATCH v2 13/30] pinctrl: nomadik: follow conditional kernel coding conventions

Linus Walleij
2024-02-29T09:29:10Z

On Wed, Feb 28, 2024 at 12:28 PM Théo Lebrun <theo.lebrun@bootlin.com> wrote:

> Fix strict checkpatch warnings relative to if-else blocks and bool
> expressions. Message types addressed:
>
> CHECK: Comparison to NULL could be written "!nmk_cfg_params[index].choice"
> CHECK: Unbalanced braces around else statement
> CHECK: Using comparison to false is error prone
> CHECK: Using comparison to true is error prone
> CHECK: braces {} should be used on all arms of this statement
>
> Before: 0 errors, 1 warnings, 16 checks.
> After: 0 errors, 1 warnings, 7 checks.
>
> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>

Patch applied!

Yours,
Linus Walleij