From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BBFAC54E67 for ; Thu, 14 Mar 2024 11:28:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:From:Subject: Cc:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DlfxsygjiKjO66eI2J4aThcY5o0dqxEhEWZtVKd2d/o=; b=Tm9aRi8Y5OBXv8 dOQ01SkhEVKmIZUAaUVYJmY1897JXWc7lLfDOGMQ+iWGx2AEiPxtkLTeV+rGbRLg/wWDbaDVwOkVk 3vsnyiq9YHrZxj/qgUviTJiML5ZfRrzsPeRKKczGF5GHEDIdn4BYMhEVh8jsuXfGQoxLSzXCujx3I qArb2qWpDL8RTPGc4di3N486aqB0CbGASS20rNotgoeVlP1tEe+CX68wcXcsTDwaEzkBTaVt+WcgS h9/lWcu/Nkuc4ZkbjwtYP2JF7RrtsY2GnEJ5/BhZzNYH5Yg2Ii00kJQX67phZHLWT+zouCGJCn1OM KALoeEE8/XZvtoeYSPWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkjFz-0000000E4nu-2FJK; Thu, 14 Mar 2024 11:28:19 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkjFv-0000000E4kB-2OQ3 for linux-arm-kernel@lists.infradead.org; Thu, 14 Mar 2024 11:28:18 +0000 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-413f1c0edb6so3120355e9.0 for ; Thu, 14 Mar 2024 04:28:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1710415689; x=1711020489; darn=lists.infradead.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kvfWswJLMy50JXcwMfpuKNA6ONIoYQGANkniEpLZiS0=; b=iaFMUo/uBcszb9wfwdKdgmuYmt3KLTy3T5yya9ply7IhwN2SO3pzuCzoKYJCkrJ3kC DzJ1gZREvII13+Ilr4ywJuHCWiUvq0N4xLhJLj/GEtqyJo4UzV6PwVwVD2QCB7mfAUBy +Ec0kG/2ewMMIy5eDjgQeDfT1k7VkrJMKoSk79ZGr/3cv+91Kf3aDCCrL77H6RHFn20G z2yrFKItwn3VvWOjv1PpCUvetWpKNIAeBzVhTKv3ltfW5C98WOXjAFb8ryDoYx+K1kfn 2sMsvYY99OVO+nr42Wc3NFbLJgafWE4Au4MqooVF4MESWwPBijWu3UBcxb+awjyAIzVr u9HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710415689; x=1711020489; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kvfWswJLMy50JXcwMfpuKNA6ONIoYQGANkniEpLZiS0=; b=SOHbSwX5LBKclE6KezhI9X3LOIYllbOz5L58OHe2Ag3/IRUDi2IoYhJa1DPD8kom7t RGtJz/5M4e+kyDl5HEH76FzwuZtY0OqRzriu+3xL/b00vM1N0x25V4pNFTGC/+gl9mQn 4R6Z66wK2Se2mk25pxMOOES4PYUrn4tH02sl1jrxais0iG0iHxENAFuNAu4vJ9RTtppf slYZwURqSo77sjW+NJTMZIVwi6d0BNaCcW8SSEEzWcDKN0eZPQfa7afkRbmK+LiKpwhW lwbOOIuWiLCBKqK3rVNWpOCrKzifN64uz5/vD7CLHlurseClE1Sut+6T7WLOsSsLzbSs h4Og== X-Forwarded-Encrypted: i=1; AJvYcCWiLgz71842pfDycUnNTLfl/0dV1w2h6HqnszR18LQSH6OwMpMi9+hpUlLQDMIWCQAgwYrGj1ExbGY034Rqy+iR77PwqjfgTQxOeZrUk14Flf29TOA= X-Gm-Message-State: AOJu0YwLCGeqP/AoO7ZxPLs4LBXnupbcomA8C6tNA+BDVEZyu2l8sQrb vV5CjB4n4DFCxSf8dF+akzpkIJDfxzvbUaG1AHS3lwcGTHSJsVXfLCZcQkxKVo0= X-Google-Smtp-Source: AGHT+IHJEfdVwTbuH+JSGze0FRnS2aVhc9zhn5UqeSV3T5GymAUUSVuHfjDeQarE9hvcW2PNnyn7NA== X-Received: by 2002:a05:600c:470e:b0:413:2fee:b359 with SMTP id v14-20020a05600c470e00b004132feeb359mr1310873wmo.3.1710415689433; Thu, 14 Mar 2024 04:28:09 -0700 (PDT) Received: from localhost (alyon-651-1-22-137.w82-122.abo.wanadoo.fr. [82.122.123.137]) by smtp.gmail.com with ESMTPSA id je2-20020a05600c1f8200b004133072017csm5422626wmb.42.2024.03.14.04.28.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Mar 2024 04:28:06 -0700 (PDT) Mime-Version: 1.0 Date: Thu, 14 Mar 2024 12:28:00 +0100 Message-Id: Cc: , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 09/11] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators From: "Esteban Blanc" To: "Bhargav Raviprakash" , X-Mailer: aerc 0.15.2 References: <20240308103455.242705-1-bhargav.r@ltts.com> <20240308103455.242705-10-bhargav.r@ltts.com> In-Reply-To: <20240308103455.242705-10-bhargav.r@ltts.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240314_042815_805692_478D524B X-CRM114-Status: GOOD ( 23.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri Mar 8, 2024 at 11:34 AM CET, Bhargav Raviprakash wrote: > From: Nirmala Devi Mal Nadar > > Add support for TPS65224 regulators (bucks and LDOs) to TPS6594 driver as > they have significant functional overlap. TPS65224 PMIC has 4 buck > regulators and 3 LDOs. BUCK12 can operate in dual phase. > The output voltages are configurable and are meant to supply power to the > main processor and other components. > > Signed-off-by: Nirmala Devi Mal Nadar > Signed-off-by: Bhargav Raviprakash > --- > drivers/regulator/Kconfig | 4 +- > drivers/regulator/tps6594-regulator.c | 236 +++++++++++++++++++++++--- > 2 files changed, 215 insertions(+), 25 deletions(-) > > diff --git a/drivers/regulator/tps6594-regulator.c b/drivers/regulator/tps6594-regulator.c > index b7f0c8779..37d76c483 100644 > --- a/drivers/regulator/tps6594-regulator.c > +++ b/drivers/regulator/tps6594-regulator.c > @@ -412,14 +562,20 @@ static int tps6594_regulator_probe(struct platform_device *pdev) > struct tps6594_ext_regulator_irq_data *irq_ext_reg_data; > struct tps6594_regulator_irq_type *irq_type; > u8 buck_configured[BUCK_NB] = { 0 }; > + u8 ldo_configured[LDO_NB] = { 0 }; > u8 buck_multi[MULTI_PHASE_NB] = { 0 }; > static const char * const multiphases[] = {"buck12", "buck123", "buck1234", "buck34"}; `multiphases` should prefixed like the new one. > + static const char * const tps65224_multiphases[] = {"buck12"}; > @@ -495,25 +660,30 @@ static int tps6594_regulator_probe(struct platform_device *pdev) > if (!irq_data) > return -ENOMEM; > > - for (i = 0; i < MULTI_PHASE_NB; i++) { > + for (i = 0; i < multi_phase_cnt; i++) { > if (buck_multi[i] == 0) > continue; > > + const struct regulator_desc *multi_regs = (tps->chip_id == TPS65224) ? > + tps65224_multi_regs : > + tps6594_multi_regs; This should be declared at the top of the function. > rdev = devm_regulator_register(&pdev->dev, &multi_regs[i], &config); > - if (IS_ERR(rdev)) > - return dev_err_probe(tps->dev, PTR_ERR(rdev), > - "failed to register %s regulator\n", > - pdev->name); > + if (IS_ERR(rdev)) > + return dev_err_probe(tps->dev, PTR_ERR(rdev), > + "failed to register %s regulator\n", > + pdev->name); The indentation of the `if` looks odd. You should revert this. > @@ -537,21 +707,34 @@ static int tps6594_regulator_probe(struct platform_device *pdev) > if (buck_configured[i] == 1) > continue; > > - rdev = devm_regulator_register(&pdev->dev, &buck_regs[i], &config); > + const struct regulator_desc *buck_cfg = (tps->chip_id == TPS65224) ? > + tps65224_buck_regs : buck_regs; Same here, should be at the top of the function. > - /* LP8764 dosen't have LDO */ > + /* LP8764 doesn't have LDO */ > if (tps->chip_id != LP8764) { > - for (i = 0; i < ARRAY_SIZE(ldo_regs); i++) { > + for (i = 0; i < LDO_NB; i++) { > + if (ldo_configured[i] == 1) > + continue; > + > + struct tps6594_regulator_irq_type **ldos_irq_types = > + (tps->chip_id == TPS65224) ? > + tps65224_ldos_irq_types : tps6594_ldos_irq_types; > + > + const struct regulator_desc *ldo_regs = > + (tps->chip_id == TPS65224) ? > + tps65224_ldo_regs : tps6594_ldo_regs; Should be at the top of the function, please fix this in the whole file. Best regards, -- Esteban "Skallwar" Blanc BayLibre _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel