From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 318C2C6FD1F for ; Wed, 3 Apr 2024 07:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:In-Reply-To:References:Subject:To:From:Cc:Message-Id:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KzBxYnBo6BzZQSB8wBxXePKMczBmWaA48tO7IcBgCNE=; b=N8D3IIgvF3OEZ/ma173MpS876P WoXiZZiCzCpa+f0n30t1gP3sl+FSnCdu0yZC5C8IKJzURex+a9DoIXw8XfyKp/0fdTAtQvJ+RyDj9 im9POs1M9xW7tnARal8otpUlwpVSWV34a5kcXGqNtZv3Y5eKH2VlS4M05ixNemn+Jdok2GxYS1AeD pqVvrZ+wpbX7sdjJURMaGYvYQ2gMYF4VUQGt/y7RIt6DSTnFdRU2cSKqr6QOwWF1EcZ6KyX4ZoZXD +S9sPC0X59o0eptGPEJeJ+nGOMdAiragvJKXPMomndCBfvAjkuy0saKE0dtb626bk8qWeNwI3Cbud bttVenkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrvAG-0000000EYWO-3rOg; Wed, 03 Apr 2024 07:36:08 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrvAC-0000000EYU9-3q9Y for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 07:36:06 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4C6D66100C; Wed, 3 Apr 2024 07:36:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 717BFC433C7; Wed, 3 Apr 2024 07:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712129763; bh=comgvq/b/dwZzcz2JKiAiH5R+wKfYaBn19+EszVed4M=; h=Date:Cc:From:To:Subject:References:In-Reply-To:From; b=jX9XyvipU7W5InrF55jvVKTf5hV4lNqR9/nPyJZQXUCD1AzJ7vSzG3njmgo0VgRTS SWV1y9yPgz8kyAaAmCteRrfG7kihV2of+Qbumh9mcfhOnciIstv9yT7ozWpy0shln/ Lvxej33RnmwoE39JuESlK1ccFpL38Fpma6kUhJCoTZ38IYBrW6Y0AWx8swRG7cj1Dq de8SK+MGCX6/RM8aKHhentdf+4qqQKyrVVOC1YjAT+mhjJlZGSi4Z7AxIa6dBWJB9z M+7uP27PyHXmVEb5HPV3O+bzkZJreQwOcR4tGMk6+G5YHMvefZnyl4ehojdcLJMJlK 8rnWXXIguJGkQ== Date: Wed, 03 Apr 2024 09:35:47 +0200 Message-Id: Cc: "Nishanth Menon" , "Vignesh Raghavendra" , "Tero Kristo" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , , , From: "Michael Walle" To: "Francesco Dolcini" Subject: Re: [PATCH] arm64: dts: ti: k3-j722s: Disable ethernet ports by default X-Mailer: aerc 0.16.0 References: <20240402151802.3803708-1-mwalle@kernel.org> <20240402165824.GA32125@francesco-nb> In-Reply-To: <20240402165824.GA32125@francesco-nb> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_003605_216915_2E5A2824 X-CRM114-Status: GOOD ( 26.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6636657766466714216==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6636657766466714216== Content-Type: multipart/signed; boundary=85268debbb0a249bf83d175894db0da66e51c3e05656b17bb875057ea9e9; micalg=pgp-sha384; protocol="application/pgp-signature" --85268debbb0a249bf83d175894db0da66e51c3e05656b17bb875057ea9e9 Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi Francesco, On Tue Apr 2, 2024 at 6:58 PM CEST, Francesco Dolcini wrote: > On Tue, Apr 02, 2024 at 05:18:02PM +0200, Michael Walle wrote: > > Device tree best practice is to disable any external interface in the > > dtsi and just enable them if needed in the device tree. Thus, disable > > both ethernet ports by default and just enable the one used by the EVM > > in its device tree. > >=20 > > There is no functional change. > >=20 > > Signed-off-by: Michael Walle > > --- > > This should also be true for all the other SoCs. But I don't wanted to > > touch all the (older) device trees. j722s is pretty new, so there we > > should get it right. > > --- > > arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 5 +---- > > arch/arm64/boot/dts/ti/k3-j722s.dtsi | 8 ++++++++ > > 2 files changed, 9 insertions(+), 4 deletions(-) > >=20 > > diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/= dts/ti/k3-j722s-evm.dts > > index d045dc7dde0c..afe7f68e6a4b 100644 > > --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts > > +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts > > @@ -224,14 +224,11 @@ cpsw3g_phy0: ethernet-phy@0 { > > }; > > =20 > > &cpsw_port1 { > > + status =3D "okay"; > > status should be the last property, according to the dts coding guideline= s. Thanks for pointing that out. There is devicetree/bindings/dts-coding-style.rst, which is in fact new to me. Up until now, I was under the impression that how this is handled is up to the maintainer of the SoC. I know that for the NXP Layerscape for example, the maintainer will have an eye esp. for that. But here it seems kinda random/all over the place. That being said, I tried to be consistent with the other cpsw* nodes. Anyway, I'll change it to come last. > > phy-mode =3D "rgmii-rxid"; > > phy-handle =3D <&cpsw3g_phy0>; > > }; -michael --85268debbb0a249bf83d175894db0da66e51c3e05656b17bb875057ea9e9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iKgEABMJADAWIQTIVZIcOo5wfU/AngkSJzzuPgIf+AUCZg0G1BIcbXdhbGxlQGtl cm5lbC5vcmcACgkQEic87j4CH/i0pAF8Dtz9BfG4VFPzoKkZsJB4/ncZfyEy67rC g7XVK/JrcCwHEW/hAXnmXOs/cMk+J2XPAYDKbawvIqW1fdpvFoh5EKNQNSOtuAP9 YpTk1kAKNDkR8TGLeLubNsleDRzW8MdoHj4= =PWPU -----END PGP SIGNATURE----- --85268debbb0a249bf83d175894db0da66e51c3e05656b17bb875057ea9e9-- --===============6636657766466714216== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6636657766466714216==--