From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E31FC00A94 for ; Fri, 12 Apr 2024 08:53:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:From:Subject: Cc:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Dn7rK604duT2+ra7+xIINrkjkiGQYvnSzI3DxFsjFms=; b=0aKMJYp9Nnix6s hL8F4lgNFbk8ycNvFOBxUMauXsgPTE2dz6MLkql4O/LRBUnN3TppY+o/naFWb92cxJxE59QYPddz0 O7GLWqhzfjpBSVQoVPCEEJS024UAEABvOJhbO/T1t1P57uCi/f5SenUvAdNuflx+ADaZrTRsXPrEJ eBGKbSdPJLZqCoC53EL/XTCIUNnJ7jvwXvYtf47Cnb8wqOQjB01dksv6Y1s0KfaLvXXL/cTjPRPYK qxcLkDEkds9Pn4v3FHDJAsal/L6+KuuRQpl6xqnXOa6wr2zWHB4cuy4V+TUHdt+7K9Umz+GNioBSP xizH/3jk4IWiy0M+XIog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvCeR-0000000GE6l-43qf; Fri, 12 Apr 2024 08:52:51 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvCeO-0000000GE4z-2qSs for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2024 08:52:51 +0000 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-3455ff1339dso393171f8f.0 for ; Fri, 12 Apr 2024 01:52:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1712911965; x=1713516765; darn=lists.infradead.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yqg7/6oBVG7FC2A7yaPi7N20RXmvrxHvn6/HhvcSh6c=; b=Br6SKh7oLmqUoyixAgjEvWdsGvLOaT9Br53P/X8IYO1EOVoU9EIYtnbwDKGJNqy4To RduFwd3Jtu+lRiSWh4YWZ8IB7JfQjU4TkSsEJGTl1EAj/Fa2o69yc1kRY9zQFoXD4g5M 2PnCO20KZfuYpnW6LW+wUjTDx5lKuT3AcGme0EO3BitxtR05a5xO3A5MylpPDJkr/DL1 m5Z7i9UJsZBYDmuncdLrauMf4TC7tsaJlwGZcrUbwxc5CqjUnk8NeFhDfga+sofe2FxW VfEJi0D+HCzX7RUJbcVnT1p4R7LxKtV0PZxwYeSwYHiA1nyqhsDsEJ0fN1QBkaGD+j7g wOTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712911965; x=1713516765; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=yqg7/6oBVG7FC2A7yaPi7N20RXmvrxHvn6/HhvcSh6c=; b=gEpbNgbzhuGF9Sg+aITR+C4wbcCQ0TYGVl8j/0ttaU5K9tFYYAV4OT5cgyHZ5Cl0YQ 1ET7H/pgEHgRHj0I0/GNsnWvqIZWtEJ5g/jSo8TCfMZTshENiifBNXW2LTiawKSinthl 3c9IPd/+ttILwGN9ZfgyWQpxLzTmZjfe1YR1mbbn9NX4bbC/w5RhUWW3sLP7TtPaCqsR 75dcZME/EtJoA7EUNGbz7Awb6kiXhdGK52vff0hheiCp3n+x/Dpn7EMSUYKfVUYsj2sj uKHoXULy6os5v9mjQUQxRRwp+7v7wwfsTm5bJp6d/QRsG4heBlhI7jTZPnbkjSbFvgxi 5WEQ== X-Forwarded-Encrypted: i=1; AJvYcCXMEEnwD72W9G79krdBmQeUnaUdUwen4nDkjz0aC+BAcpwMHLkhB6wLEAhPZMwmhxziS5az8n75vfK+EyWWOIKczSmUup0VCKOzatXvy5FEZIJYNbU= X-Gm-Message-State: AOJu0Yx6kM17IwQhDlj1zvDAWVuxgD0jCAJgoh/6ff8LbRV3E/IS8bqs uhsuK+KIJVDngiIwtwJX64CUYfAHCd+9rNj9kEP0aWRPnevlL4eSRzIV0z9IgJI= X-Google-Smtp-Source: AGHT+IGaJEFW2OydWrtGlJEvOj+LQ9miUlniEJ47ZdatRM1Zm7j9aYX06RboRzFi8hrNNAXWEXWFlA== X-Received: by 2002:a5d:5982:0:b0:346:ba70:82f4 with SMTP id n2-20020a5d5982000000b00346ba7082f4mr2066199wri.46.1712911965458; Fri, 12 Apr 2024 01:52:45 -0700 (PDT) Received: from localhost ([2a01:e0a:448:76e0:776e:989f:b50c:7cf6]) by smtp.gmail.com with ESMTPSA id b10-20020a056000054a00b00341b7d5054bsm3783180wrf.72.2024.04.12.01.52.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Apr 2024 01:52:45 -0700 (PDT) Mime-Version: 1.0 Date: Fri, 12 Apr 2024 10:52:43 +0200 Message-Id: Cc: , , , , , , , , , , , , , , , , Subject: Re: [PATCH v6 10/11] pinctrl: pinctrl-tps6594: Add TPS65224 PMIC pinctrl and GPIO From: "Esteban Blanc" To: "Bhargav Raviprakash" , X-Mailer: aerc 0.15.2 References: <20240408124047.191895-1-bhargav.r@ltts.com> <20240408124047.191895-11-bhargav.r@ltts.com> In-Reply-To: <20240408124047.191895-11-bhargav.r@ltts.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_015248_835331_3D922084 X-CRM114-Status: GOOD ( 15.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon Apr 8, 2024 at 2:40 PM CEST, Bhargav Raviprakash wrote: > From: Nirmala Devi Mal Nadar > > Add support for TPS65224 pinctrl and GPIOs to TPS6594 driver as they have > significant functional overlap. > TPS65224 PMIC has 6 GPIOS which can be configured as GPIO or other > dedicated device functions. > > Signed-off-by: Nirmala Devi Mal Nadar > Signed-off-by: Bhargav Raviprakash > Acked-by: Linus Walleij > --- > drivers/pinctrl/pinctrl-tps6594.c | 275 +++++++++++++++++++++++++----- > 1 file changed, 228 insertions(+), 47 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-tps6594.c b/drivers/pinctrl/pinctrl-tps6594.c > index 66985e54b..f3d1c1518 100644 > --- a/drivers/pinctrl/pinctrl-tps6594.c > +++ b/drivers/pinctrl/pinctrl-tps6594.c > @@ -338,8 +506,20 @@ static int tps6594_pinctrl_probe(struct platform_device *pdev) > config.parent = tps->dev; > config.regmap = tps->regmap; > - config.ngpio = TPS6594_PINCTRL_PINS_NB; > - config.ngpio_per_reg = 8; > + switch (tps->chip_id) { > + case TPS65224: > + config.ngpio = ARRAY_SIZE(tps65224_gpio_func_group_names); > + config.ngpio_per_reg = TPS65224_NGPIO_PER_REG; > + break; > + case TPS6593: > + case TPS6594: > + config.ngpio = ARRAY_SIZE(tps6594_gpio_func_group_names); > + config.ngpio_per_reg = TPS6594_NGPIO_PER_REG; > + break; > + default: > + break; > + } Please merge the two switch case. Other than that I think it's ok. Best regards, -- Esteban "Skallwar" Blanc BayLibre _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel