From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCEC4C71157 for ; Tue, 17 Jun 2025 17:11:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:References:In-Reply-To:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4y61tvVtL+Nu9zAfwj8f/C4Um0svSaW4IhjMC/PKRbY=; b=JPrEGhsO5Aolm6xYA6GBXewVBw s8JfF0KvYE1ISyCLR5aq2pNIaJwNhklEmxPXyGI8LVSy8sxGmnAkTlGqmaPgLa4p0kV2fGmOKcjtN MLIYZNDkz+OwNvulsW466yjyAJvDnV8JQcd4HHD7bvkKWDB1g6EqmiLhC3tPrfLJ30uBAmQs7ehyr uv69m+YrdHpnImLkuGK+CxUVVLuu0Uh/QG0KjjNRxKRlFwjKnuBYx/tS0PQuNVwtmnqOww/IVyKl9 irsmLlH3Q2ojydJxQOW4cHEoUc+x5gVm1Mu8jMgQFyc+Xu9ZdpH0PA1Du+Q5GznwckJ/D744eWzey yUmogA7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uRZqh-00000007z9C-1qqI; Tue, 17 Jun 2025 17:11:51 +0000 Received: from mxout4.routing.net ([2a03:2900:1:a::9]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uRYSQ-00000007l7S-0s5o; Tue, 17 Jun 2025 15:42:43 +0000 Received: from mxbox3.masterlogin.de (unknown [192.168.10.78]) by mxout4.routing.net (Postfix) with ESMTP id C7804100949; Tue, 17 Jun 2025 15:42:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailerdienst.de; s=20200217; t=1750174954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4y61tvVtL+Nu9zAfwj8f/C4Um0svSaW4IhjMC/PKRbY=; b=tCiFaxQfSyRl2HQrruBNDzRHlIucijlwJHs9wUz8grfg4jPl8cjBHtsE9+0MXnK2mhqW77 aoemFKp3k0OyAzqkBwmpD5t4WiKrDCfkiSzPM/zuYi2jiNT6tIdvtbdMchKxj6GU3vCEOF sK7BDBpkB4XHraZiaJ4BgJsHZFFeO5A= Received: from [IPv6:::1] (unknown [IPv6:2a01:599:80e:f26f:d033:b886:5aa2:2cc2]) by mxbox3.masterlogin.de (Postfix) with ESMTPSA id 1868B360564; Tue, 17 Jun 2025 15:42:32 +0000 (UTC) Date: Tue, 17 Jun 2025 17:42:31 +0200 From: Frank Wunderlich To: Rob Herring CC: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Georgi Djakov , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , Jia-Wei Chang , Johnson Wang , =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , Landen Chao , DENG Qingfang , Sean Wang , Daniel Golle , Lorenzo Bianconi , Felix Fietkau , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v4_01/13=5D_dt-bindings=3A_n?= =?US-ASCII?Q?et=3A_mediatek=2Cnet=3A_update_for_mt7988?= User-Agent: K-9 Mail for Android In-Reply-To: <20250617151354.GA2392458-robh@kernel.org> References: <20250616095828.160900-1-linux@fw-web.de> <20250616095828.160900-2-linux@fw-web.de> <20250617151354.GA2392458-robh@kernel.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mail-ID: dc9dec3d-80df-4759-b36b-a6ba1f02e733 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250617_084242_564081_AEE265DA X-CRM114-Status: GOOD ( 11.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 17=2E Juni 2025 17:13:54 MESZ schrieb Rob Herring : >On Mon, Jun 16, 2025 at 11:58:11AM +0200, Frank Wunderlich wrote: >> From: Frank Wunderlich >>=20 >> Update binding for mt7988 which has 3 gmac and 2 reg items=2E >>=20 >> With RSS-IRQs the interrupt max-items is now 6=2E Add interrupt-names >> to make them accessible by name=2E >>=20 >> Signed-off-by: Frank Wunderlich >> --- >> v4: >> - increase max interrupts to 8 because of RSS/LRO interrupts > >But the schema says 6? Yes it was an error in changelog,see mail i sent later to you and ML=2E 8 was previously because original version had 2 reserved irqs around rx+tx i dropped later by using irq-names=2E See my patch introducing irq-names in mtk eth driver: Original (downstream/sdk) was (but=20 index-based): rsv rx tx rsv/misc rx-ring0 =2E=2E=2E rx-ring3 So total 8 and i don't wanted to add 2=20 reserved irq to dts forever so i decided moving to irq-names now=2E >> - dropped Robs RB due to this change >> - allow interrupt names >> - add interrupt-names without reserved IRQs on mt7988 >> this requires mtk driver patch: >> https://patchwork=2Ekernel=2Eorg/project/netdevbpf/patch/202506160807= 38=2E117993-2-linux@fw-web=2Ede/ >>=20 >> v2: >> - change reg to list of items >> --- >> =2E=2E=2E/devicetree/bindings/net/mediatek,net=2Eyaml | 28 +++++++++++= +++++--- >> 1 file changed, 24 insertions(+), 4 deletions(-) >>=20 >> diff --git a/Documentation/devicetree/bindings/net/mediatek,net=2Eyaml = b/Documentation/devicetree/bindings/net/mediatek,net=2Eyaml >> index 9e02fd80af83=2E=2Ef8025f73b1cb 100644 >> --- a/Documentation/devicetree/bindings/net/mediatek,net=2Eyaml >> +++ b/Documentation/devicetree/bindings/net/mediatek,net=2Eyaml >> @@ -28,7 +28,10 @@ properties: >> - ralink,rt5350-eth >> =20 >> reg: >> - maxItems: 1 >> + items: >> + - description: Register for accessing the MACs=2E >> + - description: SoC internal SRAM used for DMA operations=2E >> + minItems: 1 >> =20 >> clocks: >> minItems: 2 >> @@ -40,7 +43,11 @@ properties: >> =20 >> interrupts: >> minItems: 1 >> - maxItems: 4 >> + maxItems: 6 >> + >> + interrupt-names: >> + minItems: 1 >> + maxItems: 6 >> =20 >> power-domains: >> maxItems: 1 >> @@ -348,7 +355,17 @@ allOf: >> then: >> properties: >> interrupts: >> - minItems: 4 >> + minItems: 2 >> + >> + interrupt-names: >> + minItems: 2 >> + items: >> + - const: tx >> + - const: rx >> + - const: rx-ring0 >> + - const: rx-ring1 >> + - const: rx-ring2 >> + - const: rx-ring3 >> =20 >> clocks: >> minItems: 24 >> @@ -381,8 +398,11 @@ allOf: >> - const: xgp2 >> - const: xgp3 >> =20 >> + reg: >> + minItems: 2 >> + >> patternProperties: >> - "^mac@[0-1]$": >> + "^mac@[0-2]$": >> type: object >> unevaluatedProperties: false >> allOf: >> --=20 >> 2=2E43=2E0 >>=20 regards Frank