From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EB6EC3DA49 for ; Sat, 20 Jul 2024 21:16:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:From: To:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YmbnTSVayuh9xCsUezkE054ocy3nyuaaKWSdB0kEoFs=; b=y8PuSjud8ZEVHgr8YuB58XNmrK GcYpr07GT3eZiFS3c/DVW7VJP3lPFyowYTI35DVsI0wGfJswXoJ8M5wp7ubTmiYu8UNtxh3ef4VbH OW6wHXyWa1Dd/NssgeO2ClIbbvNdqq0r2XOyLMk/HFTPxhp0Q09y/0mu3ygvLi//fk2hghREy4Mq9 lbp5HCEr/UT72WTZUN58y/N3MEeXIItwr85uO3F6QGitbiFDkpT1M3JGhLX2wHZoUlG8hUQBIWOCU It+VzrdrRdeO0ZFCTsz3uY5Ktti7qHch46qIgUr6dX0vQC8fAxRc9iNmNbVdAgyK3cGrx3JZ6qEi3 mghCx7Ig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVHR0-00000005h2B-3rr7; Sat, 20 Jul 2024 21:16:06 +0000 Received: from mail-4322.protonmail.ch ([185.70.43.22]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVGGT-00000005aaa-0ltD for linux-arm-kernel@lists.infradead.org; Sat, 20 Jul 2024 20:01:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1721505662; x=1721764862; bh=YmbnTSVayuh9xCsUezkE054ocy3nyuaaKWSdB0kEoFs=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=cSLgwC4gi+se0y0KCM3doAGXdpLJm29ewhKn7tK5tF13FZ+lS6iZHV5s2UHeFAZqs DfY3lYfKwdv9EBDObG+fhkXqnKbnyud1DGjoCHndxXssZs4F7YZfjysa3j2VH47nCF rpSE86hm36nOTYbntG2O3/EQ7+kmjORq7d8TJFEX9Fa1kgY0w/Yquh7MkmJXsk1R+1 CYyNobRn2Dof6+Q4NUbkGPm55oMxCnepHjTqj94BNQ2LgmuMIsYCsNGBzWL1QSuElT VSK0NUllbF+r1FOYd5rG/1jNE4mXWGeyjLGt+E33mGJ27veDL+D1Gsm9D8/m9PnDDI 33gO+aJWHxZyg== Date: Sat, 20 Jul 2024 20:00:45 +0000 To: Rob Herring From: Harry Austen Cc: Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Conor Dooley , Michal Simek , Shubhrajyoti Datta , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/7] dt-bindings: clock: xilinx: add description of user monitor interrupt Message-ID: In-Reply-To: <20240720143708.GA239850-robh@kernel.org> References: <20240720120048.36758-1-hpausten@protonmail.com> <20240720120048.36758-5-hpausten@protonmail.com> <20240720143708.GA239850-robh@kernel.org> Feedback-ID: 53116287:user:proton X-Pm-Message-ID: aef34513ce9d61c0df9f689adb1cde03b2dc7ae1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240720_130109_463510_A4291EC7 X-CRM114-Status: GOOD ( 16.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat Jul 20, 2024 at 3:37 PM BST, Rob Herring wrote: > On Sat, Jul 20, 2024 at 12:01:48PM +0000, Harry Austen wrote: > > This Xilinx clocking wizard IP core outputs this interrupt signal to > > indicate when one of the four optional user clock inputs is either > > stopped, overruns, underruns or glitches. > > > > This functionality was only added from version 6.0 onwards, so restrict > > it to particular compatible strings. > > > > Signed-off-by: Harry Austen > > --- > > .../bindings/clock/xlnx,clocking-wizard.yaml | 22 ++++++++++++++++++- > > 1 file changed, 21 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/clock/xlnx,clocking-wiza= rd.yaml b/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml > > index 9d5324dc1027a..4609bb56b06b5 100644 > > --- a/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml > > +++ b/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml > > @@ -62,17 +62,37 @@ required: > > - xlnx,speed-grade > > - xlnx,nr-outputs > > > > +allOf: > > + - if: > > + properties: > > + compatible: > > + enum: > > + - xlnx,clocking-wizard-v6.0 > > + - xlnx,versal-clk-wizard > > + then: > > + properties: > > + interrupts: > > + items: > > + - description: user clock monitor interrupt > > + > > + interrupt-names: > > + items: > > + - const: monitor > > Properties need to be defined at the top-level (outside the if/then > schema), then restricted here. Makes sense. Will do in v2. Thanks for the review! > > > + > > additionalProperties: false > > > > examples: > > - | > > + #include > > clock-controller@b0000000 { > > - compatible =3D "xlnx,clocking-wizard"; > > + compatible =3D "xlnx,clocking-wizard-v6.0"; > > reg =3D <0xb0000000 0x10000>; > > #clock-cells =3D <1>; > > xlnx,speed-grade =3D <1>; > > xlnx,nr-outputs =3D <6>; > > clock-names =3D "clk_in1", "s_axi_aclk"; > > clocks =3D <&clkc 15>, <&clkc 15>; > > + interrupts-extended =3D <&intc 52 IRQ_TYPE_EDGE_RISING>; > > + interrupt-names =3D "monitor"; > > }; > > ... > > -- > > 2.45.2 > > > >