linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH v2 11/12] arm64: dts: rockchip: Add rk3576 SoC base DT
       [not found] <23624422.6Emhk5qWAg@trenzalore>
@ 2024-08-25 14:08 ` Chukun Pan
       [not found]   ` <22403959.EfDdHjke4D@bootstrap>
  0 siblings, 1 reply; 2+ messages in thread
From: Chukun Pan @ 2024-08-25 14:08 UTC (permalink / raw)
  To: detlev.casanova
  Cc: airlied, alchark, amadeus, andi.shyti, andyshrk, broonie, cl,
	conor+dt, daniel, devicetree, dri-devel, dsimic, efectn,
	finley.xiao, gregkh, heiko, honyuenkwun, jagan, jamie, jic23,
	jirislaby, jonas, jszhang, kernel, krzk+dt, lars, lee,
	linux-arm-kernel, linux-i2c, linux-iio, linux-kernel, linux-mmc,
	linux-rockchip, linux-serial, linux-spi, linux-watchdog, linux,
	maarten.lankhorst, macromorgan, megi, michael.riesch, mripard,
	robh, tim, tzimmermann, ulf.hansson, wim

Hi,

> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> ...
> +		opp-1416000000 {
> +			opp-hz = /bits/ 64 <1416000000>;
> +			opp-microvolt = <725000 725000 950000>;
> +			opp-microvolt-L1 = <712500 712500 950000>;
> +			opp-microvolt-L2 = <700000 700000 950000>;
> +			opp-microvolt-L3 = <700000 700000 950000>;
> +			opp-microvolt-L4 = <700000 700000 950000>;
> +			opp-microvolt-L5 = <700000 700000 950000>;
> +			clock-latency-ns = <40000>;
> +		};
> ...

I'm curious if these frequencies work properly. On the bsp kernel,
'opp-microvolt-L<name>' is used by the PVTM driver, I don't know
if it works on the upstream kernel. Sorry but have you tested it
with mhz (https://github.com/wtarreau/mhz)?

Thanks,
Chukun

-- 
2.25.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2 11/12] arm64: dts: rockchip: Add rk3576 SoC base DT
       [not found]   ` <22403959.EfDdHjke4D@bootstrap>
@ 2024-08-26 19:56     ` Diederik de Haas
  0 siblings, 0 replies; 2+ messages in thread
From: Diederik de Haas @ 2024-08-26 19:56 UTC (permalink / raw)
  To: Detlev Casanova, Chukun Pan
  Cc: airlied, alchark, andi.shyti, andyshrk, broonie, cl, conor+dt,
	daniel, devicetree, dri-devel, dsimic, efectn, finley.xiao,
	gregkh, heiko, honyuenkwun, jagan, jamie, jic23, jirislaby, jonas,
	jszhang, kernel, krzk+dt, lars, lee, linux-arm-kernel, linux-i2c,
	linux-iio, linux-kernel, linux-mmc, linux-rockchip, linux-serial,
	linux-spi, linux-watchdog, linux, maarten.lankhorst, macromorgan,
	megi, michael.riesch, mripard, robh, tim, tzimmermann,
	ulf.hansson, wim

[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]

On Mon Aug 26, 2024 at 8:28 PM CEST, Detlev Casanova wrote:
> On Sunday, 25 August 2024 10:08:24 EDT Chukun Pan wrote:
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> > > ...
> > > +		opp-1416000000 {
> > > +			opp-hz = /bits/ 64 <1416000000>;
> > > +			opp-microvolt = <725000 725000 950000>;
> > > +			opp-microvolt-L1 = <712500 712500 950000>;
> > > +			opp-microvolt-L2 = <700000 700000 950000>;
> > > +			opp-microvolt-L3 = <700000 700000 950000>;
> > > +			opp-microvolt-L4 = <700000 700000 950000>;
> > > +			opp-microvolt-L5 = <700000 700000 950000>;
> > > +			clock-latency-ns = <40000>;
> > > +		};
> > > ...
> > 
> > I'm curious if these frequencies work properly. On the bsp kernel,
> > 'opp-microvolt-L<name>' is used by the PVTM driver, I don't know
> > if it works on the upstream kernel.
>
> Which seems to correspond to the set opp-hz value. As mentionned by Alexey, 
> the opp-microvolt-L.* values are not used by the driver.
>
> I also have not tested any cpufreq settings/driver on this board yet. I can 
> remove the opp-microvolt-L.* for now.

If you run this command on the upstream kernel:
``grep -r "opp-microvolt" arch/arm64/boot/dts/rockchip/``

you'll see it doesn't use the opp-microvolt-LN variants anywhere,
so this is indeed a downstream/BSP only thing.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-08-26 19:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <23624422.6Emhk5qWAg@trenzalore>
2024-08-25 14:08 ` [PATCH v2 11/12] arm64: dts: rockchip: Add rk3576 SoC base DT Chukun Pan
     [not found]   ` <22403959.EfDdHjke4D@bootstrap>
2024-08-26 19:56     ` Diederik de Haas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).