From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C38CCD5BB7 for ; Thu, 5 Sep 2024 12:23:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To: From:Subject:Cc:Message-Id:Date:Content-Type:Mime-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m0upCeZNrvDUQnDPHLYGuminqK/9oN+kaTuNQFta8ZQ=; b=ZJ6vqTfs6Rb8G2ZrzrB12XHLm2 Ivb5SdvN0Weu1L5iWhqJcl18cvIervVFfwR+V/rQg9YTp3cw+QHbSYEQY9DA/NvDZhEdGtvMN8cv9 rJ4pmJszUEwXxNJ9mKcG5rET9Iztg1/IHsnlRV5584AqHZdTVXDGWjT0xGo+lOwHasJfhy5CxqK72 EFwn31/89EvJmIgqYlfeRse/lTMbgLHzMqgXGoPne/edG0mLFL4lqunG1ts3lWh65nRb/ZWA2K57a Ka1CimUYv3N84b1o2fFv6FoeKEeeJqOVyWVV/GhekJIzvlCLUdPwUDk36WkUkfs2vexON1VPhFdnl vtK/7Ghw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smBWC-00000008I4U-1DPa; Thu, 05 Sep 2024 12:23:20 +0000 Received: from out-182.mta1.migadu.com ([2001:41d0:203:375::b6]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smBUM-00000008HY4-05cn for linux-arm-kernel@lists.infradead.org; Thu, 05 Sep 2024 12:21:28 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1725538881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m0upCeZNrvDUQnDPHLYGuminqK/9oN+kaTuNQFta8ZQ=; b=zp8p7HP3ol+AN7+2w0u8sw3feRS6+EtQvIxCq07dq9Dksj1BTJW2+cqNyFjtKP6ganjaEn yRNrdKSMcY/zfUd8lPaFdyuO200HIfl9M0UYYVq+QjhfTeeHWi3ZsXLlJI/TiAsATCV/lL veM7whyuJj/XoEN2jpV4SpdNDhvZug15hXJg+oub6sWMNS2+cB/OUt0lAoVp2pFnJ7qL2j SqaBjowIo9rVkcQwbGsTr0xQhJHz0c8SGtIc0svjbcOf+GIlorwOBqTw4aNVmdWlAEsRFN ylbUhCkexhSvxeUXkNtWjgLL7n/y9GT0QxkzY2rzCRTpBPMhUMgjMPRxu1j2AA== Content-Type: multipart/signed; boundary=2d312f426b36611740239ff3b0c317c3ffbb2d79eaae2fd1cbf4292c25aa; micalg=pgp-sha256; protocol="application/pgp-signature" Date: Thu, 05 Sep 2024 14:21:12 +0200 Message-Id: Cc: , , , , , , Subject: Re: [PATCH] arm64: dts: rockchip: Add a few aliases to the PineTab2 dtsi X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Krzysztof Kozlowski" , "Dragan Simic" , References: <987e68d1c5e9a0cc56d730aec87246aa5ab8ea14.1725535770.git.dsimic@manjaro.org> In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240905_052126_678287_37404A41 X-CRM114-Status: GOOD ( 16.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --2d312f426b36611740239ff3b0c317c3ffbb2d79eaae2fd1cbf4292c25aa Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Thu Sep 5, 2024 at 1:39 PM CEST, Krzysztof Kozlowski wrote: > On 05/09/2024 13:32, Dragan Simic wrote: > > Sprinkle a few commonly used aliases onto the PineTab2 dtsi file, to im= prove > > its readability a bit, to make it easier to refer to the actual nodes l= ater, > > if needed, and to add a bit more detail to some of the labels. > >=20 > > Suggested-by: Diederik de Haas > > Signed-off-by: Dragan Simic > > Unused aliases do not improve readability, so for me this change is > making code worse without valid reason. This came forth by a question from me to Dragan about a patch for another board which doesn't have a charger defined at all (yet). I actually have that patch (but not the HW) for a while (~1.5 year) now and I had used `rk817_charger: charger` for that, probably because I saw that being used everywhere else. Then I compared it to the PineTab2 and noticed it had only `charger`, so I asked "What should I use? With or without the alias?" In this case the inconsistency is causing confusion (with me). So: What should be used for that other/new board(s)? Cheers, Diederik --2d312f426b36611740239ff3b0c317c3ffbb2d79eaae2fd1cbf4292c25aa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZtmiOgAKCRDXblvOeH7b bivAAQChtRQ4JLxi+OzTHCGMxlshCxBB/+x9r0QIrUHdVfc2oAD/W0i0uuf14sm/ WIQpeeE4yYyvBIzmSAeyyCQ1XcoRYgw= =dEN9 -----END PGP SIGNATURE----- --2d312f426b36611740239ff3b0c317c3ffbb2d79eaae2fd1cbf4292c25aa--