From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49763CE7AF8 for ; Fri, 6 Sep 2024 09:39:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To: From:Subject:Cc:Message-Id:Date:Content-Type:Mime-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=be7bi10a61hIs7OOh5j48QgrRwW9Uv9WavYfuDp8rzM=; b=hN37FGwUnKb8CHQfPWs89iDG9g 3LipCaDL3VsHGvCDBm/SPidMyAke/K8Ptiqqy2tf+QOChm6Fr8mY44MuIHAR4ZFTcnpZSgilXNIf9 XgfNuDwOr3xtcOxlxgOz+8I0pA/yrJ+mgbtwQYSd3tSdmlMQIT01oPhagVmIi+0helOAcIiGTe/ZZ EGLkrKixEwAGyJlcFKtvlWBLF1/Mzu4r0yub0z0GjuKemoMWssEGDqakCCzdxofdACqsFAlDEp4Fo wsBgcZ4NxRDEd3ZBGfA8oYaQ2kZM+ssWR4Nk4haOBeG8FrEbtZvY3sLVCPbHB4/BFyGCNikaksONH Sdf3OIcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smVRB-0000000BY4p-2nV1; Fri, 06 Sep 2024 09:39:29 +0000 Received: from out-183.mta0.migadu.com ([91.218.175.183]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smVGk-0000000BVjX-2s1f for linux-arm-kernel@lists.infradead.org; Fri, 06 Sep 2024 09:28:44 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1725614919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=be7bi10a61hIs7OOh5j48QgrRwW9Uv9WavYfuDp8rzM=; b=Po95yllGLdAdag4YSuvzKSp6Qem9ZD9GNtMMojIPdfCiuv87PmBVVwQBQuoVlrs+z4AGAY xALn1S5D47Ni2L+F1dJ6QgXHx0eW3bOIzamOz57i0Dj0JxE0u3iHPpGaxME/JLpKpKOpjA AXPM6Xgy5HLcFUDP19Zs8FJlHYufM5wlfZPWgqp7fV93VjyrXUTvV1fFm2qhUsFMofx737 +quHYGiji2cyFFIwoHxlARLUT65HVkMI1Nwv7aGI8MUMlqNTeUUUB/ExJHnFgfQJUaQz3v c0ovAdTDTDplpeMh9Deumn9Jmv+/0Dqs4W/NVrZeota3CSriNMutiN7vt2aoDA== Content-Type: multipart/signed; boundary=90251523fbbd216b6fd8d265a28b65ea30f3d99c5d6460b75d286064d840; micalg=pgp-sha256; protocol="application/pgp-signature" Date: Fri, 06 Sep 2024 11:28:33 +0200 Message-Id: Cc: "Sandy Huang" , =?utf-8?q?Heiko_St=C3=BCbner?= , "Andy Yan" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Daniel Vetter" , , , , Subject: Re: [PATCH] drm/rockchip: include rockchip_drm_drv.h X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Andy Yan" , "Min-Hua Chen" References: <20240905223852.188355-1-minhuadotchen@gmail.com> <6f07603.7f9.191c4c887b1.Coremail.andyshrk@163.com> In-Reply-To: <6f07603.7f9.191c4c887b1.Coremail.andyshrk@163.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240906_022842_879658_2D35B873 X-CRM114-Status: GOOD ( 12.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --90251523fbbd216b6fd8d265a28b65ea30f3d99c5d6460b75d286064d840 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Fri Sep 6, 2024 at 2:42 AM CEST, Andy Yan wrote: > At 2024-09-06 06:38:50, "Min-Hua Chen" wrote: > >Include rockchip_drm_drv.h to fix the follow sparse warning: > > > >drivers/gpu/drm/rockchip/rockchip_vop2_reg.c:502:24: sparse: > >warning: symbol 'vop2_platform_driver' was not declared. > >Should it be static? > > > >No functional change intended. > > > >Signed-off-by: Min-Hua Chen > >--- > > drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/= drm/rockchip/rockchip_vop2_reg.c > >index 18efb3fe1c00..c678d1b0fd7c 100644 > >--- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c > >+++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c > >@@ -14,6 +14,7 @@ > > #include > >=20 > > #include "rockchip_drm_vop2.h" > >+#include "rockchip_drm_drv.h" > >=20 > > We already have a patch[0] include rockchip_drm_drv.h in rockchip_drm_vop= 2.h > > [0]https://patchwork.kernel.org/project/linux-rockchip/patch/202409041202= 38.3856782-3-andyshrk@163.com/=20 Maybe I'm missing something, but this patch seems to fix an already existing bug (which should have a Fixes tag?), which Andy also fixed while implementing a different (and unrelated) feature? Cheers, Diederik --90251523fbbd216b6fd8d265a28b65ea30f3d99c5d6460b75d286064d840 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZtrLRwAKCRDXblvOeH7b bk/qAQDPHdbej4aC0ukgU/dbB+KKBekdjOZZD5I3sUS8I7Bd4wEAuK0ILSqPfD+n L9LK3ogtrQ6CGzdsFsQ4YBi2P4hwUwA= =eQVK -----END PGP SIGNATURE----- --90251523fbbd216b6fd8d265a28b65ea30f3d99c5d6460b75d286064d840--