From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7783AE6FE4B for ; Sat, 7 Sep 2024 08:48:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:From: Subject:Cc:To:Message-Id:Date:Content-Type:Mime-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U/V4gJDEeseX5jQFeW0yYA0toqnpKY469k3mQ17ssiw=; b=zA1KsfEhRYMVBCvp0gboTgWw03 RgsQxTTDDda/Oj/wZEV6/IEl8bs2NFR4Iw4zvL+q/CAeg7W1AFG0/bIsf8q0bhCuu3SovNFKXeJHO Pz0rBIuNZoV1PXGnuz9WtGtVveUUFvog89eZyu9irNxXc7Nw7VQ8a/Yzacu1c6cbaqMABz7mEfzi7 b1nCiFvyhSWRtOgoGH5pXSzD1ieis9/PmYXujGVEuQQ/5iRXhcWzrWSshmFE6yZ605njH02O76+Fn VvKqaW3wXcSbX1J1PzCa/VKug7FHE6Pmhbwgpwnn3wt/Zf9UE0CIxyrTZeBBcxFPyxvMiTq1Vx7EP JIH8DSNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smr7V-0000000Eh7G-0NxI; Sat, 07 Sep 2024 08:48:37 +0000 Received: from out-189.mta0.migadu.com ([91.218.175.189]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smr6U-0000000EgzW-0WlY for linux-arm-kernel@lists.infradead.org; Sat, 07 Sep 2024 08:47:36 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1725698849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U/V4gJDEeseX5jQFeW0yYA0toqnpKY469k3mQ17ssiw=; b=wQkj4bC+WErNtAEm8BxqIHn2dlwtM4UpfbVG4kVsVCFyPcyJn1hfJUAI3PAIatPtYMw6uh 0MUlu+Wy4C0/RtBqiSyAsTiqtu8ayeMonmgPbJaWaKFR9Wd65RyQK3Iu7j0zt1nJtV/y5A VmmjmG8EsLLzjvL2O4YsHVzt6tVMvSV6sSmCC2QL0yHzHn3NZqnDA5FPGRpop315vUTMx6 2tGNMflQrIP6EzT/fbsSpBZH8+OS81BkYsYv+y7rd+fKvRSnBKvSUDpOtS95robjbLhpYk xTf2LWG6bsf64yAHsqCtCbxFJuCOrfB4AqyVA45T0OF/EcnLtjaUNYNHbjAFNw== Content-Type: multipart/signed; boundary=ae02d6677900286bbc830f90aa3ab8aa0d85c0a15f3e902cf9eb68b94b65; micalg=pgp-sha256; protocol="application/pgp-signature" Date: Sat, 07 Sep 2024 10:47:18 +0200 Message-Id: To: "Min-Hua Chen" Cc: , , , , , , , , , , , , Subject: Re: [PATCH] drm/rockchip: include rockchip_drm_drv.h X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" References: <20240907030259.1243487-1-minhuadotchen@gmail.com> In-Reply-To: <20240907030259.1243487-1-minhuadotchen@gmail.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240907_014734_604063_0D671371 X-CRM114-Status: GOOD ( 10.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --ae02d6677900286bbc830f90aa3ab8aa0d85c0a15f3e902cf9eb68b94b65 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Sat Sep 7, 2024 at 5:02 AM CEST, Min-Hua Chen wrote: > >FWIW: I didn't see it either, but I assumed I was missing the right > >context (i.e. patches) needed to trigger that warning. > > I triggered the warning by the following step: > > install 'sparse' first > > ARCH=3Darm64 LLVM=3D1 make C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDI= AN__' mrproper defconfig all -j8 This, especially the 'LLVM' part, is important context information and should be part of the commit message. I had only just started when I saw a number of sparse warnings: DTC arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6a-io.dtb OVL arch/arm64/boot/dts/ti/k3-j721e-evm.dtb OVL arch/arm64/boot/dts/ti/k3-j721s2-evm.dtb OVL arch/arm64/boot/dts/ti/k3-am654-idk.dtb DTC arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dtb DTC arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6a-wifi.dtbo DTC arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dtb DTC arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6b-io.dtb DTC arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dtb DTC arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9.dtb ../init/main.c:192:12: sparse: warning: symbol 'envp_init' was not declared= . Should it be static? ../init/main.c:290:16: sparse: warning: cast to restricted __le32 ../init/main.c:291:16: sparse: warning: cast to restricted __le32 CHECK ../init/do_mounts.c And several followed, including in c-code files. So I stopped the build and assume you've identified a or several actual issues. I've seen several commits where changes were made because LLVM flagged potentially problematic code, where GCC did not, so it's quite possible you're on to something here. But it would be helpful if the commit message said what code was potentially problematic and why. And then the proper fix for that could indeed be to include `rockchip_drm_drv.h`. Cheers, Diederik --ae02d6677900286bbc830f90aa3ab8aa0d85c0a15f3e902cf9eb68b94b65 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZtwTGQAKCRDXblvOeH7b bjrVAP9sF01iIKgasYGx4OaHq+E2M92V0wabM3HMo2iTFErnoQEAkAD2CVBFzBtD wMom4q6z9MP5ClefkbqycuAelKYGkAU= =iQLh -----END PGP SIGNATURE----- --ae02d6677900286bbc830f90aa3ab8aa0d85c0a15f3e902cf9eb68b94b65--