From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBFC9EB64DE for ; Tue, 10 Sep 2024 13:59:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References: Subject:From:To:Cc:Message-Id:Date:Content-Type:Content-Transfer-Encoding: Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+5qKRpXx/yX0uSjdpqTnr+3shh0+e1DrLOHMnv76MDo=; b=yDPV7q3XAkRNTNIISao8n+k3p1 psmY1pOPmR6sJzBFTY8a0av0Q5Vou5+G7YzrEdtp0aHUNpEaHtd64/fc6rpDhNy0VvuOU3SwSL5CR BLRlrWj4gyyr8aXgOeJdoA+G0qSS5CJ9ifgEMy4UT74eGTsHk9PMb8d8Nuf7N7cIBiV0AlEHN30MT Jddtmm7SoMaoXMCdk+BpvRZYwZ1SNaqKSsFNaNXjbgEVLmRgjZd4jWaNJGlp0Tlnmu5xm5ArK0yIb iTeaDkLAUFDzybgivLUkrN6xx5d6SK7BWz0+nrozkGkRnhFzr171rygWfQM9lxzysB5PeOmbLHIub x7aZ2AuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1so1OM-00000005nH7-0DtR; Tue, 10 Sep 2024 13:58:50 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1so1NI-00000005n4m-3hQF for linux-arm-kernel@lists.infradead.org; Tue, 10 Sep 2024 13:57:46 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 64B7A1C0002; Tue, 10 Sep 2024 13:57:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1725976661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+5qKRpXx/yX0uSjdpqTnr+3shh0+e1DrLOHMnv76MDo=; b=gQFhDQHZXhP2exQYhIS1YAURc1OirprONZJMYY64MBwxflZ6URRSq1uOlymHPWgauSd778 PbJhbKbjfLdvxTZh5HLxTpf73lK/p5NLb8Cz8PuvF4qekNIEt8z64EmHvXnJ6RhF4aT10x KSzbElzWG+QIqFXgXegY1c8xHumzrShzzllQrDnvgH3/+5Z5ZruzmbPrQdz3MRGclyWVuZ kE9RyApX2I4zVX9YRGluH+XhS2rYXlw8E9BfoEC07OBdRx9kHURtZKJEjliA6r6b0+WYed UkicjFEWmCqsxNKv93rR9kZtCXMUNdVP7Y255EtzRHuSMK7nG9+ABDttIXSMmQ== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 10 Sep 2024 15:57:40 +0200 Message-Id: Cc: , , , , "Kevin Hilman" , =?utf-8?q?Gr=C3=A9gory_Clement?= , "Thomas Petazzoni" To: "Roger Quadros" , "Greg Kroah-Hartman" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Peter Chen" , "Pawel Laszczak" , "Mathias Nyman" , "Nishanth Menon" , "Vignesh Raghavendra" , "Tero Kristo" From: =?utf-8?q?Th=C3=A9o_Lebrun?= Subject: Re: [PATCH v5 07/12] usb: cdns3-ti: add J7200 support with reset-on-resume behavior X-Mailer: aerc 0.18.2-0-ge037c095a049 References: <20240726-s2r-cdns-v5-0-8664bfb032ac@bootlin.com> <20240726-s2r-cdns-v5-7-8664bfb032ac@bootlin.com> <0a634553-023c-4a46-8743-28357021c689@kernel.org> In-Reply-To: <0a634553-023c-4a46-8743-28357021c689@kernel.org> X-GND-Sasl: theo.lebrun@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240910_065745_241746_067A7579 X-CRM114-Status: GOOD ( 17.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon Aug 5, 2024 at 3:54 PM CEST, Roger Quadros wrote: > On 26/07/2024 21:17, Th=C3=A9o Lebrun wrote: > > Add ti,j7200-usb compatible. Match data indicates the controller resets > > on resume which tells that to the cdns3 core. This in turn silences a > > xHCI warning visible in cases of unexpected resets. > >=20 > > We also inherit the errata quirk CDNS3_DRD_SUSPEND_RESIDENCY_ENABLE fro= m > > the default `cdns_ti_auxdata` configuration. > >=20 > > Signed-off-by: Th=C3=A9o Lebrun > > --- > > drivers/usb/cdns3/cdns3-ti.c | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > >=20 > > diff --git a/drivers/usb/cdns3/cdns3-ti.c b/drivers/usb/cdns3/cdns3-ti.= c > > index 159814dfc856..65b8b6f4c654 100644 > > --- a/drivers/usb/cdns3/cdns3-ti.c > > +++ b/drivers/usb/cdns3/cdns3-ti.c > > @@ -258,7 +258,21 @@ static const struct of_dev_auxdata cdns_ti_auxdata= [] =3D { > > {}, > > }; > > =20 > > +static struct cdns3_platform_data cdns_ti_j7200_pdata =3D { > > + .quirks =3D CDNS3_RESET_ON_RESUME | > > But you mentioned that the behavior can be different based on which > idle state the system went into. > Setting this flag will means Reset is required on every resume. No, this flag's only behavior is to enable XHCI_RESET_ON_RESUME in the lower xHCI stack. Code is in __cdns_host_init(): if (cdns->pdata && (cdns->pdata->quirks & CDNS3_RESET_ON_RESUME)) cdns->xhci_plat_data->quirks |=3D XHCI_RESET_ON_RESUME; > Instead, you just need to rely on the runtime check and set the xhci->los= t_power flag at resume. I argued about my view of the XHCI_RESET_ON_RESUME quirk under [PATCH v5 09/12]. https://lore.kernel.org/lkml/D42NIH63EHZG.KKWZR2WZB68L@bootlin.com/ Regards, -- Th=C3=A9o Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com