From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 384B7CF9C64 for ; Sun, 22 Sep 2024 10:34:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:From: Subject:Cc:To:Message-Id:Date:Content-Type:Mime-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rh5mxOysEWdlr7zB3dIq9Xe2btAHsCpup+ruaFZk4EM=; b=K2Idlehmzm2w3G85cpeUm3Jc5h Q5VmSf7Zatjd/ncEonEfXzaa20xOCMmCfZHLQaCJEvIgtMNXZzsiSJ/ina3xZawvw+BhK0Wgt9S4Q rf35VbQMer+YuV99c+5pVmsKlOk211mo+LI2k8eHJcNOAlGgBJFSTT8FtMijCs7oLkV/3jtgru87K EprGtmnZpgIIA8GVoRWhjPllQgdj0KDIb2X0lYKAutr9X0vallLwwD3awit3sIvlbyweDF/OC8KPH zQc8kO6be4hsX2wamMOpi6SPTUAancRbKdoHy4JHf2+aC2tjYnKumJD0gM40qL9Y0oBReou3xgKjD 5imHFcYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1ssJvI-0000000Eze9-1UlS; Sun, 22 Sep 2024 10:34:36 +0000 Received: from out-171.mta0.migadu.com ([2001:41d0:1004:224b::ab]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1ssJuB-0000000EzUg-04cN for linux-arm-kernel@lists.infradead.org; Sun, 22 Sep 2024 10:33:28 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1727001195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rh5mxOysEWdlr7zB3dIq9Xe2btAHsCpup+ruaFZk4EM=; b=KhKdHH4ObK+KAa3ylcl/wZq36CKLW9XGQbMTs3L/PVLTKtzN6mah6aJfCG38zpVnZ9+WWU FN9Yu0Uj7sgJ7XXprTjbI6UVwNg5ynCR49Xon30JpoX3Pxd/H16jLNAZjzSA9ERIyqS5Qr CledCoNU9+F591nNaaPK/hIx5LBdCDNLDxO/HLUEkmD4RTm6EOdcNuxs9Y2atEyUD1lIWx BsooqPkyy/7oHJbcCdkfIJ4YWK+wlfinkjt7sOSXt22w1uRBqecWy0Mt9YeQHONeYEtB95 OGSa+w1znwU/9ks2KwjbP9CZgwfMUwuASQshHjGt3NgnA2w1dMNLr63HdNHLDQ== Content-Type: multipart/signed; boundary=cf4d01d20a3b9d5a9a49968868fe9e6d1f0f8308e15edb5bdb79c6fb1446; micalg=pgp-sha256; protocol="application/pgp-signature" Date: Sun, 22 Sep 2024 12:33:05 +0200 Message-Id: To: "Andy Yan" , Cc: , , , , , , , , , , , , , "Andy Yan" Subject: Re: [PATCH v3 06/15] drm/rockchip: vop2: include rockchip_drm_drv.h X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" References: <20240920081626.6433-1-andyshrk@163.com> <20240920082122.6742-1-andyshrk@163.com> In-Reply-To: <20240920082122.6742-1-andyshrk@163.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240922_033327_207061_9C89156A X-CRM114-Status: GOOD ( 17.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --cf4d01d20a3b9d5a9a49968868fe9e6d1f0f8308e15edb5bdb79c6fb1446 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Fri Sep 20, 2024 at 10:21 AM CEST, Andy Yan wrote: > From: Andy Yan Maybe ``From: Min-Hua Chen ``? It's very minor and Min-Hua gave their 'Reviewed-by' tag to your patch, but they found the problem and I thought it was just for practical reasons you made it part of this patch set. > Move rockchip_drm_drv.h in rockchip_drm_vop2.h to fix the follow > sparse warning: > > ARCH=3Darm64 LLVM=3D1 make C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDI= AN__' > mrproper defconfig all -j12 > > drivers/gpu/drm/rockchip/rockchip_vop2_reg.c:502:24: sparse: > warning: symbol 'vop2_platform_driver' was not declared. Should it > be static? > > It is also beneficial for the upcoming support for rk3576. > > Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") > Signed-off-by: Andy Yan > Signed-off-by: Min-Hua Chen > > --- > > Changes in v3: > - Split it from 10/15, as it fix a exiting compile warning. > > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 - > drivers/gpu/drm/rockchip/rockchip_drm_vop2.h | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/d= rm/rockchip/rockchip_drm_vop2.c > index 4776a227e62c..a7f9f88869a6 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > @@ -35,7 +35,6 @@ > #include > #include > =20 > -#include "rockchip_drm_drv.h" > #include "rockchip_drm_gem.h" > #include "rockchip_drm_vop2.h" > #include "rockchip_rgb.h" > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.h b/drivers/gpu/d= rm/rockchip/rockchip_drm_vop2.h > index 59cd6b933bfb..bc001f715847 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.h > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.h > @@ -9,6 +9,7 @@ > =20 > #include > #include > +#include "rockchip_drm_drv.h" > #include "rockchip_drm_vop.h" > =20 > #define VOP2_VP_FEATURE_OUTPUT_10BIT BIT(0) --cf4d01d20a3b9d5a9a49968868fe9e6d1f0f8308e15edb5bdb79c6fb1446 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZu/yZAAKCRDXblvOeH7b bhyOAQCgfugbYkLTEQoVYnYjY2LIP0tmj3SFSFrsw3hSRtqOHwD/cMGxEu1QU1Nj DLQj4kuQxg314p3e5CtjLIAFUNlzLQI= =a3i5 -----END PGP SIGNATURE----- --cf4d01d20a3b9d5a9a49968868fe9e6d1f0f8308e15edb5bdb79c6fb1446--