From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 382D9CFB442 for ; Mon, 7 Oct 2024 08:21:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To: From:Cc:Subject:Message-Id:Date:Content-Type:Reply-To:MIME-Version: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NZvOO50nrC5N5yhjICHHQgo08L6Oty7PXHlfa8iHZSg=; b=cbxR6Fjyyl8Tv3ZRArz5me46Wq CcD/3fjcN/H05ZJCBwN8G4b/BdVnNoEFuKZxfrfJvUOgPODowdGvSc2nrj2RlxoHPYkue3T6NBq/j SnPQARJz101IyIrDl3LNXnXc5yVg9Np9z8XZ2JeghFjtCI77XZSqC1/okjS9s8cz++oUxHwxLAFMP b/IZJZdpUJPW9G5b8jsOEkL7xvjYM+KFTUpwpLsQEcXVDdL8ehPghPEpjbp3jBYPn5L3m4fTzX2J3 5LipFOzPt79m1CmnfkLtUHZevjqgD8IZq6kDTwWIqIgzZJjhHhXAOkW9L/CnusTm971L4fD0jnaEs kR7I1pNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sxize-00000001jyP-0XoC; Mon, 07 Oct 2024 08:21:26 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sxiVx-00000001eqv-1Fsx; Mon, 07 Oct 2024 07:50:46 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E0A5C5C54C1; Mon, 7 Oct 2024 07:50:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 557DBC4CEC6; Mon, 7 Oct 2024 07:50:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728287443; bh=LZwLhPcihpVwhqUd44bHekSn+fvPmdtdSBIxwelAqgU=; h=Date:Subject:Cc:From:To:References:In-Reply-To:From; b=GK8EWprjujC9Tfvzj6WVPbnrV2bF6TKHAk2EAEqU41FrNmpVkNiQZ4sJBWYAqDWEF 0KB9XVHtxTc7/rv21PlOB0YBw46iOu9cX+WnSX79m0cVdJgDQ84i4HRjL0c6vmxOuX DQr5O05dm1qtHgasFGHJk5B/52rCgL68ohQme0HRkOBqeYUwn7zHI6BReTf+NX3FI+ vbcHvcuquWjy1orykoi97YVXsCVD3t/5RvJ65AYRqu8YmjgwryBldzdRVQg4aT1fP7 n0VxLzbNachbfkfInMr9jW5/2OIYYy3d+CZRgu0U/hVziwX9tbzzCHckyPYWvm1K7w 1/CDpp+F5UmLA== Content-Type: multipart/signed; boundary=4f89559e3e3addf49573992635c3f51e2eb8df6bf427dc56eda58fc4e794; micalg=pgp-sha384; protocol="application/pgp-signature" Date: Mon, 07 Oct 2024 09:50:39 +0200 Message-Id: Subject: Re: [PATCH v2 2/3] mtd: spi-nor: support vcc-supply regulator Cc: "Rob Herring" , "Conor Dooley" , "Fabio Estevam" , "Vignesh Raghavendra" , , , "Richard Weinberger" , "Sascha Hauer" , "Marco Felsch" , , "Tudor Ambarus" , , , "Pengutronix Kernel Team" , "Miquel Raynal" , "Krzysztof Kozlowski" , "Shawn Guo" , "Peng Fan" , "Pratyush Yadav" From: "Michael Walle" To: "Marc Kleine-Budde" , "Peng Fan (OSS)" X-Mailer: aerc 0.16.0 References: <20240930-spi-v2-0-ed7f6bcbe0df@nxp.com> <20240930-spi-v2-2-ed7f6bcbe0df@nxp.com> <20240930-wonderful-wealthy-aardwolf-b455d6-mkl@pengutronix.de> <20240930-amaranth-stallion-of-fantasy-67701d-mkl@pengutronix.de> In-Reply-To: <20240930-amaranth-stallion-of-fantasy-67701d-mkl@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241007_005045_400323_6A4DE276 X-CRM114-Status: GOOD ( 12.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --4f89559e3e3addf49573992635c3f51e2eb8df6bf427dc56eda58fc4e794 Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi, > > > + ret =3D devm_regulator_get_enable(dev, "vcc"); > > > + if (ret) > > > + return ret; > > > + > >=20 > > What happens if the SPI-NOR doesn't have a "vcc" regulator? > > ...the SPI-NOR will use the dummy regulator. Which then prints a warning "using dummy regulator". Is that the usual way to go? I mean the regulator is actually mandatory because it is the main voltage rail for the flash. To get rid of the warning one can add a fixed-regulator (which is correct anyway). But OTOH, the device tree lists it as optional (marking it as required isn't an option either because virtually all device trees won't have that property). -michael --4f89559e3e3addf49573992635c3f51e2eb8df6bf427dc56eda58fc4e794 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iKgEABMJADAWIQTIVZIcOo5wfU/AngkSJzzuPgIf+AUCZwOS0BIcbXdhbGxlQGtl cm5lbC5vcmcACgkQEic87j4CH/itIQGAlVlJTTCQIXmqzui5WhdsuBn8I74X+Pl7 YIOZ5srEjl+s75tdMuZ79ixoF50nGGX2AXwJv/geIp9+ua4N3snMvPChaw43SAbu nfe1itE/wQHdobQbIS5fXEZsl0asg29UJfg= =bBef -----END PGP SIGNATURE----- --4f89559e3e3addf49573992635c3f51e2eb8df6bf427dc56eda58fc4e794--