From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B38ABCEFC41 for ; Tue, 8 Oct 2024 18:57:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References: Subject:Cc:To:From:Message-Id:Date:Content-Type:Mime-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JDuErN1Auxr6ysu/+eLU20CGd8PRtkQZVoMuxVC2HnU=; b=gsHgvk0vr0ElH6Yg6qtL97aCB3 uBFgJhf+5Wb7g80xyxzPdpfm4Pb71+b2YC/jsaopluprYiyB/3yIXerSCUViQUpc3iK5+20I2k+ei C0UuGW1xisxOuJUnUIsUYYCNQpKXkkdgygSuBJE3DHuMjuT1NxlUXtg+VnLPte8C8jwCp3kGFu4wR 3f97mRpIvdAPTeMPhUBdIMqn5QIHFAqUX6EpYyYzY6L7KfVOV6O2xrkYfnWf3WUBjJTjxX5LgGpuc +dl+KwBcmCEPd83EIqFJD7cpt0Ph9rpusTP5l5Ru/arqicaAiiL8y61L0eZI3ju8sYpZ+NpTWD3nd FMVT29Vw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syFOT-00000006s4H-17wg; Tue, 08 Oct 2024 18:57:13 +0000 Received: from out-183.mta0.migadu.com ([2001:41d0:1004:224b::b7]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syFN7-00000006rr0-3tkV for linux-arm-kernel@lists.infradead.org; Tue, 08 Oct 2024 18:55:52 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1728413746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JDuErN1Auxr6ysu/+eLU20CGd8PRtkQZVoMuxVC2HnU=; b=By/cPCEbi14X259+giAyG1muNCXQuu/bN4P640/FesFGvqDGXyyNqFyUMzXmsCbzP9GRw0 of7uW+mJALcUd7XrpCHYk3VaC1Y/eL/+36CslzVJYNXq3Dhk+TPOYdF9Y60yKYz9QGXU06 l/6GCj7jdKUIQARQSUHdLxP8167kKWKMZp4qFoADE8SGCG1NbzV+BIJtGHomD2CFpTeQa0 zNnJKsufxzo40D276oaUKPEYS7HwHEIp1wUjumpX/ER3PHHmfNmz7x0LRjuA8BgKRSV73Q 6G/D51UfCJTb9s7lIv+5OjDYoZRvTHinp836YJmV0y8e+H586WFlVEj2aysBLA== Content-Type: multipart/signed; boundary=739a0fdf5b1fcc13df7ae7eaf2f2533e1b5977cf4b7fc59b27bf68bef8be; micalg=pgp-sha256; protocol="application/pgp-signature" Date: Tue, 08 Oct 2024 20:55:34 +0200 Message-Id: X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Michael Riesch" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Heiko Stuebner" Cc: "Dragan Simic" , "Samuel Holland" , , , , , "Diederik de Haas" Subject: Re: [PATCH v2 1/4] arm64: dts: rockchip: Add PD to csi dphy node on rk356x References: <20241008113344.23957-1-didi.debian@cknow.org> <20241008113344.23957-2-didi.debian@cknow.org> In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_115550_848799_4F1A5DA6 X-CRM114-Status: GOOD ( 28.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --739a0fdf5b1fcc13df7ae7eaf2f2533e1b5977cf4b7fc59b27bf68bef8be Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi Michael, On Tue Oct 8, 2024 at 2:32 PM CEST, Michael Riesch wrote: > On 10/8/24 13:15, Diederik de Haas wrote: > > The "rockchip-inno-csi-dphy.yaml" binding requires the power-domains > > property. According to RK3568 TRM Part 1 section 7.3 (page 475) the > > CSIHOST is placed in the PD_VI power domain. > > So set the csi_dphy node power-domains property accordingly. > > Thanks for the patch. However, I am not sure about this one. Thanks for your reply. > The CSI host sure is in this power domain, but we are talking about the > CSI PHY here, right? According to the table CSIPHY is part of the power > domain "ALIVE", which leads me to believe that the power domain is not > necessary here. However, I guess you could put "RK3568_PD_LOGIC_ALIVE" he= re. > > It should be noted, though, that I still haven't figured out what the > role of this CSI host actually is. I know that the RK3568 ISP has its > own MIPI CSI host controller within its register space. But I can only > guess right now that this CSI host is somehow linked to the RK3568 > VICAP, which is also capable of receiving MIPI CSI. Maybe we can leave > this up to however brings up the RK3568 VICAP MIPI CSI feature :-) It indeed isn't as clear cut as I want(ed) it to be. Given that you're also the author of commit 29c99fb085ad ("phy: rockchip: add support for the rk356x variant to rockchip-inno-csidphy"), which added support to the driver part, your opinion should have more weight then mine (IMO). Nonetheless, I collected some extra data points: - The TRM part 1 makes several mentions of 'dphy' in a block describing 'GRF_VI_CON1' (page 381 & 382). The above mentioned commit only added 'PHY_REG' for 'CON0', which I assume was deliberate given your response above. But 'GRF_VI_CON1' does have 'VI' in its name - In rk356x.dtsi there are 'dsi_dphy0' and 'dsi_dphy1' which have 'RK3568_PD_VO' in their 'power-domains' property. Page 475 has 'DSIHOST' in 'PD_VO', while 'DSIPHY' is (also) in the 'ALIVE' power domain. So to be consistent it seems to me that 'csi_dphy' should be in 'PD_VI' or the 'dsi_dphy' nodes should be placed/moved to 'RK3568_PD_LOGIC_ALIVE'. - Of all the compatibles from the binding, I only found 'rockchip,px30-csi-dphy' referenced in DT files (next to 'rockchip,rk3568-csi-dphy' in rk356x.dtsi) and in px30.dtsi the 'csi_dphy' node has 'PX30_PD_VI' as value for its 'power-domains' property. But this is all 'circumstantial'; it would be nice to have a clear answer (from Rockchip?). Cheers, Diederik > > Fixes: b6c228401b25 ("arm64: dts: rockchip: add csi dphy node to rk356x= ") > > Signed-off-by: Diederik de Haas > > --- > > changes in v2: > > - No change > >=20 > > arch/arm64/boot/dts/rockchip/rk356x.dtsi | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot= /dts/rockchip/rk356x.dtsi > > index 0ee0ada6f0ab..d581170914f9 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > > @@ -1790,6 +1790,7 @@ csi_dphy: phy@fe870000 { > > clocks =3D <&cru PCLK_MIPICSIPHY>; > > clock-names =3D "pclk"; > > #phy-cells =3D <0>; > > + power-domains =3D <&power RK3568_PD_VI>; > > resets =3D <&cru SRST_P_MIPICSIPHY>; > > reset-names =3D "apb"; > > rockchip,grf =3D <&grf>; --739a0fdf5b1fcc13df7ae7eaf2f2533e1b5977cf4b7fc59b27bf68bef8be Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZwWAKgAKCRDXblvOeH7b bmodAQCBcwCIgvd9UHVv/WX9kntNibQ3vLI0rpAX+9rBhgzvQAEAr3TExg+y9mrl hf4D6cRD9gWX+/OHYN/FLDk/SoNEfQk= =PxK6 -----END PGP SIGNATURE----- --739a0fdf5b1fcc13df7ae7eaf2f2533e1b5977cf4b7fc59b27bf68bef8be--