From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 590A3CFC611 for ; Fri, 11 Oct 2024 08:03:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:From: Subject:Cc:To:Message-Id:Date:Content-Type:Mime-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=x/Bc0fVN2f3md10XL6wu8hXYesW1d3yvz5HBdGjRGWU=; b=4cIplZha38DKmdXb0aNYmt1KIg TI6VOM7IL/egj5WEhJFCEhLDVrbL+ZLT4Hl71lfKFHl+eYYiPLCWfXTeXwjhEzDVKnMka+dewQO2r 693Db0H2qDABIjBfr4ewdHGuau8yOOLWR/6CmGOuUxoO4FC6ZUzOsBfstmrQV7QdNt9cg6wVMxLgv Oxqa7pFAREnQedGZxRBujkJGvgMx2QF8cHkD1TnGSr49SFBfid2hH+f1FsDe5beDZuxELNRsFrLL2 yYQdVFbmFRgh6f6sDPXFad8JmSjp4VfZ7+Z6Ci3OQ1Epcum7OzNR5ZJesZaV9A7RstntX/jslpEwE HTIGmimQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1szAc9-0000000FdeC-1jfQ; Fri, 11 Oct 2024 08:03:09 +0000 Received: from out-174.mta0.migadu.com ([2001:41d0:1004:224b::ae]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1szAZb-0000000FdDU-0cvB for linux-arm-kernel@lists.infradead.org; Fri, 11 Oct 2024 08:00:33 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1728633626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x/Bc0fVN2f3md10XL6wu8hXYesW1d3yvz5HBdGjRGWU=; b=i6lRSdIHKlDIozT5vJH6ojotYpMTC6d3mCOslrqAb+qJJO4WqSssdRGaKppmi9JQM9I/EP /x1SjQtuFpS3nogCJymK6pBEmbkl2hETUtTH2j25L7oz//PgHPJTAmTGSXWC+CxjNGQUPP +K5fTMDtG01s+agUnabRGPaR3XgA1OeZoNyW7LRKXXbSuzuXn2jxcx0yI/dL8szRdb+6ph HA4S6MK4kCBGxMxHJOS1k+ApRCDCo+7yX7cr2cEzqSNmm4sDeYGYXm26ZZsX7kOOVn/BS1 iaxGwCI9+7IXbA7O/U3jviK/M15TGWRjtvr71Lmvo/CeaEL8phpH4tL533THvw== Content-Type: multipart/signed; boundary=af1154c69e001df7fb7f323f84794bbd4d176e15b89faa8d2c6e93554628; micalg=pgp-sha256; protocol="application/pgp-signature" Date: Fri, 11 Oct 2024 10:00:17 +0200 Message-Id: To: "Dragan Simic" , Cc: , , , , , , , "Diederik de Haas" Subject: Re: [PATCH v2] arm64: dts: rockchip: Add dtsi file for RK3399S SoC variant X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" References: In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241011_010031_802597_2710A882 X-CRM114-Status: GOOD ( 19.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --af1154c69e001df7fb7f323f84794bbd4d176e15b89faa8d2c6e93554628 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Fri Oct 11, 2024 at 9:40 AM CEST, Dragan Simic wrote: > Following the hierarchical representation of the SoC data that's been alr= eady > established in the commit 296602b8e5f7 ("arm64: dts: rockchip: Move RK339= 9 > OPPs to dtsi files for SoC variants"), add new SoC dtsi file for the Rock= chip > RK3399S SoC, which is yet another variant of the Rockchip RK3399 SoC. > ... > The RK3399S variant is used in the Pine64 PinePhone Pro only, [1] whose b= oard > dts file included the necessary adjustments to the CPU DVFS OPPs. This c= ommit > effectively moves those adjustments into the separate RK3399S SoC dtsi fi= le, > following the above-mentioned "encapsulation" approach. > ... > --- > ... > .../dts/rockchip/rk3399-pinephone-pro.dts | 23 +--- > arch/arm64/boot/dts/rockchip/rk3399-s.dtsi | 123 ++++++++++++++++++ > 2 files changed, 124 insertions(+), 22 deletions(-) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-s.dtsi > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch= /arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > index 1a44582a49fb..eee6cfb6de01 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > @@ -13,7 +13,7 @@ > #include > #include > #include > -#include "rk3399.dtsi" > +#include "rk3399-s.dtsi" > =20 > / { > model =3D "Pine64 PinePhone Pro"; > @@ -456,27 +456,6 @@ mpu6500@68 { > }; > }; > =20 > -&cluster0_opp { > - opp04 { > - status =3D "disabled"; > - }; > - > - opp05 { > - status =3D "disabled"; > - }; > -}; > - > -&cluster1_opp { > - opp06 { > - opp-hz =3D /bits/ 64 <1500000000>; > - opp-microvolt =3D <1100000 1100000 1150000>; > - }; > - > - opp07 { > - status =3D "disabled"; > - }; > -}; > - > &io_domains { > bt656-supply =3D <&vcc1v8_dvp>; > audio-supply =3D <&vcca1v8_codec>; > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-s.dtsi b/arch/arm64/boot= /dts/rockchip/rk3399-s.dtsi > new file mode 100644 > index 000000000000..e54f451af9f3 > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3399-s.dtsi > @@ -0,0 +1,123 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2016-2017 Fuzhou Rockchip Electronics Co., Ltd > + */ > + > +#include "rk3399-base.dtsi" > + > +/ { > + cluster0_opp: opp-table-0 { > + compatible =3D "operating-points-v2"; > + opp-shared; > + > + opp00 { > + opp-hz =3D /bits/ 64 <408000000>; > + opp-microvolt =3D <825000 825000 1250000>; > + clock-latency-ns =3D <40000>; > + }; > + opp01 { > + opp-hz =3D /bits/ 64 <600000000>; > + opp-microvolt =3D <825000 825000 1250000>; > + }; > + opp02 { > + opp-hz =3D /bits/ 64 <816000000>; > + opp-microvolt =3D <850000 850000 1250000>; > + }; Is there a reason why there isn't a line separator between the various opp nodes? Normally there is one between nodes. Note that in rk3588-opp.dtsi there are no separator lines between the opp nodes, while they do exist between other nodes. And in rk356x.dtsi the opp nodes do have a separator line. Cheers, Diederik --af1154c69e001df7fb7f323f84794bbd4d176e15b89faa8d2c6e93554628 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZwjbEwAKCRDXblvOeH7b bn4ZAP9SAfzaXLnoMbuoF3dTehc8Jr9FMBa7745ZKmbW5eoeFwD+NA0wkfjetNtB JuZcgcqxGj3DzG5bgYci1MaFeWc+2A8= =kuwT -----END PGP SIGNATURE----- --af1154c69e001df7fb7f323f84794bbd4d176e15b89faa8d2c6e93554628--