From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C95BCFD2E4 for ; Fri, 11 Oct 2024 08:35:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To: From:Subject:Cc:Message-Id:Date:Content-Type:Mime-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZPg15Y0RP+O9S/V9OEOgK1OqOrwGsfvcPsISzD4p6E8=; b=eSY+D6FeKcXTxe8xqt3lkOqO66 6WxwUzMQ9geuW9vD4Niy/Tx4YRuEZhCjUXf1FzA89e5fEztqGLaBZvFSJMBuk6vp7dSV+7kG7riiW mABLd/qscjS5ujSX9lL6PV0giCPAUtV5xu+0JVyscHyjaL/yBuIoRF7hekVQiFkEHPmAMYLLgEwEe 0g8/cmjm+aLaCYlSuKm2gWdbLKRh/hJriZ9DFc1zjtGfHm0AAetxPLixy/GNg2Nzhac4NTGTgI+9d WMU4+WAgjMeGT6kghbKcbWO5nt9nwLf6Vn9fKTEGMflKBHeoXUMTzjAehbUxr9ROkkaTP3cWI3QDu ar7RhfOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1szB7Y-0000000FhH3-3ybZ; Fri, 11 Oct 2024 08:35:37 +0000 Received: from out-182.mta1.migadu.com ([95.215.58.182]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1szB6C-0000000Fh7X-0hez for linux-arm-kernel@lists.infradead.org; Fri, 11 Oct 2024 08:34:13 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1728635647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZPg15Y0RP+O9S/V9OEOgK1OqOrwGsfvcPsISzD4p6E8=; b=FxhyWGGjp5JY+vM91T/2yr6NuAnXEteHRXJdFgJGorqnoaO79L6Ce591gR8yj1dJg/U9Ot ztLsT/NhDIIhHiZwHPJpmA/OHKq4LwXfvdDl2JH8KQ4p0zTUQMqBWiQ1UffVJctfW9Xz+q sSXwY7Fhr8HpTAxUKDAlKq4Jn9QhXlokawy3Txpbw3S/0Mu1tuW8tszT4AfVzNelQL+2vY W+XZRerIW02tBXZow14YxXBFRcYTpaiImiL1YHpG7sRXIDfEJCNL2QwskaCpJhcU4CVfuh 0sDicuGD2UiOSFtA5lJEeAcgl87grLfHMyXMKEoprWkpKpDlN2agSggzzW4/og== Content-Type: multipart/signed; boundary=8137794f5a62e3778c97b3857ef924c4846dffef6a1602a5ab2839f55273; micalg=pgp-sha256; protocol="application/pgp-signature" Date: Fri, 11 Oct 2024 10:33:56 +0200 Message-Id: Cc: , , , , , , , Subject: Re: [PATCH v2] arm64: dts: rockchip: Add dtsi file for RK3399S SoC variant X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Dragan Simic" References: <20da65423e77e13511cc7c7bb39e0246@manjaro.org> In-Reply-To: <20da65423e77e13511cc7c7bb39e0246@manjaro.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241011_013412_548947_59929D1F X-CRM114-Status: GOOD ( 27.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --8137794f5a62e3778c97b3857ef924c4846dffef6a1602a5ab2839f55273 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi Dragan, On Fri Oct 11, 2024 at 10:23 AM CEST, Dragan Simic wrote: > On 2024-10-11 10:00, Diederik de Haas wrote: > > On Fri Oct 11, 2024 at 9:40 AM CEST, Dragan Simic wrote: > >> Following the hierarchical representation of the SoC data that's been= =20 > >> already > >> established in the commit 296602b8e5f7 ("arm64: dts: rockchip: Move=20 > >> RK3399 > >> OPPs to dtsi files for SoC variants"), add new SoC dtsi file for the= =20 > >> Rockchip > >> RK3399S SoC, which is yet another variant of the Rockchip RK3399 SoC. > >> ... > >> The RK3399S variant is used in the Pine64 PinePhone Pro only, [1]=20 > >> whose board > >> dts file included the necessary adjustments to the CPU DVFS OPPs. =20 > >> This commit > >> effectively moves those adjustments into the separate RK3399S SoC dtsi= =20 > >> file, > >> following the above-mentioned "encapsulation" approach. > >> ... > >> --- > >> ... > >> .../dts/rockchip/rk3399-pinephone-pro.dts | 23 +--- > >> arch/arm64/boot/dts/rockchip/rk3399-s.dtsi | 123=20 > >> ++++++++++++++++++ > >> 2 files changed, 124 insertions(+), 22 deletions(-) > >> create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-s.dtsi > >>=20 > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts=20 > >> b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > >> index 1a44582a49fb..eee6cfb6de01 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > >> @@ -13,7 +13,7 @@ > >> #include > >> #include > >> #include > >> -#include "rk3399.dtsi" > >> +#include "rk3399-s.dtsi" > >>=20 > >> / { > >> model =3D "Pine64 PinePhone Pro"; > >> @@ -456,27 +456,6 @@ mpu6500@68 { > >> }; > >> }; > >>=20 > >> -&cluster0_opp { > >> - opp04 { > >> - status =3D "disabled"; > >> - }; > >> - > >> - opp05 { > >> - status =3D "disabled"; > >> - }; > >> -}; > >> - > >> -&cluster1_opp { > >> - opp06 { > >> - opp-hz =3D /bits/ 64 <1500000000>; > >> - opp-microvolt =3D <1100000 1100000 1150000>; > >> - }; > >> - > >> - opp07 { > >> - status =3D "disabled"; > >> - }; > >> -}; > >> - > >> &io_domains { > >> bt656-supply =3D <&vcc1v8_dvp>; > >> audio-supply =3D <&vcca1v8_codec>; > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-s.dtsi=20 > >> b/arch/arm64/boot/dts/rockchip/rk3399-s.dtsi > >> new file mode 100644 > >> index 000000000000..e54f451af9f3 > >> --- /dev/null > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-s.dtsi > >> @@ -0,0 +1,123 @@ > >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > >> +/* > >> + * Copyright (c) 2016-2017 Fuzhou Rockchip Electronics Co., Ltd > >> + */ > >> + > >> +#include "rk3399-base.dtsi" > >> + > >> +/ { > >> + cluster0_opp: opp-table-0 { > >> + compatible =3D "operating-points-v2"; > >> + opp-shared; > >> + > >> + opp00 { > >> + opp-hz =3D /bits/ 64 <408000000>; > >> + opp-microvolt =3D <825000 825000 1250000>; > >> + clock-latency-ns =3D <40000>; > >> + }; > >> + opp01 { > >> + opp-hz =3D /bits/ 64 <600000000>; > >> + opp-microvolt =3D <825000 825000 1250000>; > >> + }; > >> + opp02 { > >> + opp-hz =3D /bits/ 64 <816000000>; > >> + opp-microvolt =3D <850000 850000 1250000>; > >> + }; > >=20 > > Is there a reason why there isn't a line separator between the various > > opp nodes? Normally there is one between nodes. > > Note that in rk3588-opp.dtsi there are no separator lines between the > > opp nodes, while they do exist between other nodes. > > And in rk356x.dtsi the opp nodes do have a separator line. > > That has also bothered me. :) I already had a look around in various > dts(i) files long time ago and there seems to be no preferred layout. I'm inclined to say the opp ones are the odd ones. > In this particular case, it's better to have no separator lines because > that's what we already have lacking in rk3399.dtsi, rk3399-t.dtsi, etc., > so running something like "diff rk3399.dtsi rk3399-s.dtsi" makes it easy > to see what actually differs in the RK3399 SoC variants, without having > to filter out any whitespace differences. Besides that inconsistencies always seem to 'trigger' me, I especially noticed it as this patch changed it from having separator lines to having no separator lines. Cheers, Diederik --8137794f5a62e3778c97b3857ef924c4846dffef6a1602a5ab2839f55273 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZwji+AAKCRDXblvOeH7b bg2RAQCj+fvzp+GUYQJcF7+6OXVPUfnmAxcAwVezTWHtzmsl+gEAy+yylI4pTDx0 maoPJ50F/e8jwPn4UpZsxyjjSJz5ZQI= =epOB -----END PGP SIGNATURE----- --8137794f5a62e3778c97b3857ef924c4846dffef6a1602a5ab2839f55273--